Migrate simd-ffi run-make test to rmake by Oneirical · Pull Request #128700 · rust-lang/rust (original) (raw)
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation17 Commits1 Checks6 Files changed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
Part of #121876 and the associated Google Summer of Code project.
try-job: x86_64-msvc
try-job: x86_64-mingw
try-job: i686-msvc
try-job: armhf-gnu
try-job: test-various
try-job: aarch64-apple
try-job: x86_64-gnu-llvm-17
r? @jieyouxu
rustbot has assigned @jieyouxu.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.
Use r? to explicitly pick a reviewer
Area: port run-make Makefiles to rmake.rs
Area: The testsuite used to check the correctness of rustc
Status: Awaiting review from the assignee but also interested parties.
Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
labels
This PR modifies tests/run-make/. If this PR is trying to port a Makefile
run-make test to use rmake.rs, please update the
run-make port tracking issue
so we can track our progress. You can either modify the tracking issue
directly, or you can comment on the tracking issue and link this PR.
cc @jieyouxu
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, LGTM for the most parts, I'll run try jobs to check.
Status: This is awaiting some action (such as code changes or more information) from the author.
and removed S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
bors added a commit to rust-lang-ci/rust that referenced this pull request
This comment was marked as outdated.
This comment was marked as outdated.
bors added a commit to rust-lang-ci/rust that referenced this pull request
☀️ Try build successful - checks-actions
Build commit: 25f4a4f (25f4a4f0f07932e16e3880375073ac312a2b3484)
r=me after the nits
@bors delegate+
✌️ @Oneirical, you can now approve this pull request!
If @jieyouxu told you to "r=me" after making some further change, please make that change, then do @bors r=@jieyouxu
📌 Commit 1054054 has been approved by jieyouxu
It is now in the queue for this repository.
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
labels
tgross35 added a commit to tgross35/rust that referenced this pull request
tgross35 added a commit to tgross35/rust that referenced this pull request
tgross35 added a commit to tgross35/rust that referenced this pull request
bors added a commit to rust-lang-ci/rust that referenced this pull request
Rollup of 7 pull requests
Successful merges:
- rust-lang#128206 (Make create_dll_import_lib easier to implement)
- rust-lang#128221 (Add implied target features to target_feature attribute)
- rust-lang#128384 (Add tests to ensure MTE tags are preserved across FFI boundaries)
- rust-lang#128656 (Enable msvc for run-make/rust-lld)
- rust-lang#128691 (Update
compiler-builtinsto 0.1.117) - rust-lang#128700 (Migrate
simd-ffirun-maketest to rmake) - rust-lang#128758 (Specify a minimum supported version for VxWorks)
r? @ghost
@rustbot modify labels: rollup
bors added a commit to rust-lang-ci/rust that referenced this pull request
…llaumeGomez
Rollup of 9 pull requests
Successful merges:
- rust-lang#128206 (Make create_dll_import_lib easier to implement)
- rust-lang#128424 (minor
effectscleanups) - rust-lang#128527 (More information for fully-qualified suggestion when there are multiple impls)
- rust-lang#128656 (Enable msvc for run-make/rust-lld)
- rust-lang#128683 (bootstrap: clear miri's ui test deps when rustc changes)
- rust-lang#128700 (Migrate
simd-ffirun-maketest to rmake) - rust-lang#128753 (Don't arbitrarily choose one upper bound for hidden captured region error message)
- rust-lang#128757 (Migrate
pgo-gen-ltorun-maketest to rmake) - rust-lang#128758 (Specify a minimum supported version for VxWorks)
Failed merges:
- rust-lang#128679 (codegen: better centralize function declaration attribute computation)
r? @ghost
@rustbot modify labels: rollup
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request
Labels
Area: port run-make Makefiles to rmake.rs
Area: The testsuite used to check the correctness of rustc
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)