Specify a minimum supported version for VxWorks by devnexen · Pull Request #128758 · rust-lang/rust (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation20 Commits1 Checks6 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

Document that VxWorks 7 is the minimum supported version.

r? @GuillaumeGomez

rustbot has assigned @GuillaumeGomez.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

devnexen marked this pull request as ready for review

August 6, 2024 20:57

Some changes occurred in src/doc/rustc/src/platform-support

This PR seeks to specify a minimum supported version of VxWorks to 7 to make it more obvious which APIs should be considered usable. Does this seem reasonable, or should a different version be specified?

Asking some people who have contributed to vxworks here or in libc, please comment or thumbs up if the proposed version seems good: @biabbas @jdygert-spok @NicholasBaron @BaoshanPang

Some more context is at #128758

(also, it would be good to have one or two more listed maintainers for VxWorks, which just means you can get pinged when platform-specific questions come up. If anyone here is interested, just submit a PR updating src/doc/rustc/src/platform-support/vxworks.md.)

@@ -20,6 +20,12 @@ Target triplets available:

## Requirements

### OS version

The minimum supported version is VxWorks 7 on x86/64 and ARM64.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are the architectures specified - is something different for ppc and arm32?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minimum supported version of OS would be the same for all VxWorks supported architectures. Although PowerPC targets are not an active consideration during Rust for VxWorks development.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for confirming. @devnexen could you drop the "on x86/64 and ARM64" unless there is a specific reason?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@biabbas does this minimum version seem reasonable to you?

Also, could someone confirm when this version (VxWorks 7) was released? I am having some trouble figuring this out online what the oldest supported version will be.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think VxWorks 7 was released in 2016. Rust was enable for VxWorks in 2019(#61946 ). I've only worked on VxWorks 7.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think Versions older than VxWorks7 would require porting efforts, minimum supported version should be VxWorks7.

But since we would have to go through the changes from VxWorks 6 to VxWorks 7 to confirm the minimum supported version. This seems less reasonable now.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think your PR should be merged first.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@devnexen
Do you have access to VxWorks 6 workbench?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nope.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for confirming. @devnexen could you drop the "on x86/64 and ARM64" unless there is a specific reason?

After these changes, this pr would be good for now.

Just to clarify this should get some feedback before merge:

@rustbot blocked

rustbot added S-blocked

Status: Blocked on something else such as an RFC or other implementation work.

and removed S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

labels

tgross35 changed the title~~VxWorks platform support update proposal~~ VxWorks minimum supported version proposal

tgross35 changed the title~~VxWorks minimum supported version proposal~~ Specify a minimum supported version for VxWorks

This PR seeks to specify a minimum supported version of VxWorks to 7 to make it more obvious which APIs should be considered usable. Does this seem reasonable, or should a different version be specified?

Asking some people who have contributed to vxworks here or in libc, please comment or thumbs up if the proposed version seems good: @biabbas @jdygert-spok @NicholasBaron @BaoshanPang

Some more context is at #128758

(also, it would be good to have one or two more listed maintainers for VxWorks, which just means you can get pinged when platform-specific questions come up. If anyone here is interested, just submit a PR updating src/doc/rustc/src/platform-support/vxworks.md.)

I'm not sure if anyone else is also working on VxWorks rust, thus no one else is listed as a maintainer.

If the specified version is from 2016, I think it is pretty unobjectionable. That is pretty similar to our oldest MacOS (10.12, 2016) and Windows (10, 2015). If there are any problems we can revisit, but this should make the ongoing std support effort more straightforward.

Thanks for getting this documented.

@bors r+ rollup

📌 Commit c8eacd6 has been approved by tgross35

It is now in the queue for this repository.

bors added S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

and removed S-blocked

Status: Blocked on something else such as an RFC or other implementation work.

labels

tgross35 added a commit to tgross35/rust that referenced this pull request

…ross35

Specify a minimum supported version for VxWorks

Document that VxWorks 7 is the minimum supported version.

bors added a commit to rust-lang-ci/rust that referenced this pull request

Rollup of 7 pull requests

Successful merges:

rust-lang#128206 (Make create_dll_import_lib easier to implement)
rust-lang#128221 (Add implied target features to target_feature attribute)
rust-lang#128384 (Add tests to ensure MTE tags are preserved across FFI boundaries)
rust-lang#128656 (Enable msvc for run-make/rust-lld)
rust-lang#128691 (Update compiler-builtins to 0.1.117)
rust-lang#128700 (Migrate simd-ffi run-make test to rmake)
rust-lang#128758 (Specify a minimum supported version for VxWorks)

r? @ghost @rustbot modify labels: rollup

bors added a commit to rust-lang-ci/rust that referenced this pull request

…llaumeGomez

Rollup of 9 pull requests

Successful merges:

rust-lang#128206 (Make create_dll_import_lib easier to implement)
rust-lang#128424 (minor effects cleanups)
rust-lang#128527 (More information for fully-qualified suggestion when there are multiple impls)
rust-lang#128656 (Enable msvc for run-make/rust-lld)
rust-lang#128683 (bootstrap: clear miri's ui test deps when rustc changes)
rust-lang#128700 (Migrate simd-ffi run-make test to rmake)
rust-lang#128753 (Don't arbitrarily choose one upper bound for hidden captured region error message)
rust-lang#128757 (Migrate pgo-gen-lto run-make test to rmake)
rust-lang#128758 (Specify a minimum supported version for VxWorks)

Failed merges:

rust-lang#128679 (codegen: better centralize function declaration attribute computation)

r? @ghost @rustbot modify labels: rollup

rust-timer added a commit to rust-lang-ci/rust that referenced this pull request

Rollup merge of rust-lang#128758 - devnexen:vxworks_release_min, r=tgross35

Specify a minimum supported version for VxWorks

Document that VxWorks 7 is the minimum supported version.

Labels

S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.