Distribute rustc_codegen_cranelift for Windows by bjorn3 · Pull Request #128939 · rust-lang/rust (original) (raw)
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
With support for raw-dylib recently added to cg_clif, and inline assembly support working on Windows for quite a while now, all blockers for distributing cg_clif on Windows that I mentioned in #81746 (comment) are fixed now.
saethlin, SkiFire13, tgross35, Luracasmus, mominul, Kobzol, and crispy-strawberry reacted with heart emoji lqd, y21, saethlin, jieyouxu, fbstj, Luracasmus, RossSmyth, mominul, Kobzol, akimakinai, and crispy-strawberry reacted with rocket emoji
rustbot has assigned @albertlarsan68.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.
Use r? to explicitly pick a reviewer
Area: The testsuite used to check the correctness of rustc
Status: Awaiting review from the assignee but also interested parties.
Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Relevant to the infrastructure team, which will review and decide on the PR/issue.
labels
bors added a commit to rust-lang-ci/rust that referenced this pull request
…
[WIP] Distribute rustc_codegen_cranelift for Windows
try-job: dist-x86_64-msvc try-job: dist-i686-msvc try-job: dist-i686-mingw try-job: dist-x86_64-mingw
This comment has been minimized.
☀️ Try build successful - checks-actions
Build commit: d3b4306 (d3b4306976392198298d7ef958db7a4c9b0610c5)
If someone on Windows could check if the above try build produced a toolchain with working cg_clif, that would be appreciated.
A reboot later.
I was expecting to install it like the following:
> rustup-toolchain-install-master d3b4306976392198298d7ef958db7a4c9b0610c5 --component rustc-codegen-cranelift-preview
error: missing component `rustc-codegen-cranelift-preview` on toolchain `d3b4306976392198298d7ef958db7a4c9b0610c5` on channel `nightly` for target `x86_64-pc-windows-msvc`
With luck I tried with the component named as rustc-codegen-cranelift though, and the toolchain installed successfully!
This is how a helloworld looks:
$ cargo clean -q && CARGO_PROFILE_DEV_CODEGEN_BACKEND=cranelift cargo +d3b4306976392198298d7ef958db7a4c9b0610c5 run -Zcodegen-backend -q
Hello, world!
I'm not sure if there's a way to ensure cg_clif was used, but I'd assume so.
[WIP] Distribute rustc_codegen_cranelift for Windows Distribute rustc_codegen_cranelift for Windows
Things relevant to the [future] cranelift backend
and removed A-testsuite
Area: The testsuite used to check the correctness of rustc
labels
(sorry for the slow review, I needed time off)
Thanks for the PR!
@bors r+
📌 Commit 2dbc976 has been approved by albertlarsan68
It is now in the queue for this repository.
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request
…r=albertlarsan68
Distribute rustc_codegen_cranelift for Windows
With support for raw-dylib recently added to cg_clif, and inline assembly support working on Windows for quite a while now, all blockers for distributing cg_clif on Windows that I mentioned in rust-lang#81746 (comment) are fixed now.
bors added a commit to rust-lang-ci/rust that referenced this pull request
…llaumeGomez
Rollup of 7 pull requests
Successful merges:
- rust-lang#119229 (Update mingw-w64 + GNU toolchain)
- rust-lang#128871 (bypass linker configuration and cross target check for specific commands)
- rust-lang#128939 (Distribute rustc_codegen_cranelift for Windows)
- rust-lang#129529 (Add test to build crates used by r-a on stable)
- rust-lang#129624 (Adjust
memchrpinning and runcargo update) - rust-lang#129835 (enable const-float-classify test, and test_next_up/down on 32bit x86)
- rust-lang#130009 (rustdoc-search: allow trailing
Foo ->arg search)
r? @ghost
@rustbot modify labels: rollup
I wonder if this the one which failed in #130027...
Doesn't look like it, windows CI's just on fire at the moment, but you can rollup=never if that'd make you feel better :)
I was just blindly guessing because no PR seemed to fit the failure and someone commented on the rollup that it's a known flaky bug. So all good here.
workingjubilee added a commit to workingjubilee/rustc that referenced this pull request
…r=albertlarsan68
Distribute rustc_codegen_cranelift for Windows
With support for raw-dylib recently added to cg_clif, and inline assembly support working on Windows for quite a while now, all blockers for distributing cg_clif on Windows that I mentioned in rust-lang#81746 (comment) are fixed now.
workingjubilee added a commit to workingjubilee/rustc that referenced this pull request
…r=albertlarsan68
Distribute rustc_codegen_cranelift for Windows
With support for raw-dylib recently added to cg_clif, and inline assembly support working on Windows for quite a while now, all blockers for distributing cg_clif on Windows that I mentioned in rust-lang#81746 (comment) are fixed now.
bors added a commit to rust-lang-ci/rust that referenced this pull request
It's not about you, it's about Windows.
@bors rollup=iffy
bors added a commit to rust-lang-ci/rust that referenced this pull request
…albertlarsan68
Distribute rustc_codegen_cranelift for Windows
With support for raw-dylib recently added to cg_clif, and inline assembly support working on Windows for quite a while now, all blockers for distributing cg_clif on Windows that I mentioned in rust-lang#81746 (comment) are fixed now.
The job x86_64-msvc-ext2 failed! Check out the build log: (web) (plain)
Click to see the possible cause of the failure (guessed by this bot)
[RUSTC-TIMING] miri test:false 4.409
error: failed to remove file `C:\a\rust\rust\build\x86_64-pc-windows-msvc\stage1-tools\x86_64-pc-windows-msvc\release\miri.exe`
Caused by:
Access is denied. (os error 5)
Command has failed. Rerun with -v to see more details.
local time: Mon, Sep 9, 2024 3:14:55 PM
network time: Mon, 09 Sep 2024 15:14:55 GMT
##[error]Process completed with exit code 1.
Post job cleanup.
Status: Awaiting review from the assignee but also interested parties.
and removed S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
labels
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Finished benchmarking commit (d7522d8): comparison URL.
Overall result: ✅ improvements - no action needed
@rustbot label: -perf-regression
Instruction count
This is a highly reliable metric that was used to determine the overall result at the top of this comment.
| mean | range | count | |
|---|---|---|---|
| Regressions ❌ (primary) | - | - | 0 |
| Regressions ❌ (secondary) | - | - | 0 |
| Improvements ✅ (primary) | - | - | 0 |
| Improvements ✅ (secondary) | -0.5% | [-0.5%, -0.5%] | 1 |
| All ❌✅ (primary) | - | - | 0 |
Max RSS (memory usage)
Results (primary -2.1%, secondary 2.8%)
This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
| mean | range | count | |
|---|---|---|---|
| Regressions ❌ (primary) | - | - | 0 |
| Regressions ❌ (secondary) | 2.8% | [2.6%, 3.0%] | 2 |
| Improvements ✅ (primary) | -2.1% | [-2.1%, -2.1%] | 1 |
| Improvements ✅ (secondary) | - | - | 0 |
| All ❌✅ (primary) | -2.1% | [-2.1%, -2.1%] | 1 |
Cycles
This benchmark run did not return any relevant results for this metric.
Binary size
This benchmark run did not return any relevant results for this metric.
Bootstrap: 757.15s -> 756.6s (-0.07%)
Artifact size: 341.19 MiB -> 341.19 MiB (-0.00%)
bjorn3 pushed a commit to bjorn3/rust that referenced this pull request
…albertlarsan68
Distribute rustc_codegen_cranelift for Windows
With support for raw-dylib recently added to cg_clif, and inline assembly support working on Windows for quite a while now, all blockers for distributing cg_clif on Windows that I mentioned in rust-lang#81746 (comment) are fixed now.
Labels
Things relevant to the [future] cranelift backend
This PR was explicitly merged by bors.
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Relevant to the infrastructure team, which will review and decide on the PR/issue.