Add test to build crates used by r-a on stable by lqd · Pull Request #129529 · rust-lang/rust (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation22 Commits7 Checks6 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

Member

lqd commented

Aug 24, 2024

• Loading

r? @Kobzol

I've opened other PRs for this one to work and they've landed already. I cherry-picked your commit, and added the last remaining pieces we needed I think.

Could not assign reviewer from: Kobzol.
User(s) Kobzol are either the PR author, already assigned, or on vacation, and there are no other candidates.
Use r? to specify someone else to assign.

This comment was marked as outdated.

rustbot added A-run-make

Area: port run-make Makefiles to rmake.rs

S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

T-compiler

Relevant to the compiler team, which will review and decide on the PR/issue.

labels

Aug 24, 2024

I've also removed the cargo nightly feature / RUSTC_BOOTSTRAP

lqd mentioned this pull request

Aug 25, 2024

otherwise the test would build in the source root's target folder

it'll be easier to see and update the list: the other cmd args can just be ignored

All the prerequisite PRs have landed.

lqd marked this pull request as ready for review

August 27, 2024 17:52

This PR modifies tests/run-make/. If this PR is trying to port a Makefile
run-make test to use rmake.rs, please update the
run-make port tracking issue
so we can track our progress. You can either modify the tracking issue
directly, or you can comment on the tracking issue and link this PR.

cc @jieyouxu

The run-make-support library was changed

cc @jieyouxu

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few nits, otherwise LGTM. Thank you for pushing this through!

Thanks! You can r=me once CI is green.

📌 Commit a178559 has been approved by Kobzol

It is now in the queue for this repository.

bors added a commit to rust-lang-ci/rust that referenced this pull request

Sep 4, 2024

Rollup of 8 pull requests

Successful merges:

• rust-lang#101339 (enable -Zrandomize-layout in debug CI builds )
• rust-lang#127021 (Add target support for RTEMS Arm)
• rust-lang#128871 (bypass linker configuration and cross target check for specific commands)
• rust-lang#129471 ([rustdoc] Sort impl associated items by kinds and then by appearance)
• rust-lang#129529 (Add test to build crates used by r-a on stable)
• rust-lang#129624 (Adjust memchr pinning and run cargo update)
• rust-lang#129796 (Unify scraped examples with other code examples)
• rust-lang#129939 (explain why Rvalue::Len still exists)

r? @ghost @rustbot modify labels: rollup

bors added a commit to rust-lang-ci/rust that referenced this pull request

Sep 5, 2024

Rollup of 8 pull requests

Successful merges:

• rust-lang#101339 (enable -Zrandomize-layout in debug CI builds )
• rust-lang#127021 (Add target support for RTEMS Arm)
• rust-lang#128871 (bypass linker configuration and cross target check for specific commands)
• rust-lang#129471 ([rustdoc] Sort impl associated items by kinds and then by appearance)
• rust-lang#129529 (Add test to build crates used by r-a on stable)
• rust-lang#129624 (Adjust memchr pinning and run cargo update)
• rust-lang#129796 (Unify scraped examples with other code examples)
• rust-lang#129939 (explain why Rvalue::Len still exists)

r? @ghost @rustbot modify labels: rollup

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request

Sep 5, 2024

Add test to build crates used by r-a on stable

r? @Kobzol

I've opened other PRs for this one to work and they've landed already. I cherry-picked your commit, and added the last remaining pieces we needed I think.

bors added a commit to rust-lang-ci/rust that referenced this pull request

Sep 5, 2024

…iaskrgr

Rollup of 6 pull requests

Successful merges:

• rust-lang#129529 (Add test to build crates used by r-a on stable)
• rust-lang#129624 (Adjust memchr pinning and run cargo update)
• rust-lang#129720 (Simplify DestProp memory management)
• rust-lang#129796 (Unify scraped examples with other code examples)
• rust-lang#129891 (Do not request sanitizers for naked functions)
• rust-lang#129938 (Elaborate on deriving vs implementing Copy)

Failed merges:

• rust-lang#129471 ([rustdoc] Sort impl associated items by kinds and then by appearance)

r? @ghost @rustbot modify labels: rollup

GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request

Sep 6, 2024

Add test to build crates used by r-a on stable

r? @Kobzol

I've opened other PRs for this one to work and they've landed already. I cherry-picked your commit, and added the last remaining pieces we needed I think.

bors added a commit to rust-lang-ci/rust that referenced this pull request

Sep 6, 2024

…llaumeGomez

Rollup of 7 pull requests

Successful merges:

• rust-lang#119229 (Update mingw-w64 + GNU toolchain)
• rust-lang#128871 (bypass linker configuration and cross target check for specific commands)
• rust-lang#128939 (Distribute rustc_codegen_cranelift for Windows)
• rust-lang#129529 (Add test to build crates used by r-a on stable)
• rust-lang#129624 (Adjust memchr pinning and run cargo update)
• rust-lang#129835 (enable const-float-classify test, and test_next_up/down on 32bit x86)
• rust-lang#130009 (rustdoc-search: allow trailing Foo -> arg search)

r? @ghost @rustbot modify labels: rollup

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request

Sep 8, 2024

Add test to build crates used by r-a on stable

r? @Kobzol

I've opened other PRs for this one to work and they've landed already. I cherry-picked your commit, and added the last remaining pieces we needed I think.

bors added a commit to rust-lang-ci/rust that referenced this pull request

Sep 8, 2024

…iaskrgr

Rollup of 7 pull requests

Successful merges:

• rust-lang#129337 (rustdoc rfc#3662 changes under unstable flags)
• rust-lang#129473 (use download-ci-llvm=true in the default compiler config)
• rust-lang#129529 (Add test to build crates used by r-a on stable)
• rust-lang#130025 (Also emit missing_docs lint with --test to fulfil expectations)
• rust-lang#130070 (Rename variant AddrOfRegion of RegionVariableOrigin to BorrowRegion)
• rust-lang#130087 (remove 'const' from 'Option::iter')
• rust-lang#130092 (Fixes typo in wasm32-wasip2 doc comment)

r? @ghost @rustbot modify labels: rollup

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request

Sep 8, 2024

Add test to build crates used by r-a on stable

r? @Kobzol

I've opened other PRs for this one to work and they've landed already. I cherry-picked your commit, and added the last remaining pieces we needed I think.

bors added a commit to rust-lang-ci/rust that referenced this pull request

Sep 8, 2024

…iaskrgr

Rollup of 7 pull requests

Successful merges:

• rust-lang#129473 (use download-ci-llvm=true in the default compiler config)
• rust-lang#129529 (Add test to build crates used by r-a on stable)
• rust-lang#130025 (Also emit missing_docs lint with --test to fulfil expectations)
• rust-lang#130048 (run-make-support: Add llvm-pdbutil)
• rust-lang#130070 (Rename variant AddrOfRegion of RegionVariableOrigin to BorrowRegion)
• rust-lang#130087 (remove 'const' from 'Option::iter')
• rust-lang#130092 (Fixes typo in wasm32-wasip2 doc comment)

r? @ghost @rustbot modify labels: rollup

workingjubilee added a commit to workingjubilee/rustc that referenced this pull request

Sep 9, 2024

Add test to build crates used by r-a on stable

r? @Kobzol

I've opened other PRs for this one to work and they've landed already. I cherry-picked your commit, and added the last remaining pieces we needed I think.

workingjubilee added a commit to workingjubilee/rustc that referenced this pull request

Sep 9, 2024

Add test to build crates used by r-a on stable

r? @Kobzol

I've opened other PRs for this one to work and they've landed already. I cherry-picked your commit, and added the last remaining pieces we needed I think.

bors added a commit to rust-lang-ci/rust that referenced this pull request

Sep 9, 2024

workingjubilee added a commit to workingjubilee/rustc that referenced this pull request

Sep 10, 2024

Add test to build crates used by r-a on stable

r? @Kobzol

I've opened other PRs for this one to work and they've landed already. I cherry-picked your commit, and added the last remaining pieces we needed I think.

bors added a commit to rust-lang-ci/rust that referenced this pull request

Sep 10, 2024

bors added a commit to rust-lang-ci/rust that referenced this pull request

Sep 10, 2024

bors added a commit to rust-lang-ci/rust that referenced this pull request

Sep 10, 2024

rust-timer added a commit to rust-lang-ci/rust that referenced this pull request

Sep 10, 2024

Rollup merge of rust-lang#129529 - lqd:stable-new-solver, r=Kobzol

Add test to build crates used by r-a on stable

r? @Kobzol

I've opened other PRs for this one to work and they've landed already. I cherry-picked your commit, and added the last remaining pieces we needed I think.

lqd deleted the stable-new-solver branch

September 10, 2024 10:42

A very late thanks for this test btw :)

Labels

A-run-make

Area: port run-make Makefiles to rmake.rs

S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

T-compiler

Relevant to the compiler team, which will review and decide on the PR/issue.