[DO NOT MERGE] testing dump-ice-to-disk by jieyouxu · Pull Request #128958 · rust-lang/rust (original) (raw)

jieyouxu

Now how flakey is this

r? @ghost

try-job: i686-mingw

@jieyouxu

@jieyouxu

@jieyouxu jieyouxu added S-experimental

Status: Ongoing experiment that does not require reviewing and won't be merged in its current state.

and removed S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

labels

Aug 11, 2024

bors added a commit to rust-lang-ci/rust that referenced this pull request

Aug 11, 2024

@bors

[DO NOT MERGE] testing dump-ice-to-disk

Now how flakey is this

r? @ghost

try-job: i686-mingw

@bors

@bors

☀️ Try build successful - checks-actions
Build commit: f9dcb45 (f9dcb45c20d725d30a40852bf4eb711353e3cc2c)

@jieyouxu

@jieyouxu

bors added a commit to rust-lang-ci/rust that referenced this pull request

Aug 11, 2024

@bors

[DO NOT MERGE] testing dump-ice-to-disk

Now how flakey is this

r? @ghost

try-job: i686-mingw

@bors

@bors

☀️ Try build successful - checks-actions
Build commit: c83dfe4 (c83dfe4ecde3ec3c157dceaa816b47b0d349cb64)

@jieyouxu

bors added a commit to rust-lang-ci/rust that referenced this pull request

Aug 11, 2024

@bors

[DO NOT MERGE] testing dump-ice-to-disk

Now how flakey is this

r? @ghost

try-job: i686-mingw

@bors

@bors

☀️ Try build successful - checks-actions
Build commit: 9e1ba1a (9e1ba1ac99fc10f06d352485a1696849eb925f78)

@jieyouxu

@bors

bors added a commit to rust-lang-ci/rust that referenced this pull request

Aug 11, 2024

@bors

[DO NOT MERGE] testing dump-ice-to-disk

Now how flakey is this

r? @ghost

try-job: i686-mingw

@bors

☀️ Try build successful - checks-actions
Build commit: 7c123c0 (7c123c0261a9a4bfdc0975f17815c4cc1a390fd7)

@jieyouxu

Stop succeeding, start failing!

@jieyouxu

bors added a commit to rust-lang-ci/rust that referenced this pull request

Aug 11, 2024

@bors

[DO NOT MERGE] testing dump-ice-to-disk

Now how flakey is this

r? @ghost

try-job: i686-mingw

@bors

@bors

☀️ Try build successful - checks-actions
Build commit: cae0ba6 (cae0ba6a1e5100ee11000c15da246f8a18723a34)

@jieyouxu

@bors

bors added a commit to rust-lang-ci/rust that referenced this pull request

Aug 12, 2024

@bors

[DO NOT MERGE] testing dump-ice-to-disk

Now how flakey is this

r? @ghost

try-job: i686-mingw

@bors

☀️ Try build successful - checks-actions
Build commit: 8821303 (8821303ac12e8b892aef82c6d8e1234470698728)

@jieyouxu

bors added a commit to rust-lang-ci/rust that referenced this pull request

Aug 12, 2024

@bors

[DO NOT MERGE] testing dump-ice-to-disk

Now how flakey is this

r? @ghost

try-job: i686-mingw

@bors

@bors

☀️ Try build successful - checks-actions
Build commit: 15cf78a (15cf78ad4a6e2c242f60bc71d0893b658cff0fbf)

@jieyouxu

@jieyouxu

@bors

bors added a commit to rust-lang-ci/rust that referenced this pull request

Aug 12, 2024

@bors

[DO NOT MERGE] testing dump-ice-to-disk

Now how flakey is this

r? @ghost

try-job: i686-mingw

@bors

☀️ Try build successful - checks-actions
Build commit: 265f66c (265f66c8576d03d28ac1c6b2b1d9a27dd106379e)

@jieyouxu

@bors

bors added a commit to rust-lang-ci/rust that referenced this pull request

Aug 12, 2024

@bors

[DO NOT MERGE] testing dump-ice-to-disk

Now how flakey is this

r? @ghost

try-job: i686-mingw

@ChrisDenton

Maybe your changes fixed it somehow?

@jieyouxu

Maybe your changes fixed it somehow?

If this try job still passes, I'm going to try remove the ignore-windows for the test and try re-enabling this test on windows in full CI. Maybe something about clearing ICE files versus quarantine it separately in individual temp dirs, or somehow the RUSTC_ICE env fixed it.

@bors

☀️ Try build successful - checks-actions
Build commit: c9eadc1 (c9eadc1d4e918fb08729a39a36655ce3ad9133cf)

rust-cloud-vms bot pushed a commit to jieyouxu/rust that referenced this pull request

Aug 15, 2024

@jieyouxu

This test was previously flakey on i686-mingw, but since some modifications I could no longer make it fail on i686-mingw.

See <rust-lang#128958> for multiple try job runs.

This was referenced

Aug 15, 2024

bors added a commit to rust-lang-ci/rust that referenced this pull request

Aug 15, 2024

@bors

Re-enable dump-ice-to-disk for Windows

This test was previously flakey on i686-mingw, but since some modifications (quarantining each ICE test in separate tmp dirs, adding/removing RUSTC_ICE env vars as suitable to prevent any kind of environmental influence), I could no longer make it fail on i686-mingw.

I tried running this test (without the ignore-windows of course) a bunch of times via i686-mingw try jobs and it refused to fail (see rust-lang#128958).

In any case, if this turns out to be still flakey on i686-mingw, we can revert the removal of ignore-windows but this time we'll have way more context for why the test failed.

Running the i686-mingw alongside some Windows jobs for basic santiy check. But the try jobs succeeding is insufficient to guarantee reproducibility.

cc rust-lang#129115 for backlink.

try-job: x86_64-msvc try-job: x86_64-mingw try-job: i686-msvc try-job: i686-mingw

tgross35 added a commit to tgross35/rust that referenced this pull request

Aug 17, 2024

@tgross35

…bank

Re-enable dump-ice-to-disk for Windows

This test was previously flakey on i686-mingw (reason unknown), but since some modifications (quarantining each ICE test in separate tmp dirs, adding/removing RUSTC_ICE env vars as suitable to prevent any kind of environmental influence), I could no longer make it fail on i686-mingw.

I tried running this test (without the ignore-windows of course) a bunch of times via i686-mingw try jobs and it refused to fail (see rust-lang#128958). I was also never able to reproduce the failure locally.

In any case, if this turns out to be still flakey on i686-mingw, we can revert the removal of ignore-windows but this time we'll have way more context for why the test failed.

Running the i686-mingw alongside some Windows jobs for basic santiy check. But the try jobs succeeding is insufficient to guarantee reproducibility.

cc rust-lang#129115 for backlink.

try-job: x86_64-msvc try-job: x86_64-mingw try-job: i686-msvc try-job: i686-mingw

tgross35 added a commit to tgross35/rust that referenced this pull request

Aug 17, 2024

@tgross35

…bank

Re-enable dump-ice-to-disk for Windows

This test was previously flakey on i686-mingw (reason unknown), but since some modifications (quarantining each ICE test in separate tmp dirs, adding/removing RUSTC_ICE env vars as suitable to prevent any kind of environmental influence), I could no longer make it fail on i686-mingw.

I tried running this test (without the ignore-windows of course) a bunch of times via i686-mingw try jobs and it refused to fail (see rust-lang#128958). I was also never able to reproduce the failure locally.

In any case, if this turns out to be still flakey on i686-mingw, we can revert the removal of ignore-windows but this time we'll have way more context for why the test failed.

Running the i686-mingw alongside some Windows jobs for basic santiy check. But the try jobs succeeding is insufficient to guarantee reproducibility.

cc rust-lang#129115 for backlink.

try-job: x86_64-msvc try-job: x86_64-mingw try-job: i686-msvc try-job: i686-mingw

tgross35 added a commit to tgross35/rust that referenced this pull request

Aug 17, 2024

@tgross35

…bank

Re-enable dump-ice-to-disk for Windows

This test was previously flakey on i686-mingw (reason unknown), but since some modifications (quarantining each ICE test in separate tmp dirs, adding/removing RUSTC_ICE env vars as suitable to prevent any kind of environmental influence), I could no longer make it fail on i686-mingw.

I tried running this test (without the ignore-windows of course) a bunch of times via i686-mingw try jobs and it refused to fail (see rust-lang#128958). I was also never able to reproduce the failure locally.

In any case, if this turns out to be still flakey on i686-mingw, we can revert the removal of ignore-windows but this time we'll have way more context for why the test failed.

Running the i686-mingw alongside some Windows jobs for basic santiy check. But the try jobs succeeding is insufficient to guarantee reproducibility.

cc rust-lang#129115 for backlink.

try-job: x86_64-msvc try-job: x86_64-mingw try-job: i686-msvc try-job: i686-mingw

bors added a commit to rust-lang-ci/rust that referenced this pull request

Aug 18, 2024

@bors

Re-enable dump-ice-to-disk for Windows

This test was previously flakey on i686-mingw (reason unknown), but since some modifications (quarantining each ICE test in separate tmp dirs, adding/removing RUSTC_ICE env vars as suitable to prevent any kind of environmental influence), I could no longer make it fail on i686-mingw.

I tried running this test (without the ignore-windows of course) a bunch of times via i686-mingw try jobs and it refused to fail (see rust-lang#128958). I was also never able to reproduce the failure locally.

In any case, if this turns out to be still flakey on i686-mingw, we can revert the removal of ignore-windows but this time we'll have way more context for why the test failed.

Running the i686-mingw alongside some Windows jobs for basic santiy check. But the try jobs succeeding is insufficient to guarantee reproducibility.

cc rust-lang#129115 for backlink.

try-job: x86_64-msvc try-job: x86_64-mingw try-job: i686-msvc try-job: i686-mingw