Re-enable dump-ice-to-disk for Windows by jieyouxu · Pull Request #129115 · rust-lang/rust (original) (raw)

This test was previously flakey on i686-mingw (reason unknown), but since some modifications (quarantining each ICE test in separate tmp dirs, adding/removing RUSTC_ICE env vars as suitable to prevent any kind of environmental influence), I could no longer make it fail on i686-mingw.

I tried running this test (without the ignore-windows of course) a bunch of times via i686-mingw try jobs and it refused to fail (see #128958). I was also never able to reproduce the failure locally.

In any case, if this turns out to be still flakey on i686-mingw, we can revert the removal of ignore-windows but this time we'll have way more context for why the test failed.

Running the i686-mingw alongside some Windows jobs for basic santiy check. But the try jobs succeeding is insufficient to guarantee reproducibility.

cc #129115 for backlink.

try-job: x86_64-msvc
try-job: x86_64-mingw
try-job: i686-msvc
try-job: i686-mingw