Implement (part of) ACP 429: add DerefMut to Lazy[Cell/Lock] by ChayimFriedman2 · Pull Request #129334 · rust-lang/rust (original) (raw)
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
r? @joboet
rustbot has assigned @joboet.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.
Use r? to explicitly pick a reviewer
Status: Awaiting review from the assignee but also interested parties.
Relevant to the library team, which will review and decide on the PR/issue.
This change is insta-stable, or significant enough to need a team FCP to proceed.
labels
Weird, rustbot seems to be sleeping...
r? libs-api
Relevant to the library API team, which will review and decide on the PR/issue.
label
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The implementation looks good to me, r=me with the nit resolved after the FCP completes.
Gentle ping on this PR, would love this to be merged soon:)
@SteveLauC This depends on a T-libs-api member starting a FCP.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
New APIs need to land as unstable. And an FCP isn't needed for that. There should also be a tracking issue. And the ACP should be linked.
Status: This is awaiting some action (such as code changes or more information) from the author.
and removed S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Looks like this PR includes DerefMut, which is a trait impl, so that part does need an FCP.
Can you split this into two? One that's just T-libs and only adds unstable methods, and one that's T-libs-api with the stable trait impl. The former can land much more easily than the latter.
@BurntSushi @scottmcm This PR needs FCP for DerefMut and force_mut(), which, as I said in the OP, I decided to make instantly stable because it makes little sense to separate it from DerefMut.
For get_mut(), I already opened a tracking issue: #129333. I can split the PR though.
DerefMut is instantly stable, as a trait impl; as such, I decided to also instantly stabilize
force_mut(), since it makes little sense to have one but not the other. That means this needs an FCP.
so you're saying we could land force_mut() on nightly as unstable and then decide to stabilize DerefMut with it?
DerefMut is instantly stable, as a trait impl; as such, I decided to also instantly stabilize
force_mut(), since it makes little sense to have one but not the other. That means this needs an FCP.so you're saying we could land
force_mut()on nightly as unstable and then decide to stabilizeDerefMutwith it?
That's an option, but that's not what I'm doing in this PR. Instead, I instantly stabilize both.
@rustbot ready
I modified this to only add (immediately stable) DerefMut, after the other methods has been added unstably in #130476. This is now ready for FCP.
Although, libs-api may not want to include this until force_mut() stabilizes, or people may resort to this as a workaround (although I expect DerefMut to be used more often anyway, just like Deref vs. force()).
Status: Awaiting review from the assignee but also interested parties.
and removed S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
labels
Team member @Amanieu has proposed to merge this. The next step is review by the rest of the tagged team members:
No concerns currently listed.
Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!
See this document for info about what commands tagged team members can give me.
🔔 This is now entering its final comment period, as per the review above. 🔔
The final comment period, with a disposition to merge, as per the review above, is now complete.
As the automated representative of the governance process, I would like to thank the author for their work and everyone else who contributed.
This will be merged soon.
📌 Commit b208706 has been approved by Amanieu
It is now in the queue for this repository.
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Zalathar added a commit to Zalathar/rust that referenced this pull request
… r=Amanieu
Implement (part of) ACP 429: add DerefMut to Lazy[Cell/Lock]
DerefMut is instantly stable, as a trait impl. That means this needs an FCP.
@rustbot label +needs-fcp
bors added a commit to rust-lang-ci/rust that referenced this pull request
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request
… r=Amanieu
Implement (part of) ACP 429: add DerefMut to Lazy[Cell/Lock]
DerefMut is instantly stable, as a trait impl. That means this needs an FCP.
@rustbot label +needs-fcp
bors added a commit to rust-lang-ci/rust that referenced this pull request
…iaskrgr
Rollup of 8 pull requests
Successful merges:
- rust-lang#129334 (Implement (part of) ACP 429: add
DerefMuttoLazy[Cell/Lock]) - rust-lang#139562 (rustdoc: add a handle that makes sidebar resizing more obvious)
- rust-lang#140151 (remove intrinsics::drop_in_place)
- rust-lang#140660 (remove 'unordered' atomic intrinsics)
- rust-lang#140783 (Update documentation of OnceLock::get_or_init.)
- rust-lang#140789 (Update hermit-abi to 0.5.1)
- rust-lang#140792 (Use intrinsics for
{f16,f32,f64,f128}::{minimum,maximum}operations) - rust-lang#140879 (1.87.0 release notes: remove nonsensical
~operator)
r? @ghost
@rustbot modify labels: rollup
bors added a commit to rust-lang-ci/rust that referenced this pull request
…iaskrgr
Rollup of 7 pull requests
Successful merges:
- rust-lang#129334 (Implement (part of) ACP 429: add
DerefMuttoLazy[Cell/Lock]) - rust-lang#139562 (rustdoc: add a handle that makes sidebar resizing more obvious)
- rust-lang#140151 (remove intrinsics::drop_in_place)
- rust-lang#140660 (remove 'unordered' atomic intrinsics)
- rust-lang#140783 (Update documentation of OnceLock::get_or_init.)
- rust-lang#140789 (Update hermit-abi to 0.5.1)
- rust-lang#140879 (1.87.0 release notes: remove nonsensical
~operator)
r? @ghost
@rustbot modify labels: rollup
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request
Rollup merge of rust-lang#129334 - ChayimFriedman2:more-lazy-methods, r=Amanieu
Implement (part of) ACP 429: add DerefMut to Lazy[Cell/Lock]
DerefMut is instantly stable, as a trait impl. That means this needs an FCP.
@rustbot label +needs-fcp
github-actions bot pushed a commit to carolynzech/rust that referenced this pull request
… r=Amanieu
Implement (part of) ACP 429: add DerefMut to Lazy[Cell/Lock]
DerefMut is instantly stable, as a trait impl. That means this needs an FCP.
@rustbot label +needs-fcp
Labels
This issue / PR is in PFCP or FCP with a disposition to merge it.
The final comment period is finished for this PR / Issue.
This change is insta-stable, or significant enough to need a team FCP to proceed.
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Relevant to the library API team, which will review and decide on the PR/issue.