Make ./x.py <cmd> compiler/<crate> aware of the crate's features by Veykril · Pull Request #129781 · rust-lang/rust (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation5 Commits1 Checks6 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

Does not fix #129727 on its own as the way the parallel-compiler cfg and feature flags are setup being generally incompatible with resolver = 2 but it progresses on the issue. But this should in theory allow compiler crates to work that do not depend on the parallel compiler stuff (so some leaf crates).

r? @albertlarsan68

rustbot has assigned @albertlarsan68.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

rustbot added S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

T-bootstrap

Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

labels

Aug 30, 2024

This comment has been minimized.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks for the PR!
@bors r+

📌 Commit 39e3add has been approved by albertlarsan68

It is now in the queue for this repository.

bors added S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

and removed S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

labels

Sep 4, 2024

workingjubilee added a commit to workingjubilee/rustc that referenced this pull request

Sep 6, 2024

… r=albertlarsan68

Make ./x.py <cmd> compiler/<crate> aware of the crate's features

Does not fix rust-lang#129727 on its own as the way the parallel-compiler cfg and feature flags are setup being generally incompatible with resolver = 2 but it progresses on the issue. But this should in theory allow compiler crates to work that do not depend on the parallel compiler stuff (so some leaf crates).

workingjubilee added a commit to workingjubilee/rustc that referenced this pull request

Sep 6, 2024

… r=albertlarsan68

Make ./x.py <cmd> compiler/<crate> aware of the crate's features

Does not fix rust-lang#129727 on its own as the way the parallel-compiler cfg and feature flags are setup being generally incompatible with resolver = 2 but it progresses on the issue. But this should in theory allow compiler crates to work that do not depend on the parallel compiler stuff (so some leaf crates).

bors added a commit to rust-lang-ci/rust that referenced this pull request

Sep 6, 2024

bors added a commit to rust-lang-ci/rust that referenced this pull request

Sep 6, 2024

…iaskrgr

Rollup of 6 pull requests

Successful merges:

• rust-lang#129021 (Check WF of source type's signature on fn pointer cast)
• rust-lang#129781 (Make ./x.py <cmd> compiler/<crate> aware of the crate's features)
• rust-lang#129963 (Inaccurate {Path,OsStr}::to_string_lossy() documentation)
• rust-lang#129969 (Make Ty::boxed_ty return an Option)
• rust-lang#129995 (Remove wasm32-wasip2's tier 2 status from release notes)
• rust-lang#130013 (coverage: Count await when the Future is immediately ready )

r? @ghost @rustbot modify labels: rollup

rust-timer added a commit to rust-lang-ci/rust that referenced this pull request

Sep 6, 2024

Rollup merge of rust-lang#129781 - Veykril:lw-x-py-compiler-features, r=albertlarsan68

Make ./x.py <cmd> compiler/<crate> aware of the crate's features

Does not fix rust-lang#129727 on its own as the way the parallel-compiler cfg and feature flags are setup being generally incompatible with resolver = 2 but it progresses on the issue. But this should in theory allow compiler crates to work that do not depend on the parallel compiler stuff (so some leaf crates).

Labels

S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

T-bootstrap

Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)