Crater for rustdoc test merging by ehuss · Pull Request #130285 · rust-lang/rust (original) (raw)
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation10 Commits1 Checks6 Files changed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
Status: Awaiting review from the assignee but also interested parties.
Relevant to the rustdoc team, which will review and decide on the PR/issue.
labels
bors added a commit to rust-lang-ci/rust that referenced this pull request
This comment was marked as resolved.
☀️ Try build successful - checks-actions
Build commit: 024495a (024495a232636f1f9407d7695b2be51edc2c51bd)
🚨 Error: failed to parse the command
🆘 If you have any trouble with Crater please ping @rust-lang/infra!
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more
bors added a commit to rust-lang-ci/rust that referenced this pull request
[CRATER] Crater rollup
This is a crater rollup of:
What is a crater rollup? It's simply a (manually set-up) crater job that is run on all of the containing PRs together, and then we can set the crates list for each of these jobs to just the list of failures after it's done. It should cut out on the bulk of "normal" crates that do nothing and simply just waste time to build without being affected by the union of all of these changes.
After this is finished, I will adjust all of the jobs to use only the list of failed crates. That should significantly speed up these jobs from taking like ~6 days to taking ~2. See the last time I did this: rust-lang#129660.
Given that rust-lang#130285 is running in build-and-test mode, let's run all of them in build-and-test mode.
🚧 Experiment pr-130285 is now running
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more
bors added a commit to rust-lang-ci/rust that referenced this pull request
…es, r=
Use environment variables instead of command line arguments for merged doctests
Fixes rust-lang#130796.
Before merging this one, let's first ensure it has a smaller impact compared to command line arguments (results can be seen here). I'll start a crater run once CI passed.
cc @ehuss
r? @notriddle
bors added a commit to rust-lang-ci/rust that referenced this pull request
…es, r=
Use environment variables instead of command line arguments for merged doctests
Fixes rust-lang#130796.
Before merging this one, let's first ensure it has a smaller impact compared to command line arguments (results can be seen here). I'll start a crater run once CI passed.
cc @ehuss
r? @notriddle
compiler-errors added a commit to compiler-errors/rust that referenced this pull request
…bles, r=notriddle
Use environment variables instead of command line arguments for merged doctests
Fixes rust-lang#130796.
Before merging this one, let's first ensure it has a smaller impact compared to command line arguments (results can be seen here). I'll start a crater run once CI passed.
cc @ehuss
r? @notriddle
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request
…bles, r=notriddle
Use environment variables instead of command line arguments for merged doctests
Fixes rust-lang#130796.
Before merging this one, let's first ensure it has a smaller impact compared to command line arguments (results can be seen here). I'll start a crater run once CI passed.
cc @ehuss
r? @notriddle
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request
Rollup merge of rust-lang#131095 - GuillaumeGomez:switch-to-env-variables, r=notriddle
Use environment variables instead of command line arguments for merged doctests
Fixes rust-lang#130796.
Before merging this one, let's first ensure it has a smaller impact compared to command line arguments (results can be seen here). I'll start a crater run once CI passed.
cc @ehuss
r? @notriddle
github-actions bot pushed a commit to rust-lang/miri that referenced this pull request
…otriddle
Use environment variables instead of command line arguments for merged doctests
Fixes #130796.
Before merging this one, let's first ensure it has a smaller impact compared to command line arguments (results can be seen here). I'll start a crater run once CI passed.
cc @ehuss
r? @notriddle
Labels
Status: Awaiting review from the assignee but also interested parties.
Relevant to the rustdoc team, which will review and decide on the PR/issue.