Use environment variables instead of command line arguments for merged doctests by GuillaumeGomez · Pull Request #131095 · rust-lang/rust (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation22 Commits1 Checks12 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

Fixes #130796.

Before merging this one, let's first ensure it has a smaller impact compared to command line arguments (results can be seen here). I'll start a crater run once CI passed.

cc @ehuss
r? @notriddle

rustbot added S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

T-rustdoc

Relevant to the rustdoc team, which will review and decide on the PR/issue.

labels

Oct 1, 2024

bors added a commit to rust-lang-ci/rust that referenced this pull request

Oct 1, 2024

…es, r=

Use environment variables instead of command line arguments for merged doctests

Fixes rust-lang#130796.

Before merging this one, let's first ensure it has a smaller impact compared to command line arguments (results can be seen here). I'll start a crater run once CI passed.

cc @ehuss r? @notriddle

☀️ Try build successful - checks-actions
Build commit: ff81870 (ff81870ffcd16e9ae89cf4a64234df756776b43a)

🚨 Error: failed to parse the command

🆘 If you have any trouble with Crater please ping @rust-lang/infra!
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

🚧 Experiment pr-131095 is now running

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

🗑️ Experiment pr-131095 deleted!

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

bors added a commit to rust-lang-ci/rust that referenced this pull request

Oct 1, 2024

…es, r=

Use environment variables instead of command line arguments for merged doctests

Fixes rust-lang#130796.

Before merging this one, let's first ensure it has a smaller impact compared to command line arguments (results can be seen here). I'll start a crater run once CI passed.

cc @ehuss r? @notriddle

This comment has been minimized.

☀️ Try build successful - checks-actions
Build commit: f23b224 (f23b22458132fb20faeb8a915b1c252478696f25)

🚧 Experiment pr-131095 is now running

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

Just checked and it seems like the issue is indeed solved. Crates like qst which fails because of the argument parsing are now fine. I removed the extra commit so now the PR is ready for review.

That's good to hear.

@bors r+ rollup

📌 Commit e904761 has been approved by notriddle

It is now in the queue for this repository.

bors added S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

and removed S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

labels

Oct 15, 2024

compiler-errors added a commit to compiler-errors/rust that referenced this pull request

Oct 15, 2024

…bles, r=notriddle

Use environment variables instead of command line arguments for merged doctests

Fixes rust-lang#130796.

Before merging this one, let's first ensure it has a smaller impact compared to command line arguments (results can be seen here). I'll start a crater run once CI passed.

cc @ehuss r? @notriddle

bors added a commit to rust-lang-ci/rust that referenced this pull request

Oct 15, 2024

…iaskrgr

Rollup of 9 pull requests

Successful merges:

• rust-lang#122670 (Fix bug where option_env! would return None when env var is present but not valid Unicode)
• rust-lang#131095 (Use environment variables instead of command line arguments for merged doctests)
• rust-lang#131339 (Expand set_ptr_value / with_metadata_of docs)
• rust-lang#131652 (Move polarity into PolyTraitRef rather than storing it on the side)
• rust-lang#131675 (Update lint message for ABI not supported)
• rust-lang#131681 (Fix up-to-date checking for run-make tests)
• rust-lang#131702 (Suppress import errors for traits that couldve applied for method lookup error)
• rust-lang#131703 (Resolved python deprecation warning in publish_toolstate.py)
• rust-lang#131710 (Remove 'apostrophes' from rustc_parse_format)

r? @ghost @rustbot modify labels: rollup

bors added a commit to rust-lang-ci/rust that referenced this pull request

Oct 15, 2024

…iaskrgr

Rollup of 9 pull requests

Successful merges:

• rust-lang#122670 (Fix bug where option_env! would return None when env var is present but not valid Unicode)
• rust-lang#131095 (Use environment variables instead of command line arguments for merged doctests)
• rust-lang#131339 (Expand set_ptr_value / with_metadata_of docs)
• rust-lang#131652 (Move polarity into PolyTraitRef rather than storing it on the side)
• rust-lang#131675 (Update lint message for ABI not supported)
• rust-lang#131681 (Fix up-to-date checking for run-make tests)
• rust-lang#131702 (Suppress import errors for traits that couldve applied for method lookup error)
• rust-lang#131703 (Resolved python deprecation warning in publish_toolstate.py)
• rust-lang#131710 (Remove 'apostrophes' from rustc_parse_format)

r? @ghost @rustbot modify labels: rollup

bors added a commit to rust-lang-ci/rust that referenced this pull request

Oct 15, 2024

…iaskrgr

Rollup of 9 pull requests

Successful merges:

• rust-lang#122670 (Fix bug where option_env! would return None when env var is present but not valid Unicode)
• rust-lang#131095 (Use environment variables instead of command line arguments for merged doctests)
• rust-lang#131339 (Expand set_ptr_value / with_metadata_of docs)
• rust-lang#131652 (Move polarity into PolyTraitRef rather than storing it on the side)
• rust-lang#131675 (Update lint message for ABI not supported)
• rust-lang#131681 (Fix up-to-date checking for run-make tests)
• rust-lang#131702 (Suppress import errors for traits that couldve applied for method lookup error)
• rust-lang#131703 (Resolved python deprecation warning in publish_toolstate.py)
• rust-lang#131710 (Remove 'apostrophes' from rustc_parse_format)

r? @ghost @rustbot modify labels: rollup

rust-timer added a commit to rust-lang-ci/rust that referenced this pull request

Oct 15, 2024

Rollup merge of rust-lang#131095 - GuillaumeGomez:switch-to-env-variables, r=notriddle

Use environment variables instead of command line arguments for merged doctests

Fixes rust-lang#130796.

Before merging this one, let's first ensure it has a smaller impact compared to command line arguments (results can be seen here). I'll start a crater run once CI passed.

cc @ehuss r? @notriddle

flip1995 pushed a commit to flip1995/rust that referenced this pull request

Oct 18, 2024

…iaskrgr

Rollup of 9 pull requests

Successful merges:

• rust-lang#122670 (Fix bug where option_env! would return None when env var is present but not valid Unicode)
• rust-lang#131095 (Use environment variables instead of command line arguments for merged doctests)
• rust-lang#131339 (Expand set_ptr_value / with_metadata_of docs)
• rust-lang#131652 (Move polarity into PolyTraitRef rather than storing it on the side)
• rust-lang#131675 (Update lint message for ABI not supported)
• rust-lang#131681 (Fix up-to-date checking for run-make tests)
• rust-lang#131702 (Suppress import errors for traits that couldve applied for method lookup error)
• rust-lang#131703 (Resolved python deprecation warning in publish_toolstate.py)
• rust-lang#131710 (Remove 'apostrophes' from rustc_parse_format)

r? @ghost @rustbot modify labels: rollup

Urgau mentioned this pull request

Oct 26, 2024

Labels

S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

T-rustdoc

Relevant to the rustdoc team, which will review and decide on the PR/issue.