Avoid &Lrc<T> in various places by nnethercote · Pull Request #131344 · rust-lang/rust (original) (raw)
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation5 Commits4 Checks6 Files changed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
Seeing &Lrc<T> is a bit suspicious, and &T or Lrc<T> is often better.
r? @oli-obk
It's simpler and more concise.
Could not assign reviewer from: oli-obk.
User(s) oli-obk are either the PR author, already assigned, or on vacation, and there are no other candidates.
Use r? to specify someone else to assign.
r? @cjgillot
rustbot has assigned @cjgillot.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.
Use r? to explicitly pick a reviewer
Area: Translation infrastructure, and migrating existing diagnostics to SessionDiagnostic
Status: Awaiting review from the assignee but also interested parties.
Relevant to the compiler team, which will review and decide on the PR/issue.
Relevant to the rustdoc team, which will review and decide on the PR/issue.
labels
Some changes occurred in src/tools/rustfmt
cc @rust-lang/rustfmt
Some changes occurred in src/tools/clippy
cc @rust-lang/clippy
rustc_errors::translation was changed
cc @davidtwco, @compiler-errors, @TaKO8Ki
📌 Commit 4547c0a has been approved by compiler-errors
It is now in the queue for this repository.
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
bors added a commit to rust-lang-ci/rust that referenced this pull request
…iaskrgr
Rollup of 4 pull requests
Successful merges:
- rust-lang#131331 (Revert "warn_old_master_branch" check)
- rust-lang#131344 (Avoid
&Lrc<T>in various places) - rust-lang#131346 (Restrict
ignore-mode-*directives) - rust-lang#131353 (Add documentation for
runtest::check_rustdoc_test_optionmethod)
r? @ghost
@rustbot modify labels: rollup
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request
Rollup merge of rust-lang#131344 - nnethercote:ref-Lrc, r=compiler-errors
Avoid &Lrc<T> in various places
Seeing &Lrc<T> is a bit suspicious, and &T or Lrc<T> is often better.
r? @oli-obk
flip1995 pushed a commit to flip1995/rust that referenced this pull request
…iaskrgr
Rollup of 4 pull requests
Successful merges:
- rust-lang#131331 (Revert "warn_old_master_branch" check)
- rust-lang#131344 (Avoid
&Lrc<T>in various places) - rust-lang#131346 (Restrict
ignore-mode-*directives) - rust-lang#131353 (Add documentation for
runtest::check_rustdoc_test_optionmethod)
r? @ghost
@rustbot modify labels: rollup
Labels
Area: Translation infrastructure, and migrating existing diagnostics to SessionDiagnostic
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Relevant to the compiler team, which will review and decide on the PR/issue.
Relevant to the rustdoc team, which will review and decide on the PR/issue.