Restrict ignore-mode-* directives by jieyouxu · Pull Request #131346 · rust-lang/rust (original) (raw)
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation5 Commits1 Checks6 Files changed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
This is only used by coverage test suites where the same sources get run under different coverage modes. Restrict ignore-mode-<coverage_mode> to only coverage modes.
rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.
Use r? to explicitly pick a reviewer
Area: The testsuite used to check the correctness of rustc
Status: Awaiting review from the assignee but also interested parties.
Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
labels
This comment has been minimized.
Prune invalid Restrict ignore-mode-* directivesignore-mode-* directives
These are only valid for coverage test modes.
Yeah, this seems reasonable. I implemented ignore-mode-* in the fully-general way because it was easier than not doing that, but realistically there's no foreseeable need for it in any of the other test suites.
Thanks!
@bors r+ rollup=always
📌 Commit 64efbe2 has been approved by Zalathar
It is now in the queue for this repository.
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
bors added a commit to rust-lang-ci/rust that referenced this pull request
…iaskrgr
Rollup of 4 pull requests
Successful merges:
- rust-lang#131331 (Revert "warn_old_master_branch" check)
- rust-lang#131344 (Avoid
&Lrc<T>in various places) - rust-lang#131346 (Restrict
ignore-mode-*directives) - rust-lang#131353 (Add documentation for
runtest::check_rustdoc_test_optionmethod)
r? @ghost
@rustbot modify labels: rollup
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request
Rollup merge of rust-lang#131346 - jieyouxu:prune-invalid-directives, r=Zalathar
Restrict ignore-mode-* directives
This is only used by coverage test suites where the same sources get run under different coverage modes. Restrict ignore-mode-<coverage_mode> to only coverage modes.
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request
Simplify the compiletest directives for ignoring coverage-test modes
Follow-up to rust-lang#131346.
Given that these directives are now restricted to ignoring coverage-test modes only, we can drop the clunky ignore-mode-* naming convention, and just call them ignore-coverage-map and ignore-coverage-run.
r? jieyouxu
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request
Rollup merge of rust-lang#131400 - Zalathar:ignore-coverage, r=jieyouxu
Simplify the compiletest directives for ignoring coverage-test modes
Follow-up to rust-lang#131346.
Given that these directives are now restricted to ignoring coverage-test modes only, we can drop the clunky ignore-mode-* naming convention, and just call them ignore-coverage-map and ignore-coverage-run.
r? jieyouxu
flip1995 pushed a commit to flip1995/rust that referenced this pull request
…iaskrgr
Rollup of 4 pull requests
Successful merges:
- rust-lang#131331 (Revert "warn_old_master_branch" check)
- rust-lang#131344 (Avoid
&Lrc<T>in various places) - rust-lang#131346 (Restrict
ignore-mode-*directives) - rust-lang#131353 (Add documentation for
runtest::check_rustdoc_test_optionmethod)
r? @ghost
@rustbot modify labels: rollup
Labels
Area: The testsuite used to check the correctness of rustc
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)