miri: avoid cloning AllocExtra by RalfJung · Pull Request #131593 · rust-lang/rust (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation3 Commits1 Checks6 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

We shouldn't be cloning Miri allocations, so make AllocExtra::clone panic instead, and adjust the one case where we do clone (the leak check) to avoid cloning.

This is in preparation for rust-lang/miri#3966 where I am adding something to AllocExtra that cannot (easily) be cloned.

r? @saethlin

rustbot added S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

T-compiler

Relevant to the compiler team, which will review and decide on the PR/issue.

labels

Oct 12, 2024

The Miri subtree was changed

cc @rust-lang/miri

Some changes occurred to the CTFE / Miri interpreter

cc @rust-lang/miri

📌 Commit bc4366b has been approved by saethlin

It is now in the queue for this repository.

bors added S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

and removed S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

labels

Oct 13, 2024

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request

Oct 13, 2024

miri: avoid cloning AllocExtra

We shouldn't be cloning Miri allocations, so make AllocExtra::clone panic instead, and adjust the one case where we do clone (the leak check) to avoid cloning.

This is in preparation for rust-lang/miri#3966 where I am adding something to AllocExtra that cannot (easily) be cloned.

r? @saethlin

bors added a commit to rust-lang-ci/rust that referenced this pull request

Oct 14, 2024

bors added a commit to rust-lang-ci/rust that referenced this pull request

Oct 14, 2024

…iaskrgr

Rollup of 8 pull requests

Successful merges:

• rust-lang#128967 (std::fs::get_path freebsd update.)
• rust-lang#130629 (core/net: add Ipv[46]Addr::from_octets, Ipv6Addr::from_segments.)
• rust-lang#131274 (library: Const-stabilize MaybeUninit::assume_init_mut)
• rust-lang#131473 (compiler: {TyAnd,}Layout comes home)
• rust-lang#131533 (emscripten: Use the latest emsdk 3.1.68)
• rust-lang#131593 (miri: avoid cloning AllocExtra)
• rust-lang#131616 (merge const_ipv4 / const_ipv6 feature gate into 'ip' feature gate)
• rust-lang#131660 (Also use outermost const-anon for impl items in non_local_defs lint)

r? @ghost @rustbot modify labels: rollup

bors added a commit to rust-lang-ci/rust that referenced this pull request

Oct 14, 2024

…iaskrgr

Rollup of 8 pull requests

Successful merges:

• rust-lang#128967 (std::fs::get_path freebsd update.)
• rust-lang#130629 (core/net: add Ipv[46]Addr::from_octets, Ipv6Addr::from_segments.)
• rust-lang#131274 (library: Const-stabilize MaybeUninit::assume_init_mut)
• rust-lang#131473 (compiler: {TyAnd,}Layout comes home)
• rust-lang#131533 (emscripten: Use the latest emsdk 3.1.68)
• rust-lang#131593 (miri: avoid cloning AllocExtra)
• rust-lang#131616 (merge const_ipv4 / const_ipv6 feature gate into 'ip' feature gate)
• rust-lang#131660 (Also use outermost const-anon for impl items in non_local_defs lint)

r? @ghost @rustbot modify labels: rollup

bors added a commit to rust-lang-ci/rust that referenced this pull request

Oct 14, 2024

…iaskrgr

Rollup of 8 pull requests

Successful merges:

• rust-lang#128967 (std::fs::get_path freebsd update.)
• rust-lang#130629 (core/net: add Ipv[46]Addr::from_octets, Ipv6Addr::from_segments.)
• rust-lang#131274 (library: Const-stabilize MaybeUninit::assume_init_mut)
• rust-lang#131473 (compiler: {TyAnd,}Layout comes home)
• rust-lang#131533 (emscripten: Use the latest emsdk 3.1.68)
• rust-lang#131593 (miri: avoid cloning AllocExtra)
• rust-lang#131616 (merge const_ipv4 / const_ipv6 feature gate into 'ip' feature gate)
• rust-lang#131660 (Also use outermost const-anon for impl items in non_local_defs lint)

r? @ghost @rustbot modify labels: rollup

rust-timer added a commit to rust-lang-ci/rust that referenced this pull request

Oct 14, 2024

Rollup merge of rust-lang#131593 - RalfJung:alloc-no-clone, r=saethlin

miri: avoid cloning AllocExtra

We shouldn't be cloning Miri allocations, so make AllocExtra::clone panic instead, and adjust the one case where we do clone (the leak check) to avoid cloning.

This is in preparation for rust-lang/miri#3966 where I am adding something to AllocExtra that cannot (easily) be cloned.

r? @saethlin

bors added a commit to rust-lang/miri that referenced this pull request

Oct 14, 2024

Do not store synchronization primitive IDs in adressable memory

We shouldn't store this in a place where the program can mess with it.

Fixes #1649

Blocked by rust-lang/rust#131593

RalfJung pushed a commit to RalfJung/rust that referenced this pull request

Oct 15, 2024

Do not store synchronization primitive IDs in adressable memory

We shouldn't store this in a place where the program can mess with it.

Fixes rust-lang/miri#1649

Blocked by rust-lang#131593

Labels

S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

T-compiler

Relevant to the compiler team, which will review and decide on the PR/issue.