Also use outermost const-anon for impl items in non_local_defs lint by Urgau · Pull Request #131660 · rust-lang/rust (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation5 Commits1 Checks6 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

Urgau

This PR update the logic for the impl paths (items) in the non_local_definitions lint to also consider const-anon in case the impl definition is wrapped inside const-anon it-self wrapped into a const-anon where the items are.

r? @jieyouxu (since you interacted on the issue)
Fixes (after beta-backport) #131643

@Urgau

@rustbot rustbot added S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

T-compiler

Relevant to the compiler team, which will review and decide on the PR/issue.

labels

Oct 13, 2024

jieyouxu

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This LGTM, though I almost feel like we are playing whack-a-mole. Oh well.

@jieyouxu

ferrisCatRPlusRollup-200px

@bors

📌 Commit b5e91a0 has been approved by jieyouxu

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

and removed S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

labels

Oct 14, 2024

@jieyouxu

Nominating for beta backport to fix non_local_definitions lint that should not have fired on cases like #131643

const _: () = { const _: () = { impl Callable for Dummy {} }; pub trait Callable {} struct Dummy; };

@rustbot label +beta-nominated

bors added a commit to rust-lang-ci/rust that referenced this pull request

Oct 14, 2024

@bors

…iaskrgr

Rollup of 8 pull requests

Successful merges:

r? @ghost @rustbot modify labels: rollup

bors added a commit to rust-lang-ci/rust that referenced this pull request

Oct 14, 2024

@bors

…iaskrgr

Rollup of 8 pull requests

Successful merges:

r? @ghost @rustbot modify labels: rollup

bors added a commit to rust-lang-ci/rust that referenced this pull request

Oct 14, 2024

@bors

…iaskrgr

Rollup of 8 pull requests

Successful merges:

r? @ghost @rustbot modify labels: rollup

rust-timer added a commit to rust-lang-ci/rust that referenced this pull request

Oct 14, 2024

@rust-timer

Rollup merge of rust-lang#131660 - Urgau:non_local_def-131643, r=jieyouxu

Also use outermost const-anon for impl items in non_local_defs lint

This PR update the logic for the impl paths (items) in the non_local_definitions lint to also consider const-anon in case the impl definition is wrapped inside const-anon it-self wrapped into a const-anon where the items are.

r? @jieyouxu (since you interacted on the issue) Fixes (after beta-backport) rust-lang#131643

@apiraino

Beta backport accepted as per compiler team on Zulip. A backport PR will be authored by the release team at the end of the current development cycle.

@rustbot label +beta-accepted

bors added a commit to rust-lang-ci/rust that referenced this pull request

Oct 18, 2024

@bors

[beta] stage0 bump and backports

r? ghost

Labels

beta-accepted

Accepted for backporting to the compiler in the beta channel.

L-non_local_definitions

Lint: non_local_definitions

S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

T-compiler

Relevant to the compiler team, which will review and decide on the PR/issue.