Update lint message for ABI not supported by tdittr · Pull Request #131675 · rust-lang/rust (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation7 Commits1 Checks6 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

Tracking issue: #130260

As requested in #128784 (review) I updated the error message.

I could also change it to be the same message as if it was a hard error on a normal function:

"{abi} is not a supported ABI for the current target"

Or would that get confusing when people try to google the error message?

r? compiler-errors

rustbot added S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

T-compiler

Relevant to the compiler team, which will review and decide on the PR/issue.

labels

Oct 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me, i can approve once it's re-blessed and ci is green

remove the backticks, that is :D

📌 Commit b6b6c12 has been approved by compiler-errors

It is now in the queue for this repository.

bors added S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

and removed S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

labels

Oct 14, 2024

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request

Oct 14, 2024

…age, r=compiler-errors

Update lint message for ABI not supported

Tracking issue: rust-lang#130260

As requested in rust-lang#128784 (review) I updated the error message.

I could also change it to be the same message as if it was a hard error on a normal function:

"{abi} is not a supported ABI for the current target"

Or would that get confusing when people try to google the error message?

r? compiler-errors

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request

Oct 14, 2024

…age, r=compiler-errors

Update lint message for ABI not supported

Tracking issue: rust-lang#130260

As requested in rust-lang#128784 (review) I updated the error message.

I could also change it to be the same message as if it was a hard error on a normal function:

"{abi} is not a supported ABI for the current target"

Or would that get confusing when people try to google the error message?

r? compiler-errors

bors added a commit to rust-lang-ci/rust that referenced this pull request

Oct 15, 2024

…iaskrgr

Rollup of 9 pull requests

Successful merges:

• rust-lang#122670 (Fix bug where option_env! would return None when env var is present but not valid Unicode)
• rust-lang#130568 (Make some float methods unstable const fn)
• rust-lang#131137 (Add 1.82 release notes)
• rust-lang#131328 (Remove unnecessary sorts in rustc_hir_analysis)
• rust-lang#131652 (Move polarity into PolyTraitRef rather than storing it on the side)
• rust-lang#131675 (Update lint message for ABI not supported)
• rust-lang#131681 (Fix up-to-date checking for run-make tests)
• rust-lang#131703 (Resolved python deprecation warning in publish_toolstate.py)
• rust-lang#131706 (Fix two const-hacks)

r? @ghost @rustbot modify labels: rollup

compiler-errors added a commit to compiler-errors/rust that referenced this pull request

Oct 15, 2024

…age, r=compiler-errors

Update lint message for ABI not supported

Tracking issue: rust-lang#130260

As requested in rust-lang#128784 (review) I updated the error message.

I could also change it to be the same message as if it was a hard error on a normal function:

"{abi} is not a supported ABI for the current target"

Or would that get confusing when people try to google the error message?

r? compiler-errors

bors added a commit to rust-lang-ci/rust that referenced this pull request

Oct 15, 2024

…iaskrgr

Rollup of 9 pull requests

Successful merges:

• rust-lang#122670 (Fix bug where option_env! would return None when env var is present but not valid Unicode)
• rust-lang#131095 (Use environment variables instead of command line arguments for merged doctests)
• rust-lang#131339 (Expand set_ptr_value / with_metadata_of docs)
• rust-lang#131652 (Move polarity into PolyTraitRef rather than storing it on the side)
• rust-lang#131675 (Update lint message for ABI not supported)
• rust-lang#131681 (Fix up-to-date checking for run-make tests)
• rust-lang#131702 (Suppress import errors for traits that couldve applied for method lookup error)
• rust-lang#131703 (Resolved python deprecation warning in publish_toolstate.py)
• rust-lang#131710 (Remove 'apostrophes' from rustc_parse_format)

r? @ghost @rustbot modify labels: rollup

bors added a commit to rust-lang-ci/rust that referenced this pull request

Oct 15, 2024

…iaskrgr

Rollup of 9 pull requests

Successful merges:

• rust-lang#122670 (Fix bug where option_env! would return None when env var is present but not valid Unicode)
• rust-lang#131095 (Use environment variables instead of command line arguments for merged doctests)
• rust-lang#131339 (Expand set_ptr_value / with_metadata_of docs)
• rust-lang#131652 (Move polarity into PolyTraitRef rather than storing it on the side)
• rust-lang#131675 (Update lint message for ABI not supported)
• rust-lang#131681 (Fix up-to-date checking for run-make tests)
• rust-lang#131702 (Suppress import errors for traits that couldve applied for method lookup error)
• rust-lang#131703 (Resolved python deprecation warning in publish_toolstate.py)
• rust-lang#131710 (Remove 'apostrophes' from rustc_parse_format)

r? @ghost @rustbot modify labels: rollup

bors added a commit to rust-lang-ci/rust that referenced this pull request

Oct 15, 2024

…iaskrgr

Rollup of 9 pull requests

Successful merges:

• rust-lang#122670 (Fix bug where option_env! would return None when env var is present but not valid Unicode)
• rust-lang#131095 (Use environment variables instead of command line arguments for merged doctests)
• rust-lang#131339 (Expand set_ptr_value / with_metadata_of docs)
• rust-lang#131652 (Move polarity into PolyTraitRef rather than storing it on the side)
• rust-lang#131675 (Update lint message for ABI not supported)
• rust-lang#131681 (Fix up-to-date checking for run-make tests)
• rust-lang#131702 (Suppress import errors for traits that couldve applied for method lookup error)
• rust-lang#131703 (Resolved python deprecation warning in publish_toolstate.py)
• rust-lang#131710 (Remove 'apostrophes' from rustc_parse_format)

r? @ghost @rustbot modify labels: rollup

rust-timer added a commit to rust-lang-ci/rust that referenced this pull request

Oct 15, 2024

Rollup merge of rust-lang#131675 - tdittr:update-unsupported-abi-message, r=compiler-errors

Update lint message for ABI not supported

Tracking issue: rust-lang#130260

As requested in rust-lang#128784 (review) I updated the error message.

I could also change it to be the same message as if it was a hard error on a normal function:

"{abi} is not a supported ABI for the current target"

Or would that get confusing when people try to google the error message?

r? compiler-errors

flip1995 pushed a commit to flip1995/rust that referenced this pull request

Oct 18, 2024

…iaskrgr

Rollup of 9 pull requests

Successful merges:

• rust-lang#122670 (Fix bug where option_env! would return None when env var is present but not valid Unicode)
• rust-lang#131095 (Use environment variables instead of command line arguments for merged doctests)
• rust-lang#131339 (Expand set_ptr_value / with_metadata_of docs)
• rust-lang#131652 (Move polarity into PolyTraitRef rather than storing it on the side)
• rust-lang#131675 (Update lint message for ABI not supported)
• rust-lang#131681 (Fix up-to-date checking for run-make tests)
• rust-lang#131702 (Suppress import errors for traits that couldve applied for method lookup error)
• rust-lang#131703 (Resolved python deprecation warning in publish_toolstate.py)
• rust-lang#131710 (Remove 'apostrophes' from rustc_parse_format)

r? @ghost @rustbot modify labels: rollup

Labels

S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

T-compiler

Relevant to the compiler team, which will review and decide on the PR/issue.