interpret: get_alloc_info: also return mutability by RalfJung · Pull Request #132801 · rust-lang/rust (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation13 Commits2 Checks6 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

This will be needed for rust-lang/miri#3971

This then tuned into a larger refactor where we introduce a new type for the get_alloc_info return data, and we move some code to methods on GlobalAlloc to avoid duplicating it between the validity check and get_alloc_info.

r? @wesleywiser

rustbot has assigned @wesleywiser.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

rustbot added S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

T-compiler

Relevant to the compiler team, which will review and decide on the PR/issue.

labels

Nov 9, 2024

The Miri subtree was changed

cc @rust-lang/miri

Some changes occurred to the CTFE machinery

cc @rust-lang/wg-const-eval

Some changes occurred to the CTFE / Miri interpreter

cc @rust-lang/miri

It may be time to use a struct instead of a tuple 😀

This comment has been minimized.

Some changes occurred to the CTFE / Miri interpreter

cc @rust-lang/miri, @rust-lang/wg-const-eval

This comment has been minimized.

…lication with validity checking

📌 Commit 4a54ec8 has been approved by oli-obk

It is now in the queue for this repository.

bors added S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

and removed S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

labels

Nov 9, 2024

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request

Nov 9, 2024

interpret: get_alloc_info: also return mutability

This will be needed for rust-lang/miri#3971

This then tuned into a larger refactor where we introduce a new type for the get_alloc_info return data, and we move some code to methods on GlobalAlloc to avoid duplicating it between the validity check and get_alloc_info.

bors added a commit to rust-lang-ci/rust that referenced this pull request

Nov 9, 2024

…iaskrgr

Rollup of 4 pull requests

Successful merges:

• rust-lang#131258 (Stabilize s390x inline assembly)
• rust-lang#132577 (Report the unexpected_cfgs lint in external macros)
• rust-lang#132801 (interpret: get_alloc_info: also return mutability)
• rust-lang#132825 (Exclude relnotes-tracking-issue from needs-triage)

r? @ghost @rustbot modify labels: rollup

bors added a commit to rust-lang-ci/rust that referenced this pull request

Nov 10, 2024

…kingjubilee

Rollup of 6 pull requests

Successful merges:

• rust-lang#131258 (Stabilize s390x inline assembly)
• rust-lang#132801 (interpret: get_alloc_info: also return mutability)
• rust-lang#132823 (require const_impl_trait gate for all conditional and trait const calls)
• rust-lang#132824 (Update grammar in wasm-c-abi's compiler flag documentation)
• rust-lang#132825 (Exclude relnotes-tracking-issue from needs-triage)
• rust-lang#132828 (Additional tests to ensure let is rejected during parsing)

r? @ghost @rustbot modify labels: rollup

rust-timer added a commit to rust-lang-ci/rust that referenced this pull request

Nov 10, 2024

Rollup merge of rust-lang#132801 - RalfJung:alloc-mutability, r=oli-obk

interpret: get_alloc_info: also return mutability

This will be needed for rust-lang/miri#3971

This then tuned into a larger refactor where we introduce a new type for the get_alloc_info return data, and we move some code to methods on GlobalAlloc to avoid duplicating it between the validity check and get_alloc_info.

mati865 pushed a commit to mati865/rust that referenced this pull request

Nov 12, 2024

interpret: get_alloc_info: also return mutability

This will be needed for rust-lang/miri#3971

This then tuned into a larger refactor where we introduce a new type for the get_alloc_info return data, and we move some code to methods on GlobalAlloc to avoid duplicating it between the validity check and get_alloc_info.

mati865 pushed a commit to mati865/rust that referenced this pull request

Nov 12, 2024

…kingjubilee

Rollup of 6 pull requests

Successful merges:

• rust-lang#131258 (Stabilize s390x inline assembly)
• rust-lang#132801 (interpret: get_alloc_info: also return mutability)
• rust-lang#132823 (require const_impl_trait gate for all conditional and trait const calls)
• rust-lang#132824 (Update grammar in wasm-c-abi's compiler flag documentation)
• rust-lang#132825 (Exclude relnotes-tracking-issue from needs-triage)
• rust-lang#132828 (Additional tests to ensure let is rejected during parsing)

r? @ghost @rustbot modify labels: rollup

Labels

S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

T-compiler

Relevant to the compiler team, which will review and decide on the PR/issue.