Report the unexpected_cfgs lint in external macros by Urgau · Pull Request #132577 · rust-lang/rust (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation27 Commits4 Checks6 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

This PR marks the unexpected_cfgs lint as being reportable in external macros, as it's probably not the intention of the macro author to leave ineffective cfgs in the users code.

Fixes #132572

try-job: aarch64-gnu-debug

r? @wesleywiser

rustbot has assigned @wesleywiser.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

rustbot added S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

T-compiler

Relevant to the compiler team, which will review and decide on the PR/issue.

labels

Nov 3, 2024

This comment has been minimized.

These commits modify the Cargo.lock file. Unintentional changes to Cargo.lock can be introduced when switching branches and rebasing PRs.

If this was unintentional then you should revert the changes before this PR is merged.
Otherwise, you can ignore this comment.

This comment has been minimized.

Would this need a crater run?

Urgau mentioned this pull request

Nov 5, 2024

Would this need a crater run?

Evaluating the new unexpected_cfgs warnings coming from external macros on a crater run is doable (although not easy), but I'm not sure what it will give us, a part (obviously) from the number of impacted crates, which I'm not sure how to interpret. A big (or even small) number of warnings would IMO only reinforce the usefulness of enabling the reporting in external macros (not that it needs it to be clear).

Is there something particular you are looking for?

No I'm more just curious, because maybe a few crates are affected.

📌 Commit 37e67ac has been approved by petrochenkov

It is now in the queue for this repository.

bors added S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

and removed S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

labels

Nov 9, 2024

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request

Nov 9, 2024

…o, r=petrochenkov

Report the unexpected_cfgs lint in external macros

This PR marks the unexpected_cfgs lint as being reportable in external macros, as it's probably not the intention of the macro author to leave ineffective cfgs in the users code.

Fixes rust-lang#132572

bors added a commit to rust-lang-ci/rust that referenced this pull request

Nov 9, 2024

…iaskrgr

Rollup of 4 pull requests

Successful merges:

• rust-lang#131258 (Stabilize s390x inline assembly)
• rust-lang#132577 (Report the unexpected_cfgs lint in external macros)
• rust-lang#132801 (interpret: get_alloc_info: also return mutability)
• rust-lang#132825 (Exclude relnotes-tracking-issue from needs-triage)

r? @ghost @rustbot modify labels: rollup

bors added S-waiting-on-author

Status: This is awaiting some action (such as code changes or more information) from the author.

and removed S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

labels

Nov 10, 2024

bors added a commit to rust-lang-ci/rust that referenced this pull request

Nov 10, 2024

… r=

Report the unexpected_cfgs lint in external macros

This PR marks the unexpected_cfgs lint as being reportable in external macros, as it's probably not the intention of the macro author to leave ineffective cfgs in the users code.

Fixes rust-lang#132572

try-job: aarch64-gnu-debug

This comment has been minimized.

rust-timer added a commit to rust-lang-ci/rust that referenced this pull request

Nov 19, 2024

Rollup merge of rust-lang#132577 - Urgau:check-cfg-report-extern-macro, r=petrochenkov

Report the unexpected_cfgs lint in external macros

This PR marks the unexpected_cfgs lint as being reportable in external macros, as it's probably not the intention of the macro author to leave ineffective cfgs in the users code.

Fixes rust-lang#132572

try-job: aarch64-gnu-debug

Urgau mentioned this pull request

Nov 19, 2024

smoelius added a commit to rust-fuzz/afl.rs that referenced this pull request

Nov 20, 2024

This recent change is causing CI to fail: rust-lang/rust#132577

The failure is caused by the used_linker feature in code produced by the ctor::ctor attribute macro.

This was referenced

Nov 20, 2024

github-merge-queue bot pushed a commit to rust-fuzz/afl.rs that referenced this pull request

Nov 20, 2024

This recent change is causing CI to fail: rust-lang/rust#132577

The failure is caused by the used_linker feature in code produced by the ctor::ctor attribute macro.

tnull added a commit to tnull/rust-lightning that referenced this pull request

Nov 26, 2024

Rustc 1.84 (nightly) introduced that the unexpected_cfgs lint will now be reported for external macros (see rust-lang/rust#132577), leading to some of our builds failing due to our level = "forbid" config of unexpected cfg flags.

Here, we add the logging features to the expected features of the workspace to mitigiate this issue and fix builds.

tnull mentioned this pull request

Nov 26, 2024

This was referenced

Nov 29, 2024

sirno mentioned this pull request

Dec 2, 2024

joshlf added a commit to google/zerocopy that referenced this pull request

Dec 3, 2024

As of nightly-2024-11-20 - specifically [1] - this triggers an unexpected_cfgs lint even when emitted in derive-generated code.

[1] rust-lang/rust#132577

Fixes #2117

gherrit-pr-id: I9d536f0ea08475afe0b65411b225aa55f4db449a

github-merge-queue bot pushed a commit to google/zerocopy that referenced this pull request

Dec 3, 2024

As of nightly-2024-11-20 - specifically [1] - this triggers an unexpected_cfgs lint even when emitted in derive-generated code.

[1] rust-lang/rust#132577

Fixes #2117

gherrit-pr-id: I9d536f0ea08475afe0b65411b225aa55f4db449a

joshlf added a commit to google/zerocopy that referenced this pull request

Dec 3, 2024

As of nightly-2024-11-20 - specifically [1] - this triggers an unexpected_cfgs lint even when emitted in derive-generated code.

[1] rust-lang/rust#132577

Fixes #2117

gherrit-pr-id: I9d536f0ea08475afe0b65411b225aa55f4db449a

github-merge-queue bot pushed a commit to google/zerocopy that referenced this pull request

Dec 3, 2024

As of nightly-2024-11-20 - specifically [1] - this triggers an unexpected_cfgs lint even when emitted in derive-generated code.

[1] rust-lang/rust#132577

Fixes #2117

gherrit-pr-id: I9d536f0ea08475afe0b65411b225aa55f4db449a

richvdh added a commit to matrix-org/matrix-rust-sdk-crypto-wasm that referenced this pull request

Dec 10, 2024

Since rust-lang/rust#132577 (currently in rust nightly), we get hundreds of lint warnings:

warning: unexpected `cfg` condition name: `wasm_bindgen_unstable_test_coverage`
  --> src/rust/lib.rs:83:1
   |
83 | #[wasm_bindgen(start)]

The correct solution is to upgrade wasm-bindgen, but legend has it that is difficult. For now, let's silence the lint.

richvdh added a commit to matrix-org/matrix-rust-sdk-crypto-wasm that referenced this pull request

Dec 11, 2024

Since rust-lang/rust#132577 (currently in rust nightly), we get hundreds of lint warnings:

warning: unexpected `cfg` condition name: `wasm_bindgen_unstable_test_coverage`
  --> src/rust/lib.rs:83:1
   |
83 | #[wasm_bindgen(start)]

The correct solution is to upgrade wasm-bindgen, but legend has it that is difficult. For now, let's silence the lint.

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request

Dec 14, 2024

…ouxu

Add external macros specific diagnostics for check-cfg

This PR adds specific check-cfg diagnostics for unexpected cfg in external macros.

As well as hiding the some of the Cargo specific help/suggestions as they distraction for external macros and are generally not the right solution.

Follow-up to rust-lang#132577

@rustbot label +L-unexpected_cfgs r? compiler

rust-timer added a commit to rust-lang-ci/rust that referenced this pull request

Dec 14, 2024

Rollup merge of rust-lang#133221 - Urgau:check-cfg-macro-diag, r=jieyouxu

Add external macros specific diagnostics for check-cfg

This PR adds specific check-cfg diagnostics for unexpected cfg in external macros.

As well as hiding the some of the Cargo specific help/suggestions as they distraction for external macros and are generally not the right solution.

Follow-up to rust-lang#132577

@rustbot label +L-unexpected_cfgs r? compiler

tmeijn pushed a commit to tmeijn/dotfiles that referenced this pull request

Jan 22, 2025

This MR contains the following updates:

MR created with the help of el-capitano/tools/renovate-bot.

Proposed changes to behavior should be submitted there as MRs.

Release Notes

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻ Rebasing: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this MR and you won't be reminded about this update again.

• If you want to rebase/retry this MR, check this box

This MR has been generated by Renovate Bot.

wip-sync pushed a commit to NetBSD/pkgsrc-wip that referenced this pull request

Feb 2, 2025

Pkgsrc changes:

• Adapt patches, one of the patched files were restructured upstream.
• Checksum changes.

Upstream changes:

Version 1.84.1 (2025-01-30)

• [Fix ICE 132920 in duplicate-crate diagnostics.] (rust-lang/rust#133304)
• [Fix errors for overlapping impls in incremental rebuilds.] (rust-lang/rust#133828)
• [Fix slow compilation related to the next-generation trait solver.] (rust-lang/rust#135618)
• [Fix debuginfo when LLVM's location discriminator value limit is exceeded.] (rust-lang/rust#135643)
• Fixes for building Rust from source:
  • [Only try to distribute llvm-objcopy if llvm tools are enabled.] (rust-lang/rust#134240)
  • [Add Profile Override for Non-Git Sources.] (rust-lang/rust#135433)
  • [Resolve symlinks of LLVM tool binaries before copying them.] (rust-lang/rust#135585)
  • [Make it possible to use ci-rustc on tarball sources.] (rust-lang/rust#135722)

Version 1.84.0 (2025-01-09)

Language

• [Allow #[deny] inside #[forbid] as a no-op] (rust-lang/rust#121560)
• [Show a warning when -Ctarget-feature is used to toggle features that can lead to unsoundness due to ABI mismatches] (rust-lang/rust#129884)
• [Use the next-generation trait solver in coherence] (rust-lang/rust#130654)
• [Allow coercions to drop the principal of trait objects] (rust-lang/rust#131857)
• [Support / as the path separator for include!() in all cases on Windows] (rust-lang/rust#125205)
• [Taking a raw ref (raw (const|mut)) of a deref of a pointer (*ptr) is now safe] (rust-lang/rust#129248)
• [Stabilize s390x inline assembly] (rust-lang/rust#131258)
• [Stabilize Arm64EC inline assembly] (rust-lang/rust#131781)
• [Lint against creating pointers to immediately dropped temporaries] (rust-lang/rust#128985)
• [Execute drop glue when unwinding in an extern "C" function] (rust-lang/rust#129582)

Compiler

• [Add --print host-tuple flag to print the host target tuple and affirm the "target tuple" terminology over "target triple"] (rust-lang/rust#125579)
• [Declaring functions with a calling convention not supported on the current target now triggers a hard error] (rust-lang/rust#129935)
• [Set up indirect access to external data for loongarch64-unknown-linux-{musl,ohos}] (rust-lang/rust#131583)
• [Enable XRay instrumentation for LoongArch Linux targets] (rust-lang/rust#131818)
• [Extend the unexpected_cfgs lint to also warn in external macros] (rust-lang/rust#132577)
• [Stabilize WebAssembly multivalue, reference-types, and tail-call target features] (rust-lang/rust#131080)
• [Added Tier 2 support for the wasm32v1-none target] (rust-lang/rust#131487)

Libraries

• [Implement From<&mut {slice}> for Box/Rc/Arc<{slice}>] (rust-lang/rust#129329)
• [Move <float>::copysign, <float>::abs, <float>::signum to core] (rust-lang/rust#131304)
• [Add LowerExp and UpperExp implementations to NonZero] (rust-lang/rust#131377)
• [Implement FromStr for CString and TryFrom<CString> for String] (rust-lang/rust#130608)
• [std::os::darwin has been made public] (rust-lang/rust#130635)

Stabilized APIs

• [Ipv6Addr::is_unique_local] (https://doc.rust-lang.org/stable/core/net/struct.Ipv6Addr.html#method.is_unique_local)
• [Ipv6Addr::is_unicast_link_local] (https://doc.rust-lang.org/stable/core/net/struct.Ipv6Addr.html#method.is_unicast_link_local)
• [core::ptr::with_exposed_provenance] (https://doc.rust-lang.org/stable/core/ptr/fn.with_exposed_provenance.html)
• [core::ptr::with_exposed_provenance_mut] (https://doc.rust-lang.org/stable/core/ptr/fn.with_exposed_provenance_mut.html)
• [<ptr>::addr] (https://doc.rust-lang.org/stable/core/primitive.pointer.html#method.addr)
• [<ptr>::expose_provenance] (https://doc.rust-lang.org/stable/core/primitive.pointer.html#method.expose_provenance)
• [<ptr>::with_addr] (https://doc.rust-lang.org/stable/core/primitive.pointer.html#method.with_addr)
• [<ptr>::map_addr] (https://doc.rust-lang.org/stable/core/primitive.pointer.html#method.map_addr)
• [<int>::isqrt] (https://doc.rust-lang.org/stable/core/primitive.i32.html#method.isqrt)
• [<int>::checked_isqrt] (https://doc.rust-lang.org/stable/core/primitive.i32.html#method.checked_isqrt)
• [<uint>::isqrt] (https://doc.rust-lang.org/stable/core/primitive.u32.html#method.isqrt)
• [NonZero::isqrt] (https://doc.rust-lang.org/stable/core/num/struct.NonZero.html#impl-NonZero%3Cu128%3E/method.isqrt)
• [core::ptr::without_provenance] (https://doc.rust-lang.org/stable/core/ptr/fn.without_provenance.html)
• [core::ptr::without_provenance_mut] (https://doc.rust-lang.org/stable/core/ptr/fn.without_provenance_mut.html)
• [core::ptr::dangling] (https://doc.rust-lang.org/stable/core/ptr/fn.dangling.html)
• [core::ptr::dangling_mut] (https://doc.rust-lang.org/stable/core/ptr/fn.dangling_mut.html)

These APIs are now stable in const contexts

• [AtomicBool::from_ptr] (https://doc.rust-lang.org/stable/core/sync/atomic/struct.AtomicBool.html#method.from_ptr)
• [AtomicPtr::from_ptr] (https://doc.rust-lang.org/stable/core/sync/atomic/struct.AtomicPtr.html#method.from_ptr)
• [AtomicU8::from_ptr] (https://doc.rust-lang.org/stable/core/sync/atomic/struct.AtomicU8.html#method.from_ptr)
• [AtomicU16::from_ptr] (https://doc.rust-lang.org/stable/core/sync/atomic/struct.AtomicU16.html#method.from_ptr)
• [AtomicU32::from_ptr] (https://doc.rust-lang.org/stable/core/sync/atomic/struct.AtomicU32.html#method.from_ptr)
• [AtomicU64::from_ptr] (https://doc.rust-lang.org/stable/core/sync/atomic/struct.AtomicU64.html#method.from_ptr)
• [AtomicUsize::from_ptr] (https://doc.rust-lang.org/stable/core/sync/atomic/struct.AtomicUsize.html#method.from_ptr)
• [AtomicI8::from_ptr] (https://doc.rust-lang.org/stable/core/sync/atomic/struct.AtomicI8.html#method.from_ptr)
• [AtomicI16::from_ptr] (https://doc.rust-lang.org/stable/core/sync/atomic/struct.AtomicI16.html#method.from_ptr)
• [AtomicI32::from_ptr] (https://doc.rust-lang.org/stable/core/sync/atomic/struct.AtomicI32.html#method.from_ptr)
• [AtomicI64::from_ptr] (https://doc.rust-lang.org/stable/core/sync/atomic/struct.AtomicI64.html#method.from_ptr)
• [AtomicIsize::from_ptr] (https://doc.rust-lang.org/stable/core/sync/atomic/struct.AtomicIsize.html#method.from_ptr)
• [<ptr>::is_null] (https://doc.rust-lang.org/stable/core/primitive.pointer.html#method.is_null-1)
• [<ptr>::as_ref] (https://doc.rust-lang.org/stable/core/primitive.pointer.html#method.as_ref-1)
• [<ptr>::as_mut] (https://doc.rust-lang.org/stable/core/primitive.pointer.html#method.as_mut)
• [Pin::new] (https://doc.rust-lang.org/stable/core/pin/struct.Pin.html#method.new)
• [Pin::new_unchecked] (https://doc.rust-lang.org/stable/core/pin/struct.Pin.html#method.new_unchecked)
• [Pin::get_ref] (https://doc.rust-lang.org/stable/core/pin/struct.Pin.html#method.get_ref)
• [Pin::into_ref] (https://doc.rust-lang.org/stable/core/pin/struct.Pin.html#method.into_ref)
• [Pin::get_mut] (https://doc.rust-lang.org/stable/core/pin/struct.Pin.html#method.get_mut)
• [Pin::get_unchecked_mut] (https://doc.rust-lang.org/stable/core/pin/struct.Pin.html#method.get_unchecked_mut)
• [Pin::static_ref] (https://doc.rust-lang.org/stable/core/pin/struct.Pin.html#method.static_ref)
• [Pin::static_mut] (https://doc.rust-lang.org/stable/core/pin/struct.Pin.html#method.static_mut)

Cargo

• [Stabilize MSRV-aware resolver config] (rust-lang/cargo#14639)
• [Stabilize resolver v3] (rust-lang/cargo#14754)

Rustdoc

• [rustdoc-search: improve type-driven search] (rust-lang/rust#127589)

Compatibility Notes

• [Enable by default the LSX target feature for LoongArch Linux targets] (rust-lang/rust#132140)
• The unstable -Zprofile flag ("gcov-style" coverage instrumentation) has been removed. This does not affect the stable flags for coverage instrumentation (-Cinstrument-coverage) and profile-guided optimization (-Cprofile-generate, -Cprofile-use), which are unrelated and remain available.
• Support for the target named wasm32-wasi has been removed as the target is now named wasm32-wasip1. This completes the [transition] (rust-lang/compiler-team#607) plan for this target following [the introduction of wasm32-wasip1] (rust-lang/rust#120468) in Rust 1.78. Compiler warnings on [use of wasm32-wasi] (rust-lang/rust#126662) introduced in Rust 1.81 are now gone as well as the target is removed.
• [The syntax &pin (mut|const) T is now parsed as a type which in theory could affect macro expansion results in some edge cases] (rust-lang/rust#130635 (comment))
• [Legacy syntax for calling std::arch functions is no longer permitted to declare items or bodies (such as closures, inline consts, or async blocks).] (rust-lang/rust#130443 (comment))
• The wasm32-unknown-emscripten target's binary release of the standard library is now [built with the latest emsdk 3.1.68] (rust-lang/rust#131533), which fixes an ABI-incompatibility with Emscripten >= 3.1.42. If you are locally using a version of emsdk with an incompatible ABI (e.g. before 3.1.42 or a future one), you should build your code with -Zbuild-std to ensure that std uses the correct ABI.
• [Declaring functions with a calling convention not supported on the current target now triggers a hard error] (rust-lang/rust#129935)
• [The next-generation trait solver is now enabled for coherence, fixing multiple soundness issues] (rust-lang/rust#130654)

Labels

L-unexpected_cfgs

Lint: unexpected_cfgs

relnotes

Marks issues that should be documented in the release notes of the next release.

S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

T-compiler

Relevant to the compiler team, which will review and decide on the PR/issue.