Stabilize the 2024 edition by ehuss · Pull Request #133349 · rust-lang/rust (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation9 Commits1 Checks6 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

This stabilizes the 2024 edition for Rust 1.85, scheduled to be released on February 20, 2025. 🎉

cc tracking issue: #117258

There is a fair amount of follow-up work after this that I am working on (various docs, cargo, rustfmt, etc.), and this is will unblock those other changes.

drguildo, 0x7CFE, ifsheldon, CatCode79, mohamed-said, chenlcacentury, bondrewd, Luracasmus, zlfn, lawff, and 25 more reacted with thumbs up emoji JSorngard, marc2332, younghyun1, WilliamTakeshi, Rajil1213, nitkach, bstrie, Luracasmus, tuguzT, Xuanwo, and 117 more reacted with hooray emoji joshtriplett, Kobzol, Scripter17, adriandelgado, chriskrycho, LukeMathWalker, sunshowers, estebank, zslayton, jieyouxu, and 70 more reacted with heart emoji cynecx, Noratrieb, joshtriplett, Kobzol, compiler-errors, Scripter17, clubby789, adriandelgado, tgross35, MarcusDunn, and 108 more reacted with rocket emoji Rudxain and sozelfist reacted with eyes emoji

r? @chenyukang

rustbot has assigned @chenyukang.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

rustbot added PG-exploit-mitigations

Project group: Exploit mitigations

S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

T-compiler

Relevant to the compiler team, which will review and decide on the PR/issue.

T-rustdoc

Relevant to the rustdoc team, which will review and decide on the PR/issue.

labels

Nov 22, 2024

Some changes occurred in tests/ui/sanitizer

cc @rust-lang/project-exploit-mitigations, @rcvalle

This comment has been minimized.

This PR modifies tests/run-make/. If this PR is trying to port a Makefile
run-make test to use rmake.rs, please update the
run-make port tracking issue
so we can track our progress. You can either modify the tracking issue
directly, or you can comment on the tracking issue and link this PR.

cc @jieyouxu

On the edition team, we couldn't be more pleased with how things have worked out. Huge thanks to all item owners, reviewers, and to @ehuss for his invaluable work.

It's time to put the edition on the train for release.

@bors r=traviscross,compiler-errors p=10

📌 Commit 31c9222 has been approved by traviscross,compiler-errors

It is now in the queue for this repository.

bors added S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

and removed S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

labels

Nov 22, 2024

☀️ Test successful - checks-actions
Approved by: traviscross,compiler-errors
Pushing f5be3ca to master...

This was referenced

Nov 23, 2024

Finished benchmarking commit (f5be3ca): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (secondary 3.2%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 796.567s -> 794.975s (-0.20%)
Artifact size: 336.13 MiB -> 336.16 MiB (0.01%)

ehuss mentioned this pull request

Nov 28, 2024

jhpratt added a commit to jhpratt/rust that referenced this pull request

Nov 28, 2024

…r=compiler-errors

Update more 2024 tests to remove -Zunstable-options

This removes -Zunsable-options from more tests that I missed in rust-lang#133349.

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request

Nov 29, 2024

…r=compiler-errors

Update more 2024 tests to remove -Zunstable-options

This removes -Zunsable-options from more tests that I missed in rust-lang#133349.

rust-timer added a commit to rust-lang-ci/rust that referenced this pull request

Nov 29, 2024

Rollup merge of rust-lang#133584 - ehuss:more-2024-unstable-options, r=compiler-errors

Update more 2024 tests to remove -Zunstable-options

This removes -Zunsable-options from more tests that I missed in rust-lang#133349.

This was referenced

Dec 2, 2024

ehuss mentioned this pull request

Dec 11, 2024

GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request

Dec 11, 2024

…anieu,traviscross,tgross35

Stabilize the Rust 2024 prelude

This stabilizes the core::prelude::rust_2024 and std::prelude::rust_2024 modules. I missed these in the rust-lang#133349 stabilization.

jieyouxu added a commit to jieyouxu/rust that referenced this pull request

Dec 12, 2024

…anieu,traviscross,tgross35

Stabilize the Rust 2024 prelude

This stabilizes the core::prelude::rust_2024 and std::prelude::rust_2024 modules. I missed these in the rust-lang#133349 stabilization.

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request

Dec 12, 2024

…anieu,traviscross,tgross35

Stabilize the Rust 2024 prelude

This stabilizes the core::prelude::rust_2024 and std::prelude::rust_2024 modules. I missed these in the rust-lang#133349 stabilization.

rust-timer added a commit to rust-lang-ci/rust that referenced this pull request

Dec 12, 2024

Rollup merge of rust-lang#134178 - ehuss:stabilize-2024-prelude, r=amanieu,traviscross,tgross35

Stabilize the Rust 2024 prelude

This stabilizes the core::prelude::rust_2024 and std::prelude::rust_2024 modules. I missed these in the rust-lang#133349 stabilization.

mseri mentioned this pull request

Feb 5, 2025

daniel-noland added a commit to githedgehog/dataplane that referenced this pull request

Feb 21, 2025

As of today (2025-02-20) the 2024 edition of rust was stabilized.

This commit preps for that change by running cargo update on rust 1.84.1 to get us as close as possible to the 1.85.0 version before we make the jump.

Signed-off-by: Daniel Noland daniel@githedgehog.com

daniel-noland added a commit to githedgehog/dataplane that referenced this pull request

Feb 21, 2025

As of today (2025-02-20) the 2024 edition of rust was stabilized.

This commit preps for that change by running cargo update on rust 1.84.1 to get us as close as possible to the 1.85.0 version before we make the jump.

Signed-off-by: Daniel Noland daniel@githedgehog.com

github-merge-queue bot pushed a commit to githedgehog/dataplane that referenced this pull request

Feb 21, 2025

As of today (2025-02-20) the 2024 edition of rust was stabilized.

This commit preps for that change by running cargo update on rust 1.84.1 to get us as close as possible to the 1.85.0 version before we make the jump.

Signed-off-by: Daniel Noland daniel@githedgehog.com

wip-sync pushed a commit to NetBSD/pkgsrc-wip that referenced this pull request

Feb 23, 2025

Pkgsrc changes relative to rust184:

• patch reorganization to deal with new version of upstream vendored crates, checksum updates.

Version 1.85.0 (2025-02-20)

Language

• [The 2024 Edition is now stable.] (rust-lang/rust#133349) See [the edition guide] (https://doc.rust-lang.org/nightly/edition-guide/rust-2024/index.html) for more details.
• [Stabilize async closures] (rust-lang/rust#132706) See [RFC 3668] (https://rust-lang.github.io/rfcs/3668-async-closures.html) for more details.
• [Stabilize #[diagnostic::do_not_recommend]] (rust-lang/rust#132056)
• [Add unpredictable_function_pointer_comparisons lint to warn against function pointer comparisons] (rust-lang/rust#118833)
• [Lint on combining #[no_mangle] and #[export_name] attributes.] (rust-lang/rust#131558)

Compiler

• [The unstable flag -Zpolymorphize has been removed] (rust-lang/rust#133883), see rust-lang/compiler-team#810 for some background.

Platform Support

• [Promote powerpc64le-unknown-linux-musl to tier 2 with host tools] (rust-lang/rust#133801)

Refer to Rust's [platform support page][platform-support-doc] for more information on Rust's tiered platform support.

Libraries

• [Panics in the standard library now have a leading library/ in their path] (rust-lang/rust#132390)

• [std::env::home_dir() on Windows now ignores the non-standard $HOME environment variable] (rust-lang/rust#132515)

  It will be un-deprecated in a subsequent release.

• [Add AsyncFn* to the prelude in all editions.] (rust-lang/rust#132611)

Stabilized APIs

• [BuildHasherDefault::new] (https://doc.rust-lang.org/stable/std/hash/struct.BuildHasherDefault.html#method.new)
• [ptr::fn_addr_eq] (https://doc.rust-lang.org/std/ptr/fn.fn_addr_eq.html)
• [io::ErrorKind::QuotaExceeded] (https://doc.rust-lang.org/stable/std/io/enum.ErrorKind.html#variant.QuotaExceeded)
• [io::ErrorKind::CrossesDevices] (https://doc.rust-lang.org/stable/std/io/enum.ErrorKind.html#variant.CrossesDevices)
• [{float}::midpoint] (https://doc.rust-lang.org/core/primitive.f32.html#method.midpoint)
• [Unsigned {integer}::midpoint] (https://doc.rust-lang.org/std/primitive.u64.html#method.midpoint)
• [NonZeroU*::midpoint] (https://doc.rust-lang.org/std/num/type.NonZeroU32.html#method.midpoint)
• [impl std::iter::Extend for tuples with arity 1 through 12] (https://doc.rust-lang.org/stable/std/iter/trait.Extend.html#impl-Extend%3C(A,)%3E-for-(EA,))
• [FromIterator<(A, ...)> for tuples with arity 1 through 12] (https://doc.rust-lang.org/stable/std/iter/trait.FromIterator.html#impl-FromIterator%3C(EA,)%3E-for-(A,))
• [std::task::Waker::noop] (https://doc.rust-lang.org/stable/std/task/struct.Waker.html#method.noop)

These APIs are now stable in const contexts:

• [mem::size_of_val] (https://doc.rust-lang.org/stable/std/mem/fn.size_of_val.html)
• [mem::align_of_val] (https://doc.rust-lang.org/stable/std/mem/fn.align_of_val.html)
• [Layout::for_value] (https://doc.rust-lang.org/stable/std/alloc/struct.Layout.html#method.for_value)
• [Layout::align_to] (https://doc.rust-lang.org/stable/std/alloc/struct.Layout.html#method.align_to)
• [Layout::pad_to_align] (https://doc.rust-lang.org/stable/std/alloc/struct.Layout.html#method.pad_to_align)
• [Layout::extend] (https://doc.rust-lang.org/stable/std/alloc/struct.Layout.html#method.extend)
• [Layout::array] (https://doc.rust-lang.org/stable/std/alloc/struct.Layout.html#method.array)
• [std::mem::swap] (https://doc.rust-lang.org/stable/std/mem/fn.swap.html)
• [std::ptr::swap] (https://doc.rust-lang.org/stable/std/ptr/fn.swap.html)
• [NonNull::new] (https://doc.rust-lang.org/stable/std/ptr/struct.NonNull.html#method.new)
• [HashMap::with_hasher] (https://doc.rust-lang.org/stable/std/collections/struct.HashMap.html#method.with_hasher)
• [HashSet::with_hasher] (https://doc.rust-lang.org/stable/std/collections/struct.HashSet.html#method.with_hasher)
• [BuildHasherDefault::new] (https://doc.rust-lang.org/stable/std/hash/struct.BuildHasherDefault.html#method.new)
• [<float>::recip] (https://doc.rust-lang.org/stable/std/primitive.f32.html#method.recip)
• [<float>::to_degrees] (https://doc.rust-lang.org/stable/std/primitive.f32.html#method.to_degrees)
• [<float>::to_radians] (https://doc.rust-lang.org/stable/std/primitive.f32.html#method.to_radians)
• [<float>::max] (https://doc.rust-lang.org/stable/std/primitive.f32.html#method.max)
• [<float>::min] (https://doc.rust-lang.org/stable/std/primitive.f32.html#method.min)
• [<float>::clamp] (https://doc.rust-lang.org/stable/std/primitive.f32.html#method.clamp)
• [<float>::abs] (https://doc.rust-lang.org/stable/std/primitive.f32.html#method.abs)
• [<float>::signum] (https://doc.rust-lang.org/stable/std/primitive.f32.html#method.signum)
• [<float>::copysign] (https://doc.rust-lang.org/stable/std/primitive.f32.html#method.copysign)
• [MaybeUninit::write] (https://doc.rust-lang.org/stable/std/mem/union.MaybeUninit.html#method.write)

Cargo

• [Add future-incompatibility warning against keywords in cfgs and add raw-idents] (rust-lang/cargo#14671)
• [Stabilize higher precedence trailing flags] (rust-lang/cargo#14900)
• [Pass CARGO_CFG_FEATURE to build scripts] (rust-lang/cargo#14902)

Rustdoc

• [Doc comment on impl blocks shows the first line, even when the impl block is collapsed] (rust-lang/rust#132155)

Compatibility Notes

• [rustc no longer treats the test cfg as a well known check-cfg] (rust-lang/rust#131729), instead it is up to the build systems and users of --check-cfg[^check-cfg] to set it as a well known cfg using --check-cfg=cfg(test).

  This is done to enable build systems like Cargo to set it conditionally, as not all source files are suitable for unit tests.

  [Cargo (for now) unconditionally sets the test cfg as a well known cfg] (rust-lang/cargo#14963). [^check-cfg]: https://doc.rust-lang.org/nightly/rustc/check-cfg.html

• [Disable potentially incorrect type inference if there are trivial and non-trivial where-clauses] (rust-lang/rust#132325)

• std::env::home_dir() has been deprecated for years, because it can give surprising results in some Windows configurations if the HOME environment variable is set (which is not the normal configuration on Windows). We had previously avoided changing its behavior, out of concern for compatibility with code depending on this non-standard configuration. Given how long this function has been deprecated, we're now fixing its behavior as a bugfix. A subsequent release will remove the deprecation for this function.

• [Make core::ffi::c_char signedness more closely match that of the platform-default char] (rust-lang/rust#132975)

  This changed c_char from an i8 to u8 or vice versa on many Tier 2 and 3 targets (mostly Arm and RISC-V embedded targets). The new definition may result in compilation failures but fixes compatibility issues with C.

  The libc crate matches this change as of its 0.2.169 release.

• [When compiling a nested macro_rules macro from an external crate, the content of the inner macro_rules is now built with the edition of the external crate, not the local crate.] (rust-lang/rust#133274)

• [Increase sparcv9-sun-solaris and x86_64-pc-solaris Solaris baseline to 11.4.] (rust-lang/rust#133293)

• [Show abi_unsupported_vector_types lint in future breakage reports] (rust-lang/rust#133374)

• [Error if multiple super-trait instantiations of dyn Trait need associated types to be specified but only one is provided] (rust-lang/rust#133392)

• [Change powerpc64-ibm-aix default codemodel to large] (rust-lang/rust#133811)

Internal Changes

These changes do not affect any public interfaces of Rust, but they represent significant improvements to the performance or internals of rustc and related tools.

• [Build x86_64-unknown-linux-gnu with LTO for C/C++ code (e.g., jemalloc)] (rust-lang/rust#134690)

tmeijn pushed a commit to tmeijn/dotfiles that referenced this pull request

Feb 26, 2025

This MR contains the following updates:

MR created with the help of el-capitano/tools/renovate-bot.

Proposed changes to behavior should be submitted there as MRs.

Release Notes

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻ Rebasing: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this MR and you won't be reminded about this update again.

• If you want to rebase/retry this MR, check this box

This MR has been generated by Renovate Bot.

github-actions bot pushed a commit to tautschnig/verify-rust-std that referenced this pull request

Mar 11, 2025

…anieu,traviscross,tgross35

Stabilize the Rust 2024 prelude

This stabilizes the core::prelude::rust_2024 and std::prelude::rust_2024 modules. I missed these in the rust-lang#133349 stabilization.

ehuss added a commit to ehuss/rust that referenced this pull request

Apr 26, 2025

This updates the lint-docs tool to default to the 2024 edition. The lint docs are supposed to illustrate the code with the latest edition, and I just forgot to update this in rust-lang#133349.

Some docs needed to add the edition attribute since they were assuming a particular edition, but were missing the explicit annotation.

ehuss mentioned this pull request

Apr 26, 2025

tgross35 added a commit to tgross35/rust that referenced this pull request

Apr 27, 2025

…r-errors

Update lint-docs to default to Rust 2024

This updates the lint-docs tool to default to the 2024 edition. The lint docs are supposed to illustrate the code with the latest edition, and I just forgot to update this in rust-lang#133349.

Some docs needed to add the edition attribute since they were assuming a particular edition, but were missing the explicit annotation.

This also includes a commit to simplify the edition handling in lint-docs.

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request

Apr 27, 2025

…r-errors

Update lint-docs to default to Rust 2024

This updates the lint-docs tool to default to the 2024 edition. The lint docs are supposed to illustrate the code with the latest edition, and I just forgot to update this in rust-lang#133349.

Some docs needed to add the edition attribute since they were assuming a particular edition, but were missing the explicit annotation.

This also includes a commit to simplify the edition handling in lint-docs.

rust-timer added a commit to rust-lang-ci/rust that referenced this pull request

Apr 27, 2025

Rollup merge of rust-lang#140348 - ehuss:lint-docs-edition, r=compiler-errors

Update lint-docs to default to Rust 2024

This updates the lint-docs tool to default to the 2024 edition. The lint docs are supposed to illustrate the code with the latest edition, and I just forgot to update this in rust-lang#133349.

Some docs needed to add the edition attribute since they were assuming a particular edition, but were missing the explicit annotation.

This also includes a commit to simplify the edition handling in lint-docs.

Labels

A-edition-2024

Area: The 2024 edition

A-run-make

Area: port run-make Makefiles to rmake.rs

merged-by-bors

This PR was explicitly merged by bors.

PG-exploit-mitigations

Project group: Exploit mitigations

relnotes

Marks issues that should be documented in the release notes of the next release.

S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

T-compiler

Relevant to the compiler team, which will review and decide on the PR/issue.