[AIX] change AIX default codemodel=large by mustartt · Pull Request #133811 · rust-lang/rust (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation8 Commits1 Checks6 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

On AIX, for most libraries, we run out of Table of Contents (TOC) offsets very quickly due to the default 16-bit offset limit. We want the large code model should be used as the default to provide more TOC entries so the end user does not have to specify -Ccode-model=large for all their packages. This is even more of an issue with ThinLTO as the ThinLTO globals can very quickly use all available TOC entry.

In addition, on AIX, code with different code-model across different compilation units will not cause undefined behavior, so this is safe to do.

r? @BoxyUwU

rustbot has assigned @BoxyUwU.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

rustbot added S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

T-compiler

Relevant to the compiler team, which will review and decide on the PR/issue.

labels

Dec 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. We feel this will provide a more sensible default for modern applications, and the additional large codemodel access patterns have reduced impact on modern CPU generations

jieyouxu added the O-aix

OS: Big Blue's Advanced Interactive eXecutive..

label

Dec 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. AIX is tier 3, so this needs no other procedure.

Tagging this as compat relnotes just for FYI but I don't expect bug reports based on

on AIX, code with different code-model across different compilation units will not cause undefined behavior, so this is safe to do.

@rustbot label +relnotes

rustbot added the relnotes

Marks issues that should be documented in the release notes of the next release.

label

Dec 3, 2024

📌 Commit 89b70b9 has been approved by jieyouxu

It is now in the queue for this repository.

bors added S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

and removed S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

labels

Dec 3, 2024

bors added a commit to rust-lang-ci/rust that referenced this pull request

Dec 4, 2024

…iaskrgr

Rollup of 7 pull requests

Successful merges:

• rust-lang#132937 (a release operation synchronizes with an acquire operation)
• rust-lang#133681 (improve TagEncoding::Niche docs, sanity check, and UB checks)
• rust-lang#133726 (Add core::arch::breakpoint and test)
• rust-lang#133768 (Remove generic_associated_types_extended feature gate)
• rust-lang#133811 ([AIX] change AIX default codemodel=large)
• rust-lang#133812 (Update wasm-component-ld to 0.5.11)
• rust-lang#133813 (compiletest: explain that UI tests are expected not to compile by default)

r? @ghost @rustbot modify labels: rollup

rust-timer added a commit to rust-lang-ci/rust that referenced this pull request

Dec 4, 2024

Rollup merge of rust-lang#133811 - mustartt:change-default-codemodel, r=jieyouxu

[AIX] change AIX default codemodel=large

On AIX, for most libraries, we run out of Table of Contents (TOC) offsets very quickly due to the default 16-bit offset limit. We want the large code model should be used as the default to provide more TOC entries so the end user does not have to specify -Ccode-model=large for all their packages. This is even more of an issue with ThinLTO as the ThinLTO globals can very quickly use all available TOC entry.

In addition, on AIX, code with different code-model across different compilation units will not cause undefined behavior, so this is safe to do.

wip-sync pushed a commit to NetBSD/pkgsrc-wip that referenced this pull request

Feb 23, 2025

Pkgsrc changes relative to rust184:

• patch reorganization to deal with new version of upstream vendored crates, checksum updates.

Version 1.85.0 (2025-02-20)

Language

• [The 2024 Edition is now stable.] (rust-lang/rust#133349) See [the edition guide] (https://doc.rust-lang.org/nightly/edition-guide/rust-2024/index.html) for more details.
• [Stabilize async closures] (rust-lang/rust#132706) See [RFC 3668] (https://rust-lang.github.io/rfcs/3668-async-closures.html) for more details.
• [Stabilize #[diagnostic::do_not_recommend]] (rust-lang/rust#132056)
• [Add unpredictable_function_pointer_comparisons lint to warn against function pointer comparisons] (rust-lang/rust#118833)
• [Lint on combining #[no_mangle] and #[export_name] attributes.] (rust-lang/rust#131558)

Compiler

• [The unstable flag -Zpolymorphize has been removed] (rust-lang/rust#133883), see rust-lang/compiler-team#810 for some background.

Platform Support

• [Promote powerpc64le-unknown-linux-musl to tier 2 with host tools] (rust-lang/rust#133801)

Refer to Rust's [platform support page][platform-support-doc] for more information on Rust's tiered platform support.

Libraries

• [Panics in the standard library now have a leading library/ in their path] (rust-lang/rust#132390)

• [std::env::home_dir() on Windows now ignores the non-standard $HOME environment variable] (rust-lang/rust#132515)

  It will be un-deprecated in a subsequent release.

• [Add AsyncFn* to the prelude in all editions.] (rust-lang/rust#132611)

Stabilized APIs

• [BuildHasherDefault::new] (https://doc.rust-lang.org/stable/std/hash/struct.BuildHasherDefault.html#method.new)
• [ptr::fn_addr_eq] (https://doc.rust-lang.org/std/ptr/fn.fn_addr_eq.html)
• [io::ErrorKind::QuotaExceeded] (https://doc.rust-lang.org/stable/std/io/enum.ErrorKind.html#variant.QuotaExceeded)
• [io::ErrorKind::CrossesDevices] (https://doc.rust-lang.org/stable/std/io/enum.ErrorKind.html#variant.CrossesDevices)
• [{float}::midpoint] (https://doc.rust-lang.org/core/primitive.f32.html#method.midpoint)
• [Unsigned {integer}::midpoint] (https://doc.rust-lang.org/std/primitive.u64.html#method.midpoint)
• [NonZeroU*::midpoint] (https://doc.rust-lang.org/std/num/type.NonZeroU32.html#method.midpoint)
• [impl std::iter::Extend for tuples with arity 1 through 12] (https://doc.rust-lang.org/stable/std/iter/trait.Extend.html#impl-Extend%3C(A,)%3E-for-(EA,))
• [FromIterator<(A, ...)> for tuples with arity 1 through 12] (https://doc.rust-lang.org/stable/std/iter/trait.FromIterator.html#impl-FromIterator%3C(EA,)%3E-for-(A,))
• [std::task::Waker::noop] (https://doc.rust-lang.org/stable/std/task/struct.Waker.html#method.noop)

These APIs are now stable in const contexts:

• [mem::size_of_val] (https://doc.rust-lang.org/stable/std/mem/fn.size_of_val.html)
• [mem::align_of_val] (https://doc.rust-lang.org/stable/std/mem/fn.align_of_val.html)
• [Layout::for_value] (https://doc.rust-lang.org/stable/std/alloc/struct.Layout.html#method.for_value)
• [Layout::align_to] (https://doc.rust-lang.org/stable/std/alloc/struct.Layout.html#method.align_to)
• [Layout::pad_to_align] (https://doc.rust-lang.org/stable/std/alloc/struct.Layout.html#method.pad_to_align)
• [Layout::extend] (https://doc.rust-lang.org/stable/std/alloc/struct.Layout.html#method.extend)
• [Layout::array] (https://doc.rust-lang.org/stable/std/alloc/struct.Layout.html#method.array)
• [std::mem::swap] (https://doc.rust-lang.org/stable/std/mem/fn.swap.html)
• [std::ptr::swap] (https://doc.rust-lang.org/stable/std/ptr/fn.swap.html)
• [NonNull::new] (https://doc.rust-lang.org/stable/std/ptr/struct.NonNull.html#method.new)
• [HashMap::with_hasher] (https://doc.rust-lang.org/stable/std/collections/struct.HashMap.html#method.with_hasher)
• [HashSet::with_hasher] (https://doc.rust-lang.org/stable/std/collections/struct.HashSet.html#method.with_hasher)
• [BuildHasherDefault::new] (https://doc.rust-lang.org/stable/std/hash/struct.BuildHasherDefault.html#method.new)
• [<float>::recip] (https://doc.rust-lang.org/stable/std/primitive.f32.html#method.recip)
• [<float>::to_degrees] (https://doc.rust-lang.org/stable/std/primitive.f32.html#method.to_degrees)
• [<float>::to_radians] (https://doc.rust-lang.org/stable/std/primitive.f32.html#method.to_radians)
• [<float>::max] (https://doc.rust-lang.org/stable/std/primitive.f32.html#method.max)
• [<float>::min] (https://doc.rust-lang.org/stable/std/primitive.f32.html#method.min)
• [<float>::clamp] (https://doc.rust-lang.org/stable/std/primitive.f32.html#method.clamp)
• [<float>::abs] (https://doc.rust-lang.org/stable/std/primitive.f32.html#method.abs)
• [<float>::signum] (https://doc.rust-lang.org/stable/std/primitive.f32.html#method.signum)
• [<float>::copysign] (https://doc.rust-lang.org/stable/std/primitive.f32.html#method.copysign)
• [MaybeUninit::write] (https://doc.rust-lang.org/stable/std/mem/union.MaybeUninit.html#method.write)

Cargo

• [Add future-incompatibility warning against keywords in cfgs and add raw-idents] (rust-lang/cargo#14671)
• [Stabilize higher precedence trailing flags] (rust-lang/cargo#14900)
• [Pass CARGO_CFG_FEATURE to build scripts] (rust-lang/cargo#14902)

Rustdoc

• [Doc comment on impl blocks shows the first line, even when the impl block is collapsed] (rust-lang/rust#132155)

Compatibility Notes

• [rustc no longer treats the test cfg as a well known check-cfg] (rust-lang/rust#131729), instead it is up to the build systems and users of --check-cfg[^check-cfg] to set it as a well known cfg using --check-cfg=cfg(test).

  This is done to enable build systems like Cargo to set it conditionally, as not all source files are suitable for unit tests.

  [Cargo (for now) unconditionally sets the test cfg as a well known cfg] (rust-lang/cargo#14963). [^check-cfg]: https://doc.rust-lang.org/nightly/rustc/check-cfg.html

• [Disable potentially incorrect type inference if there are trivial and non-trivial where-clauses] (rust-lang/rust#132325)

• std::env::home_dir() has been deprecated for years, because it can give surprising results in some Windows configurations if the HOME environment variable is set (which is not the normal configuration on Windows). We had previously avoided changing its behavior, out of concern for compatibility with code depending on this non-standard configuration. Given how long this function has been deprecated, we're now fixing its behavior as a bugfix. A subsequent release will remove the deprecation for this function.

• [Make core::ffi::c_char signedness more closely match that of the platform-default char] (rust-lang/rust#132975)

  This changed c_char from an i8 to u8 or vice versa on many Tier 2 and 3 targets (mostly Arm and RISC-V embedded targets). The new definition may result in compilation failures but fixes compatibility issues with C.

  The libc crate matches this change as of its 0.2.169 release.

• [When compiling a nested macro_rules macro from an external crate, the content of the inner macro_rules is now built with the edition of the external crate, not the local crate.] (rust-lang/rust#133274)

• [Increase sparcv9-sun-solaris and x86_64-pc-solaris Solaris baseline to 11.4.] (rust-lang/rust#133293)

• [Show abi_unsupported_vector_types lint in future breakage reports] (rust-lang/rust#133374)

• [Error if multiple super-trait instantiations of dyn Trait need associated types to be specified but only one is provided] (rust-lang/rust#133392)

• [Change powerpc64-ibm-aix default codemodel to large] (rust-lang/rust#133811)

Internal Changes

These changes do not affect any public interfaces of Rust, but they represent significant improvements to the performance or internals of rustc and related tools.

• [Build x86_64-unknown-linux-gnu with LTO for C/C++ code (e.g., jemalloc)] (rust-lang/rust#134690)

tmeijn pushed a commit to tmeijn/dotfiles that referenced this pull request

Feb 26, 2025

This MR contains the following updates:

MR created with the help of el-capitano/tools/renovate-bot.

Proposed changes to behavior should be submitted there as MRs.

Release Notes

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻ Rebasing: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this MR and you won't be reminded about this update again.

• If you want to rebase/retry this MR, check this box

This MR has been generated by Renovate Bot.

github-actions bot pushed a commit to tautschnig/verify-rust-std that referenced this pull request

Mar 11, 2025

…iaskrgr

Rollup of 7 pull requests

Successful merges:

• rust-lang#132937 (a release operation synchronizes with an acquire operation)
• rust-lang#133681 (improve TagEncoding::Niche docs, sanity check, and UB checks)
• rust-lang#133726 (Add core::arch::breakpoint and test)
• rust-lang#133768 (Remove generic_associated_types_extended feature gate)
• rust-lang#133811 ([AIX] change AIX default codemodel=large)
• rust-lang#133812 (Update wasm-component-ld to 0.5.11)
• rust-lang#133813 (compiletest: explain that UI tests are expected not to compile by default)

r? @ghost @rustbot modify labels: rollup

Labels

O-aix

OS: Big Blue's Advanced Interactive eXecutive..

relnotes

Marks issues that should be documented in the release notes of the next release.

S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

T-compiler

Relevant to the compiler team, which will review and decide on the PR/issue.