Structurally resolve in probe_adt by compiler-errors · Pull Request #133558 · rust-lang/rust (original) (raw)
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation13 Commits1 Checks6 Files changed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
| @@ -307,7 +307,7 @@ impl<'tcx> HirTyLowerer<'tcx> for FnCtxt<'_, 'tcx> { | |
|---|---|
| ty::Alias(ty::Projection | ty::Inherent | ty::Weak, _) |
| if !ty.has_escaping_bound_vars() => |
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is scuffed lol
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes :3, we could try to use with_replaced_escaping_bound_vars, but also, I dislike the fact that we're normalizing here in the first place :<
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
well, we need to normalize here so we can determine the adt. but yeah, i'm gonna leave it.
This comment has been minimized.
This comment has been minimized.
r=me after updating crashes
Status: This is awaiting some action (such as code changes or more information) from the author.
and removed S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Removed the crash test bc it's basically the same thing as the test I added.
@bors r=lcnr rollup
📌 Commit a8df969 has been approved by lcnr
It is now in the queue for this repository.
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
labels
This comment has been minimized.
Status: This is awaiting some action (such as code changes or more information) from the author.
and removed S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
labels
📌 Commit 0609b99 has been approved by lcnr
It is now in the queue for this repository.
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
labels
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request
…ve-probe-adt, r=lcnr
Structurally resolve in probe_adt
fixes rust-lang#132320
r? lcnr
bors added a commit to rust-lang-ci/rust that referenced this pull request
…iaskrgr
Rollup of 8 pull requests
Successful merges:
- rust-lang#133089 (Stabilize noop_waker)
- rust-lang#133522 (Don't suggest restricting bound with unstable traits on stable and mention it's unstable on nightly)
- rust-lang#133545 (Lint against Symbol::intern on a string literal)
- rust-lang#133558 (Structurally resolve in
probe_adt) - rust-lang#133753 (Reduce false positives on some common cases from if-let-rescope lint)
- rust-lang#133762 (stabilize const_{size,align}_of_val)
- rust-lang#133777 (document -Zrandomize-layout in the unstable book)
- rust-lang#133779 (Use correct
hir_idfor array const arg infers)
r? @ghost
@rustbot modify labels: rollup
jhpratt added a commit to jhpratt/rust that referenced this pull request
…ve-probe-adt, r=lcnr
Structurally resolve in probe_adt
fixes rust-lang#132320
r? lcnr
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request
…ve-probe-adt, r=lcnr
Structurally resolve in probe_adt
fixes rust-lang#132320
r? lcnr
bors added a commit to rust-lang-ci/rust that referenced this pull request
…iaskrgr
Rollup of 7 pull requests
Successful merges:
- rust-lang#133522 (Don't suggest restricting bound with unstable traits on stable and mention it's unstable on nightly)
- rust-lang#133545 (Lint against Symbol::intern on a string literal)
- rust-lang#133558 (Structurally resolve in
probe_adt) - rust-lang#133753 (Reduce false positives on some common cases from if-let-rescope lint)
- rust-lang#133762 (stabilize const_{size,align}_of_val)
- rust-lang#133777 (document -Zrandomize-layout in the unstable book)
- rust-lang#133779 (Use correct
hir_idfor array const arg infers)
r? @ghost
@rustbot modify labels: rollup
bors added a commit to rust-lang-ci/rust that referenced this pull request
…iaskrgr
Rollup of 9 pull requests
Successful merges:
- rust-lang#132612 (Gate async fn trait bound modifier on
async_trait_bounds) - rust-lang#133545 (Lint against Symbol::intern on a string literal)
- rust-lang#133558 (Structurally resolve in
probe_adt) - rust-lang#133696 (stabilize const_collections_with_hasher and build_hasher_default_const_new)
- rust-lang#133753 (Reduce false positives on some common cases from if-let-rescope lint)
- rust-lang#133762 (stabilize const_{size,align}_of_val)
- rust-lang#133777 (document -Zrandomize-layout in the unstable book)
- rust-lang#133779 (Use correct
hir_idfor array const arg infers) - rust-lang#133796 (Update the definition of
borrowing_sub)
r? @ghost
@rustbot modify labels: rollup
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request
bors added a commit to rust-lang-ci/rust that referenced this pull request
Labels
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Relevant to the compiler team, which will review and decide on the PR/issue.
The Rustc Trait System Refactor Initiative (-Znext-solver)