Use correct hir_id for array const arg infers by BoxyUwU · Pull Request #133779 · rust-lang/rust (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation4 Commits1 Checks6 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

Fixes #133771

self.next_id() results in the DefId for the const argument, created from the hack introduced by #133468, having no HirId associated with it. This then results in an ICE in metadata encoding. Fixing this then results in another ICE where encode_defs was not skipping encoding type_of and other queries for DefIds when they correspond to a ConstArgKind::Infer node.

This only reproduces with a library crate as metadata is not encoded for binaries, and apparently we had 0 tests for generic_arg_infer for array lengths in a library crate so this was not caught :<

cc #133589 @voidc

r? @compiler-errors @lcnr

rustbot added S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

T-compiler

Relevant to the compiler team, which will review and decide on the PR/issue.

labels

Dec 3, 2024

r=me when green (or i'll approve it when it's green)

This comment has been minimized.

📌 Commit 2807ba7 has been approved by compiler-errors

It is now in the queue for this repository.

bors added S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

and removed S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

labels

Dec 3, 2024

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request

Dec 3, 2024

…id, r=compiler-errors

Use correct hir_id for array const arg infers

Fixes rust-lang#133771

self.next_id() results in the DefId for the const argument, created from the hack introduced by rust-lang#133468, having no HirId associated with it. This then results in an ICE in metadata encoding. Fixing this then results in another ICE where encode_defs was not skipping encoding type_of and other queries for DefIds when they correspond to a ConstArgKind::Infer node.

This only reproduces with a library crate as metadata is not encoded for binaries, and apparently we had 0 tests for generic_arg_infer for array lengths in a library crate so this was not caught :<

cc rust-lang#133589 @voidc

r? @compiler-errors @lcnr

bors added a commit to rust-lang-ci/rust that referenced this pull request

Dec 3, 2024

…iaskrgr

Rollup of 8 pull requests

Successful merges:

• rust-lang#133089 (Stabilize noop_waker)
• rust-lang#133522 (Don't suggest restricting bound with unstable traits on stable and mention it's unstable on nightly)
• rust-lang#133545 (Lint against Symbol::intern on a string literal)
• rust-lang#133558 (Structurally resolve in probe_adt)
• rust-lang#133753 (Reduce false positives on some common cases from if-let-rescope lint)
• rust-lang#133762 (stabilize const_{size,align}_of_val)
• rust-lang#133777 (document -Zrandomize-layout in the unstable book)
• rust-lang#133779 (Use correct hir_id for array const arg infers)

r? @ghost @rustbot modify labels: rollup

jhpratt added a commit to jhpratt/rust that referenced this pull request

Dec 3, 2024

…id, r=compiler-errors

Use correct hir_id for array const arg infers

Fixes rust-lang#133771

self.next_id() results in the DefId for the const argument, created from the hack introduced by rust-lang#133468, having no HirId associated with it. This then results in an ICE in metadata encoding. Fixing this then results in another ICE where encode_defs was not skipping encoding type_of and other queries for DefIds when they correspond to a ConstArgKind::Infer node.

This only reproduces with a library crate as metadata is not encoded for binaries, and apparently we had 0 tests for generic_arg_infer for array lengths in a library crate so this was not caught :<

cc rust-lang#133589 @voidc

r? @compiler-errors @lcnr

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request

Dec 3, 2024

…id, r=compiler-errors

Use correct hir_id for array const arg infers

Fixes rust-lang#133771

self.next_id() results in the DefId for the const argument, created from the hack introduced by rust-lang#133468, having no HirId associated with it. This then results in an ICE in metadata encoding. Fixing this then results in another ICE where encode_defs was not skipping encoding type_of and other queries for DefIds when they correspond to a ConstArgKind::Infer node.

This only reproduces with a library crate as metadata is not encoded for binaries, and apparently we had 0 tests for generic_arg_infer for array lengths in a library crate so this was not caught :<

cc rust-lang#133589 @voidc

r? @compiler-errors @lcnr

bors added a commit to rust-lang-ci/rust that referenced this pull request

Dec 3, 2024

…iaskrgr

Rollup of 7 pull requests

Successful merges:

• rust-lang#133522 (Don't suggest restricting bound with unstable traits on stable and mention it's unstable on nightly)
• rust-lang#133545 (Lint against Symbol::intern on a string literal)
• rust-lang#133558 (Structurally resolve in probe_adt)
• rust-lang#133753 (Reduce false positives on some common cases from if-let-rescope lint)
• rust-lang#133762 (stabilize const_{size,align}_of_val)
• rust-lang#133777 (document -Zrandomize-layout in the unstable book)
• rust-lang#133779 (Use correct hir_id for array const arg infers)

r? @ghost @rustbot modify labels: rollup

bors added a commit to rust-lang-ci/rust that referenced this pull request

Dec 3, 2024

…iaskrgr

Rollup of 9 pull requests

Successful merges:

• rust-lang#132612 (Gate async fn trait bound modifier on async_trait_bounds)
• rust-lang#133545 (Lint against Symbol::intern on a string literal)
• rust-lang#133558 (Structurally resolve in probe_adt)
• rust-lang#133696 (stabilize const_collections_with_hasher and build_hasher_default_const_new)
• rust-lang#133753 (Reduce false positives on some common cases from if-let-rescope lint)
• rust-lang#133762 (stabilize const_{size,align}_of_val)
• rust-lang#133777 (document -Zrandomize-layout in the unstable book)
• rust-lang#133779 (Use correct hir_id for array const arg infers)
• rust-lang#133796 (Update the definition of borrowing_sub)

r? @ghost @rustbot modify labels: rollup

rust-timer added a commit to rust-lang-ci/rust that referenced this pull request

Dec 3, 2024

Rollup merge of rust-lang#133779 - BoxyUwU:array_const_arg_infer_hir_id, r=compiler-errors

Use correct hir_id for array const arg infers

Fixes rust-lang#133771

self.next_id() results in the DefId for the const argument, created from the hack introduced by rust-lang#133468, having no HirId associated with it. This then results in an ICE in metadata encoding. Fixing this then results in another ICE where encode_defs was not skipping encoding type_of and other queries for DefIds when they correspond to a ConstArgKind::Infer node.

This only reproduces with a library crate as metadata is not encoded for binaries, and apparently we had 0 tests for generic_arg_infer for array lengths in a library crate so this was not caught :<

cc rust-lang#133589 @voidc

r? @compiler-errors @lcnr

Labels

S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

T-compiler

Relevant to the compiler team, which will review and decide on the PR/issue.