compiletest: explain that UI tests are expected not to compile by default by clubby789 · Pull Request #133813 · rust-lang/rust (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation9 Commits1 Checks6 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

error: ui test compiled successfully!

is not a very useful message for someone new to the test suite, so change the wording and add a note to explain

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

rustbot added A-compiletest

Area: The compiletest test runner

A-testsuite

Area: The testsuite used to check the correctness of rustc

S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

T-bootstrap

Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

labels

Dec 3, 2024

Some changes occurred in src/tools/compiletest

cc @jieyouxu

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

proc_res,
);
{
self.error(&format!("{} test did not emit an error", self.config.mode));

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remark (for myself): improve this diagnostics when I get to untangling the runtest logic to make it so that test suites explicitly declare their intended default behavior so that the diagnostics here can say e.g. "expected to check-fail, but this didn't fail" or whatever.

📌 Commit ab38efe has been approved by jieyouxu

It is now in the queue for this repository.

bors added S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

and removed S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

labels

Dec 3, 2024

bors added a commit to rust-lang-ci/rust that referenced this pull request

Dec 4, 2024

…iaskrgr

Rollup of 7 pull requests

Successful merges:

rust-lang#132937 (a release operation synchronizes with an acquire operation)
rust-lang#133681 (improve TagEncoding::Niche docs, sanity check, and UB checks)
rust-lang#133726 (Add core::arch::breakpoint and test)
rust-lang#133768 (Remove generic_associated_types_extended feature gate)
rust-lang#133811 ([AIX] change AIX default codemodel=large)
rust-lang#133812 (Update wasm-component-ld to 0.5.11)
rust-lang#133813 (compiletest: explain that UI tests are expected not to compile by default)

r? @ghost @rustbot modify labels: rollup

rust-timer added a commit to rust-lang-ci/rust that referenced this pull request

Dec 4, 2024

Rollup merge of rust-lang#133813 - clubby789:ui-pass-note, r=jieyouxu

compiletest: explain that UI tests are expected not to compile by default

error: ui test compiled successfully!

is not a very useful message for someone new to the test suite, so change the wording and add a note to explain

github-actions bot pushed a commit to tautschnig/verify-rust-std that referenced this pull request

Mar 11, 2025