interpret: clean up deduplicating allocation functions by RalfJung · Pull Request #134055 · rust-lang/rust (original) (raw)
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation5 Commits1 Checks6 Files changed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
The "align" and "kind" arguments would be largely ignored in the "dedup" case, so let's move that to entirely separate function.
Let's also remove support for old-style miri_resolve_frame while we are at it. The docs have already said for a while that this must be set to 1.
rustbot has assigned @petrochenkov.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.
Use r? to explicitly pick a reviewer
Status: Awaiting review from the assignee but also interested parties.
Relevant to the compiler team, which will review and decide on the PR/issue.
labels
Some changes occurred to the CTFE / Miri interpreter
cc @rust-lang/miri
The Miri subtree was changed
cc @rust-lang/miri
Some changes occurred to the CTFE machinery
cc @rust-lang/wg-const-eval
This comment has been minimized.
📌 Commit 73dc95d has been approved by oli-obk
It is now in the queue for this repository.
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
bors added a commit to rust-lang-ci/rust that referenced this pull request
Rollup of 9 pull requests
Successful merges:
- rust-lang#133996 (Move most tests for
-land#[link(..)]intotests/ui/link-native-libs) - rust-lang#134012 (Grammar fixes)
- rust-lang#134032 (docs: better examples for
std::ops::ControlFlow) - rust-lang#134040 (bootstrap: print{ln}! -> eprint{ln}! (take 2))
- rust-lang#134043 (Add test to check unicode identifier version)
- rust-lang#134053 (rustdoc: rename
issue-\d+.rstests to have meaningful names (part 10)) - rust-lang#134055 (interpret: clean up deduplicating allocation functions)
- rust-lang#134073 (dataflow_const_prop: do not eval a ptr address in SwitchInt)
- rust-lang#134084 (Fix typo in RFC mention 3598 -> 3593)
r? @ghost
@rustbot modify labels: rollup
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request
Rollup merge of rust-lang#134055 - RalfJung:interpret-alloc-dedup, r=oli-obk
interpret: clean up deduplicating allocation functions
The "align" and "kind" arguments would be largely ignored in the "dedup" case, so let's move that to entirely separate function.
Let's also remove support for old-style miri_resolve_frame while we are at it. The docs have already said for a while that this must be set to 1.
Labels
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Relevant to the compiler team, which will review and decide on the PR/issue.