Move most tests for -l and #[link(..)] into tests/ui/link-native-libs by Zalathar · Pull Request #133996 · rust-lang/rust (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation16 Commits2 Checks6 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

Tests for the closely-related -l flag and #[link(..)] attribute are spread across a few different directories, and in some cases have ended up in a test directory intended for other linker-related functionality.

This PR moves most of them into a single tests/ui/link-native-libs directory.

Part of #133895.

try-job: i686-mingw

r? jieyouxu

rustbot added A-testsuite

Area: The testsuite used to check the correctness of rustc

S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

T-bootstrap

Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

T-compiler

Relevant to the compiler team, which will review and decide on the PR/issue.

labels

Dec 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the cleanup 🩵! You can r=me after PR CI is green.

I noticed this while working on #132934, but at that time I didn't want to get sidetracked by fixing it. Seeing the UI test cleanup issue reminded me to go back and do something about it.

🟩

@bors r=jieyouxu rollup

📌 Commit 0a48b96 has been approved by jieyouxu

It is now in the queue for this repository.

bors added S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

and removed S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

labels

Dec 7, 2024

workingjubilee added a commit to workingjubilee/rustc that referenced this pull request

Dec 7, 2024

…eyouxu

Move most tests for -l and #[link(..)] into tests/ui/link-native-libs

Tests for the closely-related -l flag and #[link(..)] attribute are spread across a few different directories, and in some cases have ended up in a test directory intended for other linker-related functionality.

This PR moves most of them into a single tests/ui/link-native-libs directory.

Part of rust-lang#133895.

r? jieyouxu

bors added a commit to rust-lang-ci/rust that referenced this pull request

Dec 7, 2024

…kingjubilee

Rollup of 11 pull requests

Successful merges:

• rust-lang#131669 (lint: change help for pointers to dyn types in FFI)
• rust-lang#133265 (Add a range argument to vec.extract_if)
• rust-lang#133733 ( compiletest: show the difference between the normalized output and the actual output for lines which didn't match)
• rust-lang#133955 (Pass the arch rather than full target name to windows_registry::find_tool)
• rust-lang#133967 ([AIX] Pass -bnoipath when adding rust upstream dynamic crates)
• rust-lang#133976 (Removed Unnecessary Spaces From RELEASES.md)
• rust-lang#133980 ([AIX] Remove option "-n" from AIX "ln" command)
• rust-lang#133987 (Define acronym for thread local storage)
• rust-lang#133992 (Actually walk into lifetimes and attrs in EarlyContextAndPass)
• rust-lang#133993 (Fix: typo in E0751 error explanation)
• rust-lang#133996 (Move most tests for -l and #[link(..)] into tests/ui/link-native-libs)

r? @ghost @rustbot modify labels: rollup

bors added a commit to rust-lang-ci/rust that referenced this pull request

Dec 7, 2024

…kingjubilee

Rollup of 11 pull requests

Successful merges:

• rust-lang#131669 (lint: change help for pointers to dyn types in FFI)
• rust-lang#133265 (Add a range argument to vec.extract_if)
• rust-lang#133733 ( compiletest: show the difference between the normalized output and the actual output for lines which didn't match)
• rust-lang#133955 (Pass the arch rather than full target name to windows_registry::find_tool)
• rust-lang#133967 ([AIX] Pass -bnoipath when adding rust upstream dynamic crates)
• rust-lang#133976 (Removed Unnecessary Spaces From RELEASES.md)
• rust-lang#133980 ([AIX] Remove option "-n" from AIX "ln" command)
• rust-lang#133987 (Define acronym for thread local storage)
• rust-lang#133992 (Actually walk into lifetimes and attrs in EarlyContextAndPass)
• rust-lang#133993 (Fix: typo in E0751 error explanation)
• rust-lang#133996 (Move most tests for -l and #[link(..)] into tests/ui/link-native-libs)

r? @ghost @rustbot modify labels: rollup

bors added a commit to rust-lang-ci/rust that referenced this pull request

Dec 7, 2024

…kingjubilee

Rollup of 11 pull requests

Successful merges:

• rust-lang#131669 (lint: change help for pointers to dyn types in FFI)
• rust-lang#133265 (Add a range argument to vec.extract_if)
• rust-lang#133733 ( compiletest: show the difference between the normalized output and the actual output for lines which didn't match)
• rust-lang#133955 (Pass the arch rather than full target name to windows_registry::find_tool)
• rust-lang#133967 ([AIX] Pass -bnoipath when adding rust upstream dynamic crates)
• rust-lang#133976 (Removed Unnecessary Spaces From RELEASES.md)
• rust-lang#133980 ([AIX] Remove option "-n" from AIX "ln" command)
• rust-lang#133987 (Define acronym for thread local storage)
• rust-lang#133992 (Actually walk into lifetimes and attrs in EarlyContextAndPass)
• rust-lang#133993 (Fix: typo in E0751 error explanation)
• rust-lang#133996 (Move most tests for -l and #[link(..)] into tests/ui/link-native-libs)

r? @ghost @rustbot modify labels: rollup

bors added a commit to rust-lang-ci/rust that referenced this pull request

Dec 7, 2024

…kingjubilee

Rollup of 11 pull requests

Successful merges:

• rust-lang#131669 (lint: change help for pointers to dyn types in FFI)
• rust-lang#133265 (Add a range argument to vec.extract_if)
• rust-lang#133733 ( compiletest: show the difference between the normalized output and the actual output for lines which didn't match)
• rust-lang#133955 (Pass the arch rather than full target name to windows_registry::find_tool)
• rust-lang#133967 ([AIX] Pass -bnoipath when adding rust upstream dynamic crates)
• rust-lang#133976 (Removed Unnecessary Spaces From RELEASES.md)
• rust-lang#133980 ([AIX] Remove option "-n" from AIX "ln" command)
• rust-lang#133987 (Define acronym for thread local storage)
• rust-lang#133992 (Actually walk into lifetimes and attrs in EarlyContextAndPass)
• rust-lang#133993 (Fix: typo in E0751 error explanation)
• rust-lang#133996 (Move most tests for -l and #[link(..)] into tests/ui/link-native-libs)

r? @ghost @rustbot modify labels: rollup

workingjubilee added a commit to workingjubilee/rustc that referenced this pull request

Dec 8, 2024

…eyouxu

Move most tests for -l and #[link(..)] into tests/ui/link-native-libs

Tests for the closely-related -l flag and #[link(..)] attribute are spread across a few different directories, and in some cases have ended up in a test directory intended for other linker-related functionality.

This PR moves most of them into a single tests/ui/link-native-libs directory.

Part of rust-lang#133895.

r? jieyouxu

bors added a commit to rust-lang-ci/rust that referenced this pull request

Dec 8, 2024

…kingjubilee

Rollup of 10 pull requests

Successful merges:

• rust-lang#133522 (Don't suggest restricting bound with unstable traits on stable and mention it's unstable on nightly)
• rust-lang#133733 ( compiletest: show the difference between the normalized output and the actual output for lines which didn't match)
• rust-lang#133861 (Add allocate_bytes and refactor allocate_str in InterpCx for raw byte…)
• rust-lang#133967 ([AIX] Pass -bnoipath when adding rust upstream dynamic crates)
• rust-lang#133976 (Removed Unnecessary Spaces From RELEASES.md)
• rust-lang#133980 ([AIX] Remove option "-n" from AIX "ln" command)
• rust-lang#133987 (Define acronym for thread local storage)
• rust-lang#133992 (Actually walk into lifetimes and attrs in EarlyContextAndPass)
• rust-lang#133993 (Fix: typo in E0751 error explanation)
• rust-lang#133996 (Move most tests for -l and #[link(..)] into tests/ui/link-native-libs)

r? @ghost @rustbot modify labels: rollup

bors added a commit to rust-lang-ci/rust that referenced this pull request

Dec 8, 2024

…kingjubilee

Rollup of 10 pull requests

Successful merges:

• rust-lang#133522 (Don't suggest restricting bound with unstable traits on stable and mention it's unstable on nightly)
• rust-lang#133733 ( compiletest: show the difference between the normalized output and the actual output for lines which didn't match)
• rust-lang#133861 (Add allocate_bytes and refactor allocate_str in InterpCx for raw byte…)
• rust-lang#133967 ([AIX] Pass -bnoipath when adding rust upstream dynamic crates)
• rust-lang#133976 (Removed Unnecessary Spaces From RELEASES.md)
• rust-lang#133980 ([AIX] Remove option "-n" from AIX "ln" command)
• rust-lang#133987 (Define acronym for thread local storage)
• rust-lang#133992 (Actually walk into lifetimes and attrs in EarlyContextAndPass)
• rust-lang#133993 (Fix: typo in E0751 error explanation)
• rust-lang#133996 (Move most tests for -l and #[link(..)] into tests/ui/link-native-libs)

r? @ghost @rustbot modify labels: rollup

workingjubilee added a commit to workingjubilee/rustc that referenced this pull request

Dec 8, 2024

…eyouxu

Move most tests for -l and #[link(..)] into tests/ui/link-native-libs

Tests for the closely-related -l flag and #[link(..)] attribute are spread across a few different directories, and in some cases have ended up in a test directory intended for other linker-related functionality.

This PR moves most of them into a single tests/ui/link-native-libs directory.

Part of rust-lang#133895.

r? jieyouxu

bors added a commit to rust-lang-ci/rust that referenced this pull request

Dec 8, 2024

[TEST] Rollup of 5 pull requests

Successful merges:

• rust-lang#133987 (Define acronym for thread local storage)
• rust-lang#133992 (Actually walk into lifetimes and attrs in EarlyContextAndPass)
• rust-lang#133993 (Fix: typo in E0751 error explanation)
• rust-lang#133996 (Move most tests for -l and #[link(..)] into tests/ui/link-native-libs)
• rust-lang#134020 (Remove unnecessary int_type_width_signed function)

try-job: i686-mingw

r? @ghost @rustbot modify labels: rollup

bors removed the S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

label

Dec 8, 2024

bors added the S-waiting-on-author

Status: This is awaiting some action (such as code changes or more information) from the author.

label

Dec 8, 2024

bors added a commit to rust-lang-ci/rust that referenced this pull request

Dec 8, 2024

Move most tests for -l and #[link(..)] into tests/ui/link-native-libs

Tests for the closely-related -l flag and #[link(..)] attribute are spread across a few different directories, and in some cases have ended up in a test directory intended for other linker-related functionality.

This PR moves most of them into a single tests/ui/link-native-libs directory.

Part of rust-lang#133895.

try-job: i686-mingw

r? jieyouxu

☀️ Try build successful - checks-actions
Build commit: e844b3d (e844b3da21d6b0fa8df59af7d98f7a62d7eeb307)

This only moved tests around.
@bors r+ rollup

📌 Commit 0a48b96 has been approved by jieyouxu

It is now in the queue for this repository.

bors added S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

and removed S-waiting-on-author

Status: This is awaiting some action (such as code changes or more information) from the author.

labels

Dec 9, 2024

GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request

Dec 9, 2024

…eyouxu

Move most tests for -l and #[link(..)] into tests/ui/link-native-libs

Tests for the closely-related -l flag and #[link(..)] attribute are spread across a few different directories, and in some cases have ended up in a test directory intended for other linker-related functionality.

This PR moves most of them into a single tests/ui/link-native-libs directory.

Part of rust-lang#133895.

try-job: i686-mingw

r? jieyouxu

bors added a commit to rust-lang-ci/rust that referenced this pull request

Dec 9, 2024

…llaumeGomez

Rollup of 9 pull requests

Successful merges:

• rust-lang#133184 (wasi/fs: Improve stopping condition for ::next)
• rust-lang#133955 (Pass the arch rather than full target name to windows_registry::find_tool)
• rust-lang#133967 ([AIX] Pass -bnoipath when adding rust upstream dynamic crates)
• rust-lang#133970 ([AIX] Replace sa_sigaction with sa_union.__su_sigaction for AIX)
• rust-lang#133980 ([AIX] Remove option "-n" from AIX "ln" command)
• rust-lang#133996 (Move most tests for -l and #[link(..)] into tests/ui/link-native-libs)
• rust-lang#134017 (Don't use AsyncFnOnce::CallOnceFuture bounds for signature deduction)
• rust-lang#134023 (handle cygwin environment in install::sanitize_sh)
• rust-lang#134053 (rustdoc: rename issue-\d+.rs tests to have meaningful names (part 10))

r? @ghost @rustbot modify labels: rollup

jieyouxu added a commit to jieyouxu/rust that referenced this pull request

Dec 9, 2024

…eyouxu

Move most tests for -l and #[link(..)] into tests/ui/link-native-libs

Tests for the closely-related -l flag and #[link(..)] attribute are spread across a few different directories, and in some cases have ended up in a test directory intended for other linker-related functionality.

This PR moves most of them into a single tests/ui/link-native-libs directory.

Part of rust-lang#133895.

try-job: i686-mingw

r? jieyouxu

jieyouxu added a commit to jieyouxu/rust that referenced this pull request

Dec 9, 2024

…eyouxu

Move most tests for -l and #[link(..)] into tests/ui/link-native-libs

Tests for the closely-related -l flag and #[link(..)] attribute are spread across a few different directories, and in some cases have ended up in a test directory intended for other linker-related functionality.

This PR moves most of them into a single tests/ui/link-native-libs directory.

Part of rust-lang#133895.

try-job: i686-mingw

r? jieyouxu

bors added a commit to rust-lang-ci/rust that referenced this pull request

Dec 9, 2024

Rollup of 8 pull requests

Successful merges:

• rust-lang#133184 (wasi/fs: Improve stopping condition for ::next)
• rust-lang#133967 ([AIX] Pass -bnoipath when adding rust upstream dynamic crates)
• rust-lang#133970 ([AIX] Replace sa_sigaction with sa_union.__su_sigaction for AIX)
• rust-lang#133980 ([AIX] Remove option "-n" from AIX "ln" command)
• rust-lang#133996 (Move most tests for -l and #[link(..)] into tests/ui/link-native-libs)
• rust-lang#134017 (Don't use AsyncFnOnce::CallOnceFuture bounds for signature deduction)
• rust-lang#134023 (handle cygwin environment in install::sanitize_sh)
• rust-lang#134053 (rustdoc: rename issue-\d+.rs tests to have meaningful names (part 10))

r? @ghost @rustbot modify labels: rollup

bors added a commit to rust-lang-ci/rust that referenced this pull request

Dec 9, 2024

Rollup of 8 pull requests

Successful merges:

• rust-lang#133184 (wasi/fs: Improve stopping condition for ::next)
• rust-lang#133967 ([AIX] Pass -bnoipath when adding rust upstream dynamic crates)
• rust-lang#133970 ([AIX] Replace sa_sigaction with sa_union.__su_sigaction for AIX)
• rust-lang#133980 ([AIX] Remove option "-n" from AIX "ln" command)
• rust-lang#133996 (Move most tests for -l and #[link(..)] into tests/ui/link-native-libs)
• rust-lang#134017 (Don't use AsyncFnOnce::CallOnceFuture bounds for signature deduction)
• rust-lang#134023 (handle cygwin environment in install::sanitize_sh)
• rust-lang#134053 (rustdoc: rename issue-\d+.rs tests to have meaningful names (part 10))

r? @ghost @rustbot modify labels: rollup

bors added a commit to rust-lang-ci/rust that referenced this pull request

Dec 10, 2024

Rollup of 9 pull requests

Successful merges:

• rust-lang#133996 (Move most tests for -l and #[link(..)] into tests/ui/link-native-libs)
• rust-lang#134012 (Grammar fixes)
• rust-lang#134032 (docs: better examples for std::ops::ControlFlow)
• rust-lang#134040 (bootstrap: print{ln}! -> eprint{ln}! (take 2))
• rust-lang#134043 (Add test to check unicode identifier version)
• rust-lang#134053 (rustdoc: rename issue-\d+.rs tests to have meaningful names (part 10))
• rust-lang#134055 (interpret: clean up deduplicating allocation functions)
• rust-lang#134073 (dataflow_const_prop: do not eval a ptr address in SwitchInt)
• rust-lang#134084 (Fix typo in RFC mention 3598 -> 3593)

r? @ghost @rustbot modify labels: rollup

rust-timer added a commit to rust-lang-ci/rust that referenced this pull request

Dec 10, 2024

Rollup merge of rust-lang#133996 - Zalathar:ui-link-native-libs, r=jieyouxu

Move most tests for -l and #[link(..)] into tests/ui/link-native-libs

Tests for the closely-related -l flag and #[link(..)] attribute are spread across a few different directories, and in some cases have ended up in a test directory intended for other linker-related functionality.

This PR moves most of them into a single tests/ui/link-native-libs directory.

Part of rust-lang#133895.

try-job: i686-mingw

r? jieyouxu

Labels

A-testsuite

Area: The testsuite used to check the correctness of rustc

S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

T-bootstrap

Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

T-compiler

Relevant to the compiler team, which will review and decide on the PR/issue.