Some asm! diagnostic adjustments and a papercut fix by oli-obk · Pull Request #134070 · rust-lang/rust (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation21 Commits3 Checks6 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

Best reviewed commit by commit.

We forgot a normalize call in intrinsic checking, causing us to allow literal integers, but not named constants containing that literal. This can in theory affect stable code, but only if libstd contains a stable SIMD type that has an array length that is a named constant. I'd assume we'd have noticed by now due to asm! rejecting those outright.

The error message left me scratching my head for a bit, so I added some extra information to the diagnostic, too.

r? @davidtwco

rustbot has assigned @davidtwco.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

rustbot added S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

T-compiler

Relevant to the compiler team, which will review and decide on the PR/issue.

labels

Dec 9, 2024

oli-obk changed the titleClarify why a type is rejected for asm! Some asm! diagnostic adjustments and a papercut fix

Dec 9, 2024

This comment has been minimized.

Member

jieyouxu left a comment • Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this looks good to me. The diagnostics indeed look significantly nicer!

📌 Commit f167d3c has been approved by jieyouxu

It is now in the queue for this repository.

bors added S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

and removed S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

labels

Dec 9, 2024

fmease added a commit to fmease/rust that referenced this pull request

Dec 9, 2024

Some asm! diagnostic adjustments and a papercut fix

Best reviewed commit by commit.

We forgot a normalize call in intrinsic checking, causing us to allow literal integers, but not named constants containing that literal. This can in theory affect stable code, but only if libstd contains a stable SIMD type that has an array length that is a named constant. I'd assume we'd have noticed by now due to asm! rejecting those outright.

The error message left me scratching my head for a bit, so I added some extra information to the diagnostic, too.

bors added a commit to rust-lang-ci/rust that referenced this pull request

Dec 10, 2024

Rollup of 9 pull requests

Successful merges:

• rust-lang#133967 ([AIX] Pass -bnoipath when adding rust upstream dynamic crates)
• rust-lang#133970 ([AIX] Replace sa_sigaction with sa_union.__su_sigaction for AIX)
• rust-lang#133980 ([AIX] Remove option "-n" from AIX "ln" command)
• rust-lang#134008 (Make Copy unsafe to implement for ADTs with unsafe fields)
• rust-lang#134017 (Don't use AsyncFnOnce::CallOnceFuture bounds for signature deduction)
• rust-lang#134023 (handle cygwin environment in install::sanitize_sh)
• rust-lang#134041 (Use SourceMap to load debugger visualizer files)
• rust-lang#134065 (Move write_graphviz_results)
• rust-lang#134070 (Some asm! diagnostic adjustments and a papercut fix)

r? @ghost @rustbot modify labels: rollup

bors added S-waiting-on-author

Status: This is awaiting some action (such as code changes or more information) from the author.

and removed S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

labels

Dec 10, 2024

limited the test to x86

@bors r=jieyouxu

📌 Commit c7088b2 has been approved by jieyouxu

It is now in the queue for this repository.

bors added S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

and removed S-waiting-on-author

Status: This is awaiting some action (such as code changes or more information) from the author.

labels

Dec 10, 2024

fmease added a commit to fmease/rust that referenced this pull request

Dec 10, 2024

Some asm! diagnostic adjustments and a papercut fix

Best reviewed commit by commit.

We forgot a normalize call in intrinsic checking, causing us to allow literal integers, but not named constants containing that literal. This can in theory affect stable code, but only if libstd contains a stable SIMD type that has an array length that is a named constant. I'd assume we'd have noticed by now due to asm! rejecting those outright.

The error message left me scratching my head for a bit, so I added some extra information to the diagnostic, too.

The other test needs to be limited, too.

📌 Commit 53d2931 has been approved by jieyouxu

It is now in the queue for this repository.

bors added S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

and removed S-waiting-on-author

Status: This is awaiting some action (such as code changes or more information) from the author.

labels

Dec 11, 2024

This comment has been minimized.

In the second commit, there's an empty stderr file as the test became run-pass.
@bors r-

bors added S-waiting-on-author

Status: This is awaiting some action (such as code changes or more information) from the author.

and removed S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

labels

Dec 11, 2024

What the heck xD I blessed all ui tests in all commits...

What the heck xD I blessed all ui tests in all commits...

Hm, this might be a compiletest bug, where if u had a previous stderr from check-fail then u change it to check-pass it might write empty stderr but keep the file... I'll open an issue later.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

📌 Commit 98edb8f has been approved by jieyouxu

It is now in the queue for this repository.

bors added S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

and removed S-waiting-on-author

Status: This is awaiting some action (such as code changes or more information) from the author.

labels

Dec 12, 2024

jieyouxu added a commit to jieyouxu/rust that referenced this pull request

Dec 12, 2024

Some asm! diagnostic adjustments and a papercut fix

Best reviewed commit by commit.

We forgot a normalize call in intrinsic checking, causing us to allow literal integers, but not named constants containing that literal. This can in theory affect stable code, but only if libstd contains a stable SIMD type that has an array length that is a named constant. I'd assume we'd have noticed by now due to asm! rejecting those outright.

The error message left me scratching my head for a bit, so I added some extra information to the diagnostic, too.

This was referenced

Dec 12, 2024

bors added a commit to rust-lang-ci/rust that referenced this pull request

Dec 12, 2024

Rollup of 13 pull requests

Successful merges:

• rust-lang#122003 (link libunwind dynamically and allow controlling it via crt-static on gnullvm targets)
• rust-lang#133122 (Add unpolished, experimental support for AFIDT (async fn in dyn trait))
• rust-lang#133859 (Move some alloc tests to the alloctests crate)
• rust-lang#134070 (Some asm! diagnostic adjustments and a papercut fix)
• rust-lang#134095 ([CI] Use a lockfile for installing the datadog package)
• rust-lang#134144 (Properly consider APITs for never type fallback ascription fix)
• rust-lang#134152 (Simplify rustc_mir_dataflow::abs_domain.)
• rust-lang#134154 (suppress field expr with generics error message if it's a method)
• rust-lang#134155 (Forbid unsafe_op_in_unsafe_fn for Hurd)
• rust-lang#134173 (allow symbol_intern_string_literal lint in test modules)
• rust-lang#134178 (Stabilize the Rust 2024 prelude)
• rust-lang#134179 (Remove outdated consteval note from <*mut T>::align_offset docs.)
• rust-lang#134187 (Remove PErr.)

r? @ghost @rustbot modify labels: rollup

bors added a commit to rust-lang-ci/rust that referenced this pull request

Dec 12, 2024

…iaskrgr

Rollup of 11 pull requests

Successful merges:

• rust-lang#122003 (link libunwind dynamically and allow controlling it via crt-static on gnullvm targets)
• rust-lang#133859 (Move some alloc tests to the alloctests crate)
• rust-lang#134070 (Some asm! diagnostic adjustments and a papercut fix)
• rust-lang#134144 (Properly consider APITs for never type fallback ascription fix)
• rust-lang#134152 (Simplify rustc_mir_dataflow::abs_domain.)
• rust-lang#134154 (suppress field expr with generics error message if it's a method)
• rust-lang#134155 (Forbid unsafe_op_in_unsafe_fn for Hurd)
• rust-lang#134173 (allow symbol_intern_string_literal lint in test modules)
• rust-lang#134178 (Stabilize the Rust 2024 prelude)
• rust-lang#134179 (Remove outdated consteval note from <*mut T>::align_offset docs.)
• rust-lang#134187 (Remove PErr.)

r? @ghost @rustbot modify labels: rollup

rust-timer added a commit to rust-lang-ci/rust that referenced this pull request

Dec 12, 2024

Rollup merge of rust-lang#134070 - oli-obk:push-nquzymupzlsq, r=jieyouxu

Some asm! diagnostic adjustments and a papercut fix

Best reviewed commit by commit.

We forgot a normalize call in intrinsic checking, causing us to allow literal integers, but not named constants containing that literal. This can in theory affect stable code, but only if libstd contains a stable SIMD type that has an array length that is a named constant. I'd assume we'd have noticed by now due to asm! rejecting those outright.

The error message left me scratching my head for a bit, so I added some extra information to the diagnostic, too.

Labels

S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

T-compiler

Relevant to the compiler team, which will review and decide on the PR/issue.