handle cygwin environment in install::sanitize_sh by onur-ozkan · Pull Request #134023 · rust-lang/rust (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation10 Commits2 Checks6 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

r? @albertlarsan68

rustbot has assigned @albertlarsan68.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

rustbot added S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

T-bootstrap

Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

labels

Dec 8, 2024

This comment has been minimized.

Signed-off-by: onur-ozkan work@onurozkan.dev

Signed-off-by: onur-ozkan work@onurozkan.dev

This PR modifies src/bootstrap/src/core/config.

If appropriate, please update CONFIG_CHANGE_HISTORY in src/bootstrap/src/utils/change_tracker.rs.

onur-ozkan changed the titledetect and handle cygwin in install::sanitize_sh handle cygwin environment in install::sanitize_sh

Dec 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I don't have access to a cygwin environment, but it was already broken on cygwin before and this can't make it worse even if it didn't work. On the contrary, I also think this might correctly address the reported issue. As such, there's only one way to find out if it works or not, and that is by merging it.

r? jieyouxu @bors r+ rollup=iffy

📌 Commit d3b5340 has been approved by jieyouxu

It is now in the queue for this repository.

bors added S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

and removed S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

labels

Dec 8, 2024

@bors rollup (i dont think x install is exercised in ci)

GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request

Dec 9, 2024

bors added a commit to rust-lang-ci/rust that referenced this pull request

Dec 9, 2024

…llaumeGomez

Rollup of 9 pull requests

Successful merges:

• rust-lang#133184 (wasi/fs: Improve stopping condition for ::next)
• rust-lang#133955 (Pass the arch rather than full target name to windows_registry::find_tool)
• rust-lang#133967 ([AIX] Pass -bnoipath when adding rust upstream dynamic crates)
• rust-lang#133970 ([AIX] Replace sa_sigaction with sa_union.__su_sigaction for AIX)
• rust-lang#133980 ([AIX] Remove option "-n" from AIX "ln" command)
• rust-lang#133996 (Move most tests for -l and #[link(..)] into tests/ui/link-native-libs)
• rust-lang#134017 (Don't use AsyncFnOnce::CallOnceFuture bounds for signature deduction)
• rust-lang#134023 (handle cygwin environment in install::sanitize_sh)
• rust-lang#134053 (rustdoc: rename issue-\d+.rs tests to have meaningful names (part 10))

r? @ghost @rustbot modify labels: rollup

jieyouxu added a commit to jieyouxu/rust that referenced this pull request

Dec 9, 2024

jieyouxu added a commit to jieyouxu/rust that referenced this pull request

Dec 9, 2024

bors added a commit to rust-lang-ci/rust that referenced this pull request

Dec 9, 2024

Rollup of 8 pull requests

Successful merges:

• rust-lang#133184 (wasi/fs: Improve stopping condition for ::next)
• rust-lang#133967 ([AIX] Pass -bnoipath when adding rust upstream dynamic crates)
• rust-lang#133970 ([AIX] Replace sa_sigaction with sa_union.__su_sigaction for AIX)
• rust-lang#133980 ([AIX] Remove option "-n" from AIX "ln" command)
• rust-lang#133996 (Move most tests for -l and #[link(..)] into tests/ui/link-native-libs)
• rust-lang#134017 (Don't use AsyncFnOnce::CallOnceFuture bounds for signature deduction)
• rust-lang#134023 (handle cygwin environment in install::sanitize_sh)
• rust-lang#134053 (rustdoc: rename issue-\d+.rs tests to have meaningful names (part 10))

r? @ghost @rustbot modify labels: rollup

bors added a commit to rust-lang-ci/rust that referenced this pull request

Dec 9, 2024

Rollup of 8 pull requests

Successful merges:

• rust-lang#133184 (wasi/fs: Improve stopping condition for ::next)
• rust-lang#133967 ([AIX] Pass -bnoipath when adding rust upstream dynamic crates)
• rust-lang#133970 ([AIX] Replace sa_sigaction with sa_union.__su_sigaction for AIX)
• rust-lang#133980 ([AIX] Remove option "-n" from AIX "ln" command)
• rust-lang#133996 (Move most tests for -l and #[link(..)] into tests/ui/link-native-libs)
• rust-lang#134017 (Don't use AsyncFnOnce::CallOnceFuture bounds for signature deduction)
• rust-lang#134023 (handle cygwin environment in install::sanitize_sh)
• rust-lang#134053 (rustdoc: rename issue-\d+.rs tests to have meaningful names (part 10))

r? @ghost @rustbot modify labels: rollup

fmease added a commit to fmease/rust that referenced this pull request

Dec 9, 2024

bors added a commit to rust-lang-ci/rust that referenced this pull request

Dec 10, 2024

Rollup of 9 pull requests

Successful merges:

• rust-lang#133967 ([AIX] Pass -bnoipath when adding rust upstream dynamic crates)
• rust-lang#133970 ([AIX] Replace sa_sigaction with sa_union.__su_sigaction for AIX)
• rust-lang#133980 ([AIX] Remove option "-n" from AIX "ln" command)
• rust-lang#134008 (Make Copy unsafe to implement for ADTs with unsafe fields)
• rust-lang#134017 (Don't use AsyncFnOnce::CallOnceFuture bounds for signature deduction)
• rust-lang#134023 (handle cygwin environment in install::sanitize_sh)
• rust-lang#134041 (Use SourceMap to load debugger visualizer files)
• rust-lang#134065 (Move write_graphviz_results)
• rust-lang#134070 (Some asm! diagnostic adjustments and a papercut fix)

r? @ghost @rustbot modify labels: rollup

fmease added a commit to fmease/rust that referenced this pull request

Dec 10, 2024

This was referenced

Dec 10, 2024

bors added a commit to rust-lang-ci/rust that referenced this pull request

Dec 10, 2024

Rollup of 11 pull requests

Successful merges:

• rust-lang#133478 (jsondocck: Parse, don't validate commands.)
• rust-lang#133967 ([AIX] Pass -bnoipath when adding rust upstream dynamic crates)
• rust-lang#133970 ([AIX] Replace sa_sigaction with sa_union.__su_sigaction for AIX)
• rust-lang#133980 ([AIX] Remove option "-n" from AIX "ln" command)
• rust-lang#134008 (Make Copy unsafe to implement for ADTs with unsafe fields)
• rust-lang#134017 (Don't use AsyncFnOnce::CallOnceFuture bounds for signature deduction)
• rust-lang#134023 (handle cygwin environment in install::sanitize_sh)
• rust-lang#134041 (Use SourceMap to load debugger visualizer files)
• rust-lang#134065 (Move write_graphviz_results)
• rust-lang#134106 (Add compiler-maintainers who requested to be on review rotation)
• rust-lang#134123 (bootstrap: Forward cargo JSON output to stdout, not stderr)

Failed merges:

• rust-lang#134120 (Remove Felix from ping groups and review rotation)

r? @ghost @rustbot modify labels: rollup

rust-timer added a commit to rust-lang-ci/rust that referenced this pull request

Dec 10, 2024

flip1995 pushed a commit to flip1995/rust that referenced this pull request

Dec 15, 2024

Rollup of 11 pull requests

Successful merges:

• rust-lang#133478 (jsondocck: Parse, don't validate commands.)
• rust-lang#133967 ([AIX] Pass -bnoipath when adding rust upstream dynamic crates)
• rust-lang#133970 ([AIX] Replace sa_sigaction with sa_union.__su_sigaction for AIX)
• rust-lang#133980 ([AIX] Remove option "-n" from AIX "ln" command)
• rust-lang#134008 (Make Copy unsafe to implement for ADTs with unsafe fields)
• rust-lang#134017 (Don't use AsyncFnOnce::CallOnceFuture bounds for signature deduction)
• rust-lang#134023 (handle cygwin environment in install::sanitize_sh)
• rust-lang#134041 (Use SourceMap to load debugger visualizer files)
• rust-lang#134065 (Move write_graphviz_results)
• rust-lang#134106 (Add compiler-maintainers who requested to be on review rotation)
• rust-lang#134123 (bootstrap: Forward cargo JSON output to stdout, not stderr)

Failed merges:

• rust-lang#134120 (Remove Felix from ping groups and review rotation)

r? @ghost @rustbot modify labels: rollup

Labels

S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

T-bootstrap

Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)