Add compiler-maintainers who requested to be on review rotation by wesleywiser · Pull Request #134106 · rust-lang/rust (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation5 Commits1 Checks6 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

rustbot added A-meta

Area: Issues & PRs about the rust-lang/rust repository itself

S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

labels

Dec 10, 2024

triagebot.toml has been modified, there may have been changes to the review queue.

cc @davidtwco, @wesleywiser

Since the reviewers requested to be on rotation themselves, I don't think this needs further signoff.
@bors r+ rollup

📌 Commit 88c8b10 has been approved by jieyouxu

It is now in the queue for this repository.

bors added S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

and removed S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

labels

Dec 10, 2024

Thanks for (re-)joining the hot potato line!

fmease added a commit to fmease/rust that referenced this pull request

Dec 10, 2024

…_queue_maintainers, r=jieyouxu

Add compiler-maintainers who requested to be on review rotation

r? @davidtwco

cc @Noratrieb @SparrowLii

This was referenced

Dec 10, 2024

bors added a commit to rust-lang-ci/rust that referenced this pull request

Dec 10, 2024

Rollup of 11 pull requests

Successful merges:

• rust-lang#133478 (jsondocck: Parse, don't validate commands.)
• rust-lang#133967 ([AIX] Pass -bnoipath when adding rust upstream dynamic crates)
• rust-lang#133970 ([AIX] Replace sa_sigaction with sa_union.__su_sigaction for AIX)
• rust-lang#133980 ([AIX] Remove option "-n" from AIX "ln" command)
• rust-lang#134008 (Make Copy unsafe to implement for ADTs with unsafe fields)
• rust-lang#134017 (Don't use AsyncFnOnce::CallOnceFuture bounds for signature deduction)
• rust-lang#134023 (handle cygwin environment in install::sanitize_sh)
• rust-lang#134041 (Use SourceMap to load debugger visualizer files)
• rust-lang#134065 (Move write_graphviz_results)
• rust-lang#134106 (Add compiler-maintainers who requested to be on review rotation)
• rust-lang#134123 (bootstrap: Forward cargo JSON output to stdout, not stderr)

Failed merges:

• rust-lang#134120 (Remove Felix from ping groups and review rotation)

r? @ghost @rustbot modify labels: rollup

rust-timer added a commit to rust-lang-ci/rust that referenced this pull request

Dec 10, 2024

Rollup merge of rust-lang#134106 - wesleywiser:update_compiler_review_queue_maintainers, r=jieyouxu

Add compiler-maintainers who requested to be on review rotation

r? @davidtwco

cc @Noratrieb @SparrowLii

flip1995 pushed a commit to flip1995/rust that referenced this pull request

Dec 15, 2024

Rollup of 11 pull requests

Successful merges:

• rust-lang#133478 (jsondocck: Parse, don't validate commands.)
• rust-lang#133967 ([AIX] Pass -bnoipath when adding rust upstream dynamic crates)
• rust-lang#133970 ([AIX] Replace sa_sigaction with sa_union.__su_sigaction for AIX)
• rust-lang#133980 ([AIX] Remove option "-n" from AIX "ln" command)
• rust-lang#134008 (Make Copy unsafe to implement for ADTs with unsafe fields)
• rust-lang#134017 (Don't use AsyncFnOnce::CallOnceFuture bounds for signature deduction)
• rust-lang#134023 (handle cygwin environment in install::sanitize_sh)
• rust-lang#134041 (Use SourceMap to load debugger visualizer files)
• rust-lang#134065 (Move write_graphviz_results)
• rust-lang#134106 (Add compiler-maintainers who requested to be on review rotation)
• rust-lang#134123 (bootstrap: Forward cargo JSON output to stdout, not stderr)

Failed merges:

• rust-lang#134120 (Remove Felix from ping groups and review rotation)

r? @ghost @rustbot modify labels: rollup

Labels

A-meta

Area: Issues & PRs about the rust-lang/rust repository itself

S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.