Report correct SelectionError for ConstArgHasType in new solver fulfill by compiler-errors · Pull Request #134771 · rust-lang/rust (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation4 Commits1 Checks6 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

compiler-errors

@compiler-errors

@rustbot

Some changes occurred to the core trait solver

cc @rust-lang/initiative-trait-system-refactor

compiler-errors

};
FulfillmentErrorCode::Select(SelectionError::ConstArgHasWrongType {
ct,
ct_ty,

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be convenient if the selection error didn't have to store the const type, but if we re-derived it in the error reporting code.

@lcnr

@bors

📌 Commit 5922599 has been approved by lcnr

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

and removed S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

labels

Jan 6, 2025

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request

Jan 6, 2025

@matthiaskrgr

…-err, r=lcnr

Report correct SelectionError for ConstArgHasType in new solver fulfill

r? @BoxyUwU

bors added a commit to rust-lang-ci/rust that referenced this pull request

Jan 6, 2025

@bors

…iaskrgr

Rollup of 4 pull requests

Successful merges:

r? @ghost @rustbot modify labels: rollup

bors added a commit to rust-lang-ci/rust that referenced this pull request

Jan 6, 2025

@bors

Rollup of 7 pull requests

Successful merges:

r? @ghost @rustbot modify labels: rollup

bors added a commit to rust-lang-ci/rust that referenced this pull request

Jan 6, 2025

@bors

…iaskrgr

Rollup of 7 pull requests

Successful merges:

r? @ghost @rustbot modify labels: rollup

rust-timer added a commit to rust-lang-ci/rust that referenced this pull request

Jan 7, 2025

@rust-timer

Rollup merge of rust-lang#134771 - compiler-errors:const-arg-has-type-err, r=lcnr

Report correct SelectionError for ConstArgHasType in new solver fulfill

r? @BoxyUwU

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request

Jan 14, 2025

@matthiaskrgr

…r=lcnr

Make sure we can produce ConstArgHasWrongType errors for valtree consts

I forgot about ty::ConstKind::Value in rust-lang#134771.

The error message here could use some work -- both in the new trait solver and the old trait solver. But unrelated to the issue here.

Fixes rust-lang#135361 -- this was only ICEing in coherence because coherence uses the new trait solver, but I don't think the minimization is worth committing compared to the test I added.

r? @lcnr or @BoxyUwU

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request

Jan 14, 2025

@matthiaskrgr

…r=lcnr

Make sure we can produce ConstArgHasWrongType errors for valtree consts

I forgot about ty::ConstKind::Value in rust-lang#134771.

The error message here could use some work -- both in the new trait solver and the old trait solver. But unrelated to the issue here.

Fixes rust-lang#135361 -- this was only ICEing in coherence because coherence uses the new trait solver, but I don't think the minimization is worth committing compared to the test I added.

r? @lcnr or @BoxyUwU

workingjubilee added a commit to workingjubilee/rustc that referenced this pull request

Jan 15, 2025

@workingjubilee

…r=lcnr

Make sure we can produce ConstArgHasWrongType errors for valtree consts

I forgot about ty::ConstKind::Value in rust-lang#134771.

The error message here could use some work -- both in the new trait solver and the old trait solver. But unrelated to the issue here.

Fixes rust-lang#135361 -- this was only ICEing in coherence because coherence uses the new trait solver, but I don't think the minimization is worth committing compared to the test I added.

r? @lcnr or @BoxyUwU

rust-timer added a commit to rust-lang-ci/rust that referenced this pull request

Jan 15, 2025

@rust-timer

Rollup merge of rust-lang#135380 - compiler-errors:mismatch-valtree, r=lcnr

Make sure we can produce ConstArgHasWrongType errors for valtree consts

I forgot about ty::ConstKind::Value in rust-lang#134771.

The error message here could use some work -- both in the new trait solver and the old trait solver. But unrelated to the issue here.

Fixes rust-lang#135361 -- this was only ICEing in coherence because coherence uses the new trait solver, but I don't think the minimization is worth committing compared to the test I added.

r? @lcnr or @BoxyUwU

Labels

S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

T-compiler

Relevant to the compiler team, which will review and decide on the PR/issue.

WG-trait-system-refactor

The Rustc Trait System Refactor Initiative (-Znext-solver)