Make sure we can produce ConstArgHasWrongType errors for valtree consts by compiler-errors · Pull Request #135380 · rust-lang/rust (original) (raw)
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation5 Commits1 Checks6 Files changed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
I forgot about ty::ConstKind::Value in #134771.
The error message here could use some work -- both in the new trait solver and the old trait solver. But unrelated to the issue here.
Fixes #135361 -- this was only ICEing in coherence because coherence uses the new trait solver, but I don't think the minimization is worth committing compared to the test I added.
Some changes occurred to the core trait solver
cc @rust-lang/initiative-trait-system-refactor
Contributor
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pls add that fixme, after that r=me
📌 Commit 516a933 has been approved by lcnr
It is now in the queue for this repository.
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request
…r=lcnr
Make sure we can produce ConstArgHasWrongType errors for valtree consts
I forgot about ty::ConstKind::Value in rust-lang#134771.
The error message here could use some work -- both in the new trait solver and the old trait solver. But unrelated to the issue here.
Fixes rust-lang#135361 -- this was only ICEing in coherence because coherence uses the new trait solver, but I don't think the minimization is worth committing compared to the test I added.
r? @lcnr or @BoxyUwU
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request
…r=lcnr
Make sure we can produce ConstArgHasWrongType errors for valtree consts
I forgot about ty::ConstKind::Value in rust-lang#134771.
The error message here could use some work -- both in the new trait solver and the old trait solver. But unrelated to the issue here.
Fixes rust-lang#135361 -- this was only ICEing in coherence because coherence uses the new trait solver, but I don't think the minimization is worth committing compared to the test I added.
r? @lcnr or @BoxyUwU
bors added a commit to rust-lang-ci/rust that referenced this pull request
…iaskrgr
Rollup of 7 pull requests
Successful merges:
- rust-lang#134940 (Make sure to scrape region constraints from deeply normalizing type outlives assumptions in borrowck)
- rust-lang#135047 (Add gpu-kernel calling convention)
- rust-lang#135228 (Improve
DispatchFromDynandCoerceUnsizedimpl validation) - rust-lang#135264 (Consider more erroneous layouts as
LayoutError::ReferencesErrorto suppress spurious errors) - rust-lang#135302 (for purely return-type based searches, deprioritize clone-like functions)
- rust-lang#135380 (Make sure we can produce
ConstArgHasWrongTypeerrors for valtree consts) - rust-lang#135425 (Do not consider traits that have unsatisfied const conditions to be conditionally const)
r? @ghost
@rustbot modify labels: rollup
bors added a commit to rust-lang-ci/rust that referenced this pull request
…kingjubilee
Rollup of 11 pull requests
Successful merges:
- rust-lang#134913 (bootstrap: do not rely on LIBRARY_PATH env variable)
- rust-lang#134940 (Make sure to scrape region constraints from deeply normalizing type outlives assumptions in borrowck)
- rust-lang#135228 (Improve
DispatchFromDynandCoerceUnsizedimpl validation) - rust-lang#135264 (Consider more erroneous layouts as
LayoutError::ReferencesErrorto suppress spurious errors) - rust-lang#135302 (for purely return-type based searches, deprioritize clone-like functions)
- rust-lang#135353 (re-add --disable-minification to rustdoc)
- rust-lang#135380 (Make sure we can produce
ConstArgHasWrongTypeerrors for valtree consts) - rust-lang#135423 (Enforce syntactical stability of const traits in HIR)
- rust-lang#135425 (Do not consider traits that have unsatisfied const conditions to be conditionally const)
- rust-lang#135499 (fix underlining of hovered intra-doc links.)
- rust-lang#135505 (Fix clippy lints in rustdoc)
r? @ghost
@rustbot modify labels: rollup
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request
Rollup merge of rust-lang#135380 - compiler-errors:mismatch-valtree, r=lcnr
Make sure we can produce ConstArgHasWrongType errors for valtree consts
I forgot about ty::ConstKind::Value in rust-lang#134771.
The error message here could use some work -- both in the new trait solver and the old trait solver. But unrelated to the issue here.
Fixes rust-lang#135361 -- this was only ICEing in coherence because coherence uses the new trait solver, but I don't think the minimization is worth committing compared to the test I added.
r? @lcnr or @BoxyUwU
Labels
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Relevant to the compiler team, which will review and decide on the PR/issue.
The Rustc Trait System Refactor Initiative (-Znext-solver)