re-add --disable-minification to rustdoc by lolbinarycat · Pull Request #135353 · rust-lang/rust (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation13 Commits3 Checks6 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

this also makes the rust.docs-minification option work as advertised in config.toml

nothing fancy this time, this is intended to be perma-unstable. it's only really here for the benefit of rustdoc devs.

mitegates #135345

It was removed in f9e1f6f.

r? @fmease

rustbot has assigned @fmease.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

rustbot added S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

T-rustdoc

Relevant to the rustdoc team, which will review and decide on the PR/issue.

labels

Jan 11, 2025

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

fmease added S-waiting-on-author

Status: This is awaiting some action (such as code changes or more information) from the author.

and removed S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

labels

Jan 11, 2025

this also makes the rust.docs-minification option work as advertised in config.toml

nothing fancy this time, this is intended to be perma-unstable. it's only really here for the benefit of rustdoc devs.

mitegates rust-lang#135345

This PR modifies tests/run-make/. If this PR is trying to port a Makefile
run-make test to use rmake.rs, please update the
run-make port tracking issue
so we can track our progress. You can either modify the tracking issue
directly, or you can comment on the tracking issue and link this PR.

cc @jieyouxu

fmease linked an issue

Jan 11, 2025

that may beclosed by this pull request

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The rustdoc team discussed about it in the last zulip meeting and agreed with this re-add.

One thing though: please add a disclaimer to the flag help message to mention it's perma unstable.

yeah, and the disclaimer should also say that it shouldn't be used with services that cache, like docs.rs

This comment has been minimized.

rustbot added S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

and removed S-waiting-on-author

Status: This is awaiting some action (such as code changes or more information) from the author.

labels

Jan 14, 2025

📌 Commit f5e23d5 has been approved by notriddle

It is now in the queue for this repository.

bors added S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

and removed S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

labels

Jan 14, 2025

bors added a commit to rust-lang-ci/rust that referenced this pull request

Jan 15, 2025

…kingjubilee

Rollup of 11 pull requests

Successful merges:

• rust-lang#134913 (bootstrap: do not rely on LIBRARY_PATH env variable)
• rust-lang#134940 (Make sure to scrape region constraints from deeply normalizing type outlives assumptions in borrowck)
• rust-lang#135228 (Improve DispatchFromDyn and CoerceUnsized impl validation)
• rust-lang#135264 (Consider more erroneous layouts as LayoutError::ReferencesError to suppress spurious errors)
• rust-lang#135302 (for purely return-type based searches, deprioritize clone-like functions)
• rust-lang#135353 (re-add --disable-minification to rustdoc)
• rust-lang#135380 (Make sure we can produce ConstArgHasWrongType errors for valtree consts)
• rust-lang#135423 (Enforce syntactical stability of const traits in HIR)
• rust-lang#135425 (Do not consider traits that have unsatisfied const conditions to be conditionally const)
• rust-lang#135499 (fix underlining of hovered intra-doc links.)
• rust-lang#135505 (Fix clippy lints in rustdoc)

r? @ghost @rustbot modify labels: rollup

rust-timer added a commit to rust-lang-ci/rust that referenced this pull request

Jan 15, 2025

Rollup merge of rust-lang#135353 - lolbinarycat:rustdoc-disable-minification, r=notriddle

re-add --disable-minification to rustdoc

this also makes the rust.docs-minification option work as advertised in config.toml

nothing fancy this time, this is intended to be perma-unstable. it's only really here for the benefit of rustdoc devs.

mitegates rust-lang#135345

It was removed in rust-lang@f9e1f6f.

This was referenced

Feb 20, 2025

Labels

A-run-make

Area: port run-make Makefiles to rmake.rs

S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

T-rustdoc

Relevant to the rustdoc team, which will review and decide on the PR/issue.