Add debug assertions to compiler profile by Noratrieb · Pull Request #135729 · rust-lang/rust (original) (raw)
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation7 Commits1 Checks6 Files changed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
Working on the compiler without debug assertions is not a very productive way to work on the compiler.
r? @onur-ozkan
rustbot has assigned @onur-ozkan.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.
Use r? to explicitly pick a reviewer
Status: Awaiting review from the assignee but also interested parties.
Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
labels
This PR modifies src/bootstrap/defaults.
If appropriate, please update CONFIG_CHANGE_HISTORY in src/bootstrap/src/utils/change_tracker.rs.
Relevant to the compiler team, which will review and decide on the PR/issue.
label
Looks good to me. How about also adding a ChangeSeverity::Info to the CONFIG_CHANGE_HISTORY to have a tiny message notifying people that this is happening?
Working on the compiler without debug assertions is not a very productive way to work on the compiler.
great, thank you!
@bors r+
📌 Commit 2e69bd2 has been approved by lqd
It is now in the queue for this repository.
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request
…ssert, r=lqd
Add debug assertions to compiler profile
Working on the compiler without debug assertions is not a very productive way to work on the compiler.
bors added a commit to rust-lang-ci/rust that referenced this pull request
…llaumeGomez
Rollup of 6 pull requests
Successful merges:
- rust-lang#135446 (further improve panic_immediate_abort by removing rtprintpanic! messages)
- rust-lang#135491 (Remove dead rustc_allowed_through_unstable_modules for std::os::fd contents)
- rust-lang#135542 (Add the concrete syntax for precise capturing to 1.82 release notes.)
- rust-lang#135722 (make it possible to use ci-rustc on tarball sources)
- rust-lang#135729 (Add debug assertions to compiler profile)
- rust-lang#135736 (rustdoc: Fix flaky doctest test)
r? @ghost
@rustbot modify labels: rollup
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request
…ssert, r=lqd
Add debug assertions to compiler profile
Working on the compiler without debug assertions is not a very productive way to work on the compiler.
bors added a commit to rust-lang-ci/rust that referenced this pull request
…llaumeGomez
Rollup of 8 pull requests
Successful merges:
- rust-lang#135310 (Always force non-trimming of path in
unreachable_patternslint) - rust-lang#135446 (further improve panic_immediate_abort by removing rtprintpanic! messages)
- rust-lang#135491 (Remove dead rustc_allowed_through_unstable_modules for std::os::fd contents)
- rust-lang#135542 (Add the concrete syntax for precise capturing to 1.82 release notes.)
- rust-lang#135700 (Emit single privacy error for struct literal with multiple private fields and add test for
default_field_valuesprivacy) - rust-lang#135729 (Add debug assertions to compiler profile)
- rust-lang#135736 (rustdoc: Fix flaky doctest test)
- rust-lang#135738 (Replace usages of
map_or(bool, ...)withis_{some_and|none_or|ok_and})
r? @ghost
@rustbot modify labels: rollup
bors added a commit to rust-lang-ci/rust that referenced this pull request
Rollup of 7 pull requests
Successful merges:
- rust-lang#135542 (Add the concrete syntax for precise capturing to 1.82 release notes.)
- rust-lang#135700 (Emit single privacy error for struct literal with multiple private fields and add test for
default_field_valuesprivacy) - rust-lang#135722 (make it possible to use ci-rustc on tarball sources)
- rust-lang#135729 (Add debug assertions to compiler profile)
- rust-lang#135736 (rustdoc: Fix flaky doctest test)
- rust-lang#135738 (Replace usages of
map_or(bool, ...)withis_{some_and|none_or|ok_and}) - rust-lang#135747 (Rename FileName::QuoteExpansion to CfgSpec)
r? @ghost
@rustbot modify labels: rollup
bors added a commit to rust-lang-ci/rust that referenced this pull request
Rollup of 7 pull requests
Successful merges:
- rust-lang#135542 (Add the concrete syntax for precise capturing to 1.82 release notes.)
- rust-lang#135700 (Emit single privacy error for struct literal with multiple private fields and add test for
default_field_valuesprivacy) - rust-lang#135722 (make it possible to use ci-rustc on tarball sources)
- rust-lang#135729 (Add debug assertions to compiler profile)
- rust-lang#135736 (rustdoc: Fix flaky doctest test)
- rust-lang#135738 (Replace usages of
map_or(bool, ...)withis_{some_and|none_or|ok_and}) - rust-lang#135747 (Rename FileName::QuoteExpansion to CfgSpec)
r? @ghost
@rustbot modify labels: rollup
bors added a commit to rust-lang-ci/rust that referenced this pull request
Rollup of 7 pull requests
Successful merges:
- rust-lang#135542 (Add the concrete syntax for precise capturing to 1.82 release notes.)
- rust-lang#135700 (Emit single privacy error for struct literal with multiple private fields and add test for
default_field_valuesprivacy) - rust-lang#135722 (make it possible to use ci-rustc on tarball sources)
- rust-lang#135729 (Add debug assertions to compiler profile)
- rust-lang#135736 (rustdoc: Fix flaky doctest test)
- rust-lang#135738 (Replace usages of
map_or(bool, ...)withis_{some_and|none_or|ok_and}) - rust-lang#135747 (Rename FileName::QuoteExpansion to CfgSpec)
r? @ghost
@rustbot modify labels: rollup
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request
Rollup merge of rust-lang#135729 - Noratrieb:compiler-profile-debug-assert, r=lqd
Add debug assertions to compiler profile
Working on the compiler without debug assertions is not a very productive way to work on the compiler.
Labels
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Relevant to the compiler team, which will review and decide on the PR/issue.