make it possible to use ci-rustc on tarball sources by onur-ozkan · Pull Request #135722 · rust-lang/rust (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation11 Commits1 Checks6 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

onur-ozkan

Previously, bootstrap was using Config::last_modified_commit unconditionally to figure the commit to download precompiled rustc artifact from CI, which was leading builds to fail on tarball sources as Config::last_modified_commit requires git to be present in the project source. This change makes bootstrap to call Config::last_modified_commit only when it's running on git-managed source and read git-commit-hash file otherwise.

@rustbot

r? @clubby789

rustbot has assigned @clubby789.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

T-bootstrap

Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

labels

Jan 19, 2025

@rustbot

This PR modifies src/bootstrap/src/core/config.

If appropriate, please update CONFIG_CHANGE_HISTORY in src/bootstrap/src/utils/change_tracker.rs.

@onur-ozkan

Previously, bootstrap was using Config::last_modified_commit unconditionally to figure the commit has to download precompiled rustc artifact from CI, which was leading builds to fail on tarball sources as Config::last_modified_commit requires git to be present in the project source. This change makes bootstrap to call Config::last_modified_commit only when it's running on git-managed source and read git-commit-hash file otherwise.

Signed-off-by: onur-ozkan work@onurozkan.dev

jieyouxu

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, thanks

@jieyouxu

@bors

📌 Commit 903cddb has been approved by jieyouxu

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

and removed S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

labels

Jan 19, 2025

GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request

Jan 19, 2025

@GuillaumeGomez

…t, r=jieyouxu

make it possible to use ci-rustc on tarball sources

Previously, bootstrap was using Config::last_modified_commit unconditionally to figure the commit to download precompiled rustc artifact from CI, which was leading builds to fail on tarball sources as Config::last_modified_commit requires git to be present in the project source. This change makes bootstrap to call Config::last_modified_commit only when it's running on git-managed source and read git-commit-hash file otherwise.

bors added a commit to rust-lang-ci/rust that referenced this pull request

Jan 19, 2025

@bors

…llaumeGomez

Rollup of 6 pull requests

Successful merges:

r? @ghost @rustbot modify labels: rollup

@GuillaumeGomez

@bors bors added S-waiting-on-author

Status: This is awaiting some action (such as code changes or more information) from the author.

and removed S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

labels

Jan 19, 2025

@clubby789 

     Compiling rustc_driver v0.0.0 (C:\a\rust\rust\compiler\rustc_driver)
  [RUSTC-TIMING] rustc_driver test:false 4.821
  [RUSTC-TIMING] rustc_main test:false 0.448
  error: failed to remove file `C:\a\rust\rust\build\x86_64-pc-windows-msvc\stage1-rustc\x86_64-pc-windows-msvc\release\rustc-main.exe`
  
  Caused by:
    Access is denied. (os error 5)

This is just the usual spurious MSVC right?

@ChrisDenton

@bors

📌 Commit 903cddb has been approved by jieyouxu

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

and removed S-waiting-on-author

Status: This is awaiting some action (such as code changes or more information) from the author.

labels

Jan 19, 2025

bors added a commit to rust-lang-ci/rust that referenced this pull request

Jan 20, 2025

@bors

Rollup of 7 pull requests

Successful merges:

r? @ghost @rustbot modify labels: rollup

bors added a commit to rust-lang-ci/rust that referenced this pull request

Jan 20, 2025

@bors

Rollup of 7 pull requests

Successful merges:

r? @ghost @rustbot modify labels: rollup

bors added a commit to rust-lang-ci/rust that referenced this pull request

Jan 20, 2025

@bors

Rollup of 7 pull requests

Successful merges:

r? @ghost @rustbot modify labels: rollup

rust-timer added a commit to rust-lang-ci/rust that referenced this pull request

Jan 20, 2025

@rust-timer

Rollup merge of rust-lang#135722 - onur-ozkan:handle-tarball-ci-commit, r=jieyouxu

make it possible to use ci-rustc on tarball sources

Previously, bootstrap was using Config::last_modified_commit unconditionally to figure the commit to download precompiled rustc artifact from CI, which was leading builds to fail on tarball sources as Config::last_modified_commit requires git to be present in the project source. This change makes bootstrap to call Config::last_modified_commit only when it's running on git-managed source and read git-commit-hash file otherwise.

@onur-ozkan

@rustbot label +stable-nominated +beta-nominated

@onur-ozkan

bors added a commit to rust-lang-ci/rust that referenced this pull request

Jan 24, 2025

@bors

bors added a commit to rust-lang-ci/rust that referenced this pull request

Jan 25, 2025

@bors

bors added a commit to rust-lang-ci/rust that referenced this pull request

Jan 26, 2025

@bors

bors added a commit to rust-lang-ci/rust that referenced this pull request

Jan 27, 2025

@bors

[stable] Prepare Rust 1.84.1 point release

cc @rust-lang/release r? ghost

wip-sync pushed a commit to NetBSD/pkgsrc-wip that referenced this pull request

Feb 2, 2025

@he32

Pkgsrc changes:

Upstream changes:

Version 1.84.1 (2025-01-30)

Version 1.84.0 (2025-01-09)

Language

Compiler

Libraries

Stabilized APIs

These APIs are now stable in const contexts

Cargo

Rustdoc

Compatibility Notes

tmeijn pushed a commit to tmeijn/dotfiles that referenced this pull request

Feb 4, 2025

@tmeijn

This MR contains the following updates:

Package Update Change
rust patch 1.84.0 -> 1.84.1

MR created with the help of el-capitano/tools/renovate-bot.

Proposed changes to behavior should be submitted there as MRs.

Release Notes

rust-lang/rust (rust)

v1.84.1

Compare Source

==========================

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻ Rebasing: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this MR and you won't be reminded about this update again.

This MR has been generated by Renovate Bot.

Labels

beta-accepted

Accepted for backporting to the compiler in the beta channel.

S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

stable-accepted

Accepted for backporting to the compiler in the stable channel.

T-bootstrap

Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)