Implement &pin const self and &pin mut self sugars by frank-king · Pull Request #135733 · rust-lang/rust (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation31 Commits3 Checks6 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

This PR implements part of #130494.

It introduces the sugars &pin const self and &pin mut self for self: Pin<&Self> and self: Pin<&mut Self>.

r? @oli-obk

rustbot has assigned @oli-obk.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

rustbot added S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

T-compiler

Relevant to the compiler team, which will review and decide on the PR/issue.

labels

Jan 19, 2025

Some changes occurred in src/tools/rustfmt

cc @rust-lang/rustfmt

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add tests to ensure that this sugar is not usable in #[cfg]'d out code.

oli-obk added S-waiting-on-author

Status: This is awaiting some action (such as code changes or more information) from the author.

and removed S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

labels

Jan 20, 2025

These changes are more likely to conflict with someone's macro_rules macro out there, so we should probably crater it, too. If there is too much breakage we may hold up on adding this syntax and start with a builtin macro expanding to the same ast nodes that you introduced.

Should I trigger the crater via rustbot or run it locally?

bors added a commit to rust-lang-ci/rust that referenced this pull request

Feb 15, 2025

…, r=

Implement &pin const self and &pin mut self sugars

This PR implements part of rust-lang#130494.

It introduces the sugars &pin const self and &pin mut self for self: Pin<&Self> and self: Pin<&mut Self>.

☀️ Try build successful - checks-actions
Build commit: f3dc08d (f3dc08d20a1589b87bde75bb82ee6423307f9bde)

🚧 Experiment pr-135733 is now running

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

These changes are more likely to conflict with someone's macro_rules macro out there, so we should probably crater it, too. If there is too much breakage we may hold up on adding this syntax and start with a builtin macro expanding to the same ast nodes that you introduced.

Great, no one was doing this in crates. Bin crates may still do it but it should be super rare.

Let's ship it

📌 Commit 50d0f99 has been approved by oli-obk

It is now in the queue for this repository.

bors added S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

and removed S-waiting-on-author

Status: This is awaiting some action (such as code changes or more information) from the author.

labels

Mar 5, 2025

jieyouxu added a commit to jieyouxu/rust that referenced this pull request

Mar 5, 2025

…er, r=oli-obk

Implement &pin const self and &pin mut self sugars

This PR implements part of rust-lang#130494.

It introduces the sugars &pin const self and &pin mut self for self: Pin<&Self> and self: Pin<&mut Self>.

bors added a commit to rust-lang-ci/rust that referenced this pull request

Mar 5, 2025

jieyouxu added a commit to jieyouxu/rust that referenced this pull request

Mar 5, 2025

…er, r=oli-obk

Implement &pin const self and &pin mut self sugars

This PR implements part of rust-lang#130494.

It introduces the sugars &pin const self and &pin mut self for self: Pin<&Self> and self: Pin<&mut Self>.

bors added S-waiting-on-author

Status: This is awaiting some action (such as code changes or more information) from the author.

and removed S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

labels

Mar 6, 2025

@bors r=oli-obk,traviscross

To share in any blame here.

📌 Commit 50d0f99 has been approved by oli-obk,traviscross

It is now in the queue for this repository.

bors added S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

and removed S-waiting-on-author

Status: This is awaiting some action (such as code changes or more information) from the author.

labels

Mar 6, 2025

Noratrieb added a commit to Noratrieb/rust that referenced this pull request

Mar 6, 2025

…er, r=oli-obk,traviscross

Implement &pin const self and &pin mut self sugars

This PR implements part of rust-lang#130494.

It introduces the sugars &pin const self and &pin mut self for self: Pin<&Self> and self: Pin<&mut Self>.

bors added a commit to rust-lang-ci/rust that referenced this pull request

Mar 6, 2025

…mpiler-errors

Rollup of 25 pull requests

Successful merges:

• rust-lang#135733 (Implement &pin const self and &pin mut self sugars)
• rust-lang#135895 (Document workings of successors more clearly)
• rust-lang#136922 (Pattern types: Avoid having to handle an Option for range ends in the type system or the HIR)
• rust-lang#137303 (Remove MaybeForgetReturn suggestion)
• rust-lang#137327 (Undeprecate env::home_dir)
• rust-lang#137358 (Match Ergonomics 2024: add context and examples to the unstable book)
• rust-lang#137534 ([rustdoc] hide item that is not marked as doc(inline) and whose src is doc(hidden))
• rust-lang#137565 (Try to point of macro expansion from resolver and method errors if it involves macro var)
• rust-lang#137637 (Check dyn flavor before registering upcast goal on wide pointer cast in MIR typeck)
• rust-lang#137643 (Add DWARF test case for non-C-like repr128 enums)
• rust-lang#137744 (Re-add Clone-derive on Thir)
• rust-lang#137758 (fix usage of ty decl macro fragments in attributes)
• rust-lang#137764 (Ensure that negative auto impls are always applicable)
• rust-lang#137772 (Fix char count in Display for ByteStr)
• rust-lang#137798 (ci: use ubuntu 24 on arm large runner)
• rust-lang#137802 (miri native-call support: all previously exposed provenance is accessible to the callee)
• rust-lang#137805 (adjust Layout debug printing to match the internal field name)
• rust-lang#137808 (Do not require that unsafe fields lack drop glue)
• rust-lang#137820 (Clarify why InhabitedPredicate::instantiate_opt exists)
• rust-lang#137825 (Provide more context on resolve error caused from incorrect RTN)
• rust-lang#137834 (rustc_fluent_macro: use CARGO_CRATE_NAME instead of CARGO_PKG_NAME)
• rust-lang#137868 (Add minimal platform support documentation for powerpc-unknown-linux-gnuspe)
• rust-lang#137910 (Improve error message for AsyncFn trait failure for RPIT)
• rust-lang#137920 (interpret/provenance_map: consistently use range_is_empty)
• rust-lang#138038 (Update compiler-builtins to 0.1.151)

r? @ghost @rustbot modify labels: rollup

bors added a commit to rust-lang-ci/rust that referenced this pull request

Mar 6, 2025

…mpiler-errors

Rollup of 25 pull requests

Successful merges:

• rust-lang#135733 (Implement &pin const self and &pin mut self sugars)
• rust-lang#135895 (Document workings of successors more clearly)
• rust-lang#136922 (Pattern types: Avoid having to handle an Option for range ends in the type system or the HIR)
• rust-lang#137303 (Remove MaybeForgetReturn suggestion)
• rust-lang#137327 (Undeprecate env::home_dir)
• rust-lang#137358 (Match Ergonomics 2024: add context and examples to the unstable book)
• rust-lang#137534 ([rustdoc] hide item that is not marked as doc(inline) and whose src is doc(hidden))
• rust-lang#137565 (Try to point of macro expansion from resolver and method errors if it involves macro var)
• rust-lang#137637 (Check dyn flavor before registering upcast goal on wide pointer cast in MIR typeck)
• rust-lang#137643 (Add DWARF test case for non-C-like repr128 enums)
• rust-lang#137744 (Re-add Clone-derive on Thir)
• rust-lang#137758 (fix usage of ty decl macro fragments in attributes)
• rust-lang#137764 (Ensure that negative auto impls are always applicable)
• rust-lang#137772 (Fix char count in Display for ByteStr)
• rust-lang#137798 (ci: use ubuntu 24 on arm large runner)
• rust-lang#137802 (miri native-call support: all previously exposed provenance is accessible to the callee)
• rust-lang#137805 (adjust Layout debug printing to match the internal field name)
• rust-lang#137808 (Do not require that unsafe fields lack drop glue)
• rust-lang#137820 (Clarify why InhabitedPredicate::instantiate_opt exists)
• rust-lang#137825 (Provide more context on resolve error caused from incorrect RTN)
• rust-lang#137834 (rustc_fluent_macro: use CARGO_CRATE_NAME instead of CARGO_PKG_NAME)
• rust-lang#137868 (Add minimal platform support documentation for powerpc-unknown-linux-gnuspe)
• rust-lang#137910 (Improve error message for AsyncFn trait failure for RPIT)
• rust-lang#137920 (interpret/provenance_map: consistently use range_is_empty)
• rust-lang#138038 (Update compiler-builtins to 0.1.151)

r? @ghost @rustbot modify labels: rollup

rust-timer added a commit to rust-lang-ci/rust that referenced this pull request

Mar 7, 2025

Rollup merge of rust-lang#135733 - frank-king:feature/pin-self-receiver, r=oli-obk,traviscross

Implement &pin const self and &pin mut self sugars

This PR implements part of rust-lang#130494.

It introduces the sugars &pin const self and &pin mut self for self: Pin<&Self> and self: Pin<&mut Self>.

github-actions bot pushed a commit to model-checking/verify-rust-std that referenced this pull request

Mar 14, 2025

…mpiler-errors

Rollup of 25 pull requests

Successful merges:

• rust-lang#135733 (Implement &pin const self and &pin mut self sugars)
• rust-lang#135895 (Document workings of successors more clearly)
• rust-lang#136922 (Pattern types: Avoid having to handle an Option for range ends in the type system or the HIR)
• rust-lang#137303 (Remove MaybeForgetReturn suggestion)
• rust-lang#137327 (Undeprecate env::home_dir)
• rust-lang#137358 (Match Ergonomics 2024: add context and examples to the unstable book)
• rust-lang#137534 ([rustdoc] hide item that is not marked as doc(inline) and whose src is doc(hidden))
• rust-lang#137565 (Try to point of macro expansion from resolver and method errors if it involves macro var)
• rust-lang#137637 (Check dyn flavor before registering upcast goal on wide pointer cast in MIR typeck)
• rust-lang#137643 (Add DWARF test case for non-C-like repr128 enums)
• rust-lang#137744 (Re-add Clone-derive on Thir)
• rust-lang#137758 (fix usage of ty decl macro fragments in attributes)
• rust-lang#137764 (Ensure that negative auto impls are always applicable)
• rust-lang#137772 (Fix char count in Display for ByteStr)
• rust-lang#137798 (ci: use ubuntu 24 on arm large runner)
• rust-lang#137802 (miri native-call support: all previously exposed provenance is accessible to the callee)
• rust-lang#137805 (adjust Layout debug printing to match the internal field name)
• rust-lang#137808 (Do not require that unsafe fields lack drop glue)
• rust-lang#137820 (Clarify why InhabitedPredicate::instantiate_opt exists)
• rust-lang#137825 (Provide more context on resolve error caused from incorrect RTN)
• rust-lang#137834 (rustc_fluent_macro: use CARGO_CRATE_NAME instead of CARGO_PKG_NAME)
• rust-lang#137868 (Add minimal platform support documentation for powerpc-unknown-linux-gnuspe)
• rust-lang#137910 (Improve error message for AsyncFn trait failure for RPIT)
• rust-lang#137920 (interpret/provenance_map: consistently use range_is_empty)
• rust-lang#138038 (Update compiler-builtins to 0.1.151)

r? @ghost @rustbot modify labels: rollup

Labels

S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

T-compiler

Relevant to the compiler team, which will review and decide on the PR/issue.