fix usage of ty decl macro fragments in attributes by jdonszelmann · Pull Request #137758 · rust-lang/rust (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation8 Commits1 Checks6 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

jdonszelmann

See the test case. Due to one missing code path (and also the changes in #137517), using tyorotherspecificfragmentsaspartofanattrwouldn′twork.ty or other specific fragments as part of an attr wouldn't work. tyorotherspecificfragmentsaspartofanattrwouldntwork.tt used to work since it wouldn't be parsed anywhere along the way.

Closes #137662

@rustbot

r? @cjgillot

rustbot has assigned @cjgillot.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added A-attributes

Area: Attributes (`#[…]`, `#![…]`)

S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

T-compiler

Relevant to the compiler team, which will review and decide on the PR/issue.

labels

Feb 27, 2025

@tgross35

Would you mind updating the title / commit message to describe what the change is so referencing the issue isn't needed? The test's doc comment should also describe what it is testing, for the same reason.

@compiler-errors

Yeap, I agree with tgross35 here. I know it's a draft PR so no worries if you were planning on editing the title later, but a title like "Account for XXX in YYY so that ZZZ" is a lot more helpful than "fix issue ###" 😺.

@jdonszelmann

That's why it's a draft, it's not ready yet. I made it in 2 minutes before going to bed yesterday evening

@jdonszelmann

@jdonszelmann jdonszelmann changed the titleadd test to reproduce #137662 and fix it fix usage of ty decl macro fragments in attributes

Feb 28, 2025

@jdonszelmann

Ok this is better. I just wanted to see if CI would pass overnight but you were totally right for noticing this PR needed a little more work :)

@jdonszelmann

@nnethercote

@bors

📌 Commit 41dd80a has been approved by nnethercote

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

and removed S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

labels

Mar 2, 2025

tgross35 added a commit to tgross35/rust that referenced this pull request

Mar 3, 2025

@tgross35

…cote

fix usage of ty decl macro fragments in attributes

See the test case. Due to one missing code path (and also the changes in rust-lang#137517), using tyorotherspecificfragmentsaspartofanattrwouldn′twork.ty or other specific fragments as part of an attr wouldn't work. tyorotherspecificfragmentsaspartofanattrwouldntwork.tt used to work since it wouldn't be parsed anywhere along the way.

Closes rust-lang#137662

bors added a commit to rust-lang-ci/rust that referenced this pull request

Mar 3, 2025

@bors

bors added a commit to rust-lang-ci/rust that referenced this pull request

Mar 3, 2025

@bors

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request

Mar 4, 2025

@matthiaskrgr

…cote

fix usage of ty decl macro fragments in attributes

See the test case. Due to one missing code path (and also the changes in rust-lang#137517), using tyorotherspecificfragmentsaspartofanattrwouldn′twork.ty or other specific fragments as part of an attr wouldn't work. tyorotherspecificfragmentsaspartofanattrwouldntwork.tt used to work since it wouldn't be parsed anywhere along the way.

Closes rust-lang#137662

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request

Mar 4, 2025

@matthiaskrgr

…cote

fix usage of ty decl macro fragments in attributes

See the test case. Due to one missing code path (and also the changes in rust-lang#137517), using tyorotherspecificfragmentsaspartofanattrwouldn′twork.ty or other specific fragments as part of an attr wouldn't work. tyorotherspecificfragmentsaspartofanattrwouldntwork.tt used to work since it wouldn't be parsed anywhere along the way.

Closes rust-lang#137662

bors added a commit to rust-lang-ci/rust that referenced this pull request

Mar 4, 2025

@bors

workingjubilee added a commit to workingjubilee/rustc that referenced this pull request

Mar 4, 2025

@workingjubilee

…cote

fix usage of ty decl macro fragments in attributes

See the test case. Due to one missing code path (and also the changes in rust-lang#137517), using tyorotherspecificfragmentsaspartofanattrwouldn′twork.ty or other specific fragments as part of an attr wouldn't work. tyorotherspecificfragmentsaspartofanattrwouldntwork.tt used to work since it wouldn't be parsed anywhere along the way.

Closes rust-lang#137662

workingjubilee added a commit to workingjubilee/rustc that referenced this pull request

Mar 5, 2025

@workingjubilee

…cote

fix usage of ty decl macro fragments in attributes

See the test case. Due to one missing code path (and also the changes in rust-lang#137517), using tyorotherspecificfragmentsaspartofanattrwouldn′twork.ty or other specific fragments as part of an attr wouldn't work. tyorotherspecificfragmentsaspartofanattrwouldntwork.tt used to work since it wouldn't be parsed anywhere along the way.

Closes rust-lang#137662

bors added a commit to rust-lang-ci/rust that referenced this pull request

Mar 5, 2025

@bors

…kingjubilee

Rollup of 20 pull requests

Successful merges:

r? @ghost @rustbot modify labels: rollup

workingjubilee added a commit to workingjubilee/rustc that referenced this pull request

Mar 5, 2025

@workingjubilee

…cote

fix usage of ty decl macro fragments in attributes

See the test case. Due to one missing code path (and also the changes in rust-lang#137517), using tyorotherspecificfragmentsaspartofanattrwouldn′twork.ty or other specific fragments as part of an attr wouldn't work. tyorotherspecificfragmentsaspartofanattrwouldntwork.tt used to work since it wouldn't be parsed anywhere along the way.

Closes rust-lang#137662

bors added a commit to rust-lang-ci/rust that referenced this pull request

Mar 5, 2025

@bors

jieyouxu added a commit to jieyouxu/rust that referenced this pull request

Mar 5, 2025

@jieyouxu

…cote

fix usage of ty decl macro fragments in attributes

See the test case. Due to one missing code path (and also the changes in rust-lang#137517), using tyorotherspecificfragmentsaspartofanattrwouldn′twork.ty or other specific fragments as part of an attr wouldn't work. tyorotherspecificfragmentsaspartofanattrwouldntwork.tt used to work since it wouldn't be parsed anywhere along the way.

Closes rust-lang#137662

bors added a commit to rust-lang-ci/rust that referenced this pull request

Mar 5, 2025

@bors

Rollup of 23 pull requests

Successful merges:

r? @ghost @rustbot modify labels: rollup

jieyouxu added a commit to jieyouxu/rust that referenced this pull request

Mar 5, 2025

@jieyouxu

…cote

fix usage of ty decl macro fragments in attributes

See the test case. Due to one missing code path (and also the changes in rust-lang#137517), using tyorotherspecificfragmentsaspartofanattrwouldn′twork.ty or other specific fragments as part of an attr wouldn't work. tyorotherspecificfragmentsaspartofanattrwouldntwork.tt used to work since it wouldn't be parsed anywhere along the way.

Closes rust-lang#137662

bors added a commit to rust-lang-ci/rust that referenced this pull request

Mar 5, 2025

@bors

jieyouxu added a commit to jieyouxu/rust that referenced this pull request

Mar 5, 2025

@jieyouxu

…cote

fix usage of ty decl macro fragments in attributes

See the test case. Due to one missing code path (and also the changes in rust-lang#137517), using tyorotherspecificfragmentsaspartofanattrwouldn′twork.ty or other specific fragments as part of an attr wouldn't work. tyorotherspecificfragmentsaspartofanattrwouldntwork.tt used to work since it wouldn't be parsed anywhere along the way.

Closes rust-lang#137662

compiler-errors added a commit to compiler-errors/rust that referenced this pull request

Mar 6, 2025

@compiler-errors

…cote

fix usage of ty decl macro fragments in attributes

See the test case. Due to one missing code path (and also the changes in rust-lang#137517), using tyorotherspecificfragmentsaspartofanattrwouldn′twork.ty or other specific fragments as part of an attr wouldn't work. tyorotherspecificfragmentsaspartofanattrwouldntwork.tt used to work since it wouldn't be parsed anywhere along the way.

Closes rust-lang#137662

Noratrieb added a commit to Noratrieb/rust that referenced this pull request

Mar 6, 2025

@Noratrieb

…cote

fix usage of ty decl macro fragments in attributes

See the test case. Due to one missing code path (and also the changes in rust-lang#137517), using tyorotherspecificfragmentsaspartofanattrwouldn′twork.ty or other specific fragments as part of an attr wouldn't work. tyorotherspecificfragmentsaspartofanattrwouldntwork.tt used to work since it wouldn't be parsed anywhere along the way.

Closes rust-lang#137662

Noratrieb added a commit to Noratrieb/rust that referenced this pull request

Mar 6, 2025

@Noratrieb

…compiler-errors

Rollup of 20 pull requests

Successful merges:

r? @ghost @rustbot modify labels: rollup

bors added a commit to rust-lang-ci/rust that referenced this pull request

Mar 6, 2025

@bors

…mpiler-errors

Rollup of 20 pull requests

Successful merges:

r? @ghost @rustbot modify labels: rollup

bors added a commit to rust-lang-ci/rust that referenced this pull request

Mar 6, 2025

@bors

…mpiler-errors

Rollup of 20 pull requests

Successful merges:

r? @ghost @rustbot modify labels: rollup

bors added a commit to rust-lang-ci/rust that referenced this pull request

Mar 6, 2025

@bors

…mpiler-errors

Rollup of 25 pull requests

Successful merges:

r? @ghost @rustbot modify labels: rollup

bors added a commit to rust-lang-ci/rust that referenced this pull request

Mar 6, 2025

@bors

…mpiler-errors

Rollup of 25 pull requests

Successful merges:

r? @ghost @rustbot modify labels: rollup

rust-timer added a commit to rust-lang-ci/rust that referenced this pull request

Mar 7, 2025

@rust-timer

Rollup merge of rust-lang#137758 - jdonszelmann:fix-137662, r=nnethercote

fix usage of ty decl macro fragments in attributes

See the test case. Due to one missing code path (and also the changes in rust-lang#137517), using tyorotherspecificfragmentsaspartofanattrwouldn′twork.ty or other specific fragments as part of an attr wouldn't work. tyorotherspecificfragmentsaspartofanattrwouldntwork.tt used to work since it wouldn't be parsed anywhere along the way.

Closes rust-lang#137662

github-actions bot pushed a commit to model-checking/verify-rust-std that referenced this pull request

Mar 14, 2025

@bors

…mpiler-errors

Rollup of 25 pull requests

Successful merges:

r? @ghost @rustbot modify labels: rollup

Labels

A-attributes

Area: Attributes (`#[…]`, `#![…]`)

S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

T-compiler

Relevant to the compiler team, which will review and decide on the PR/issue.