fix usage of ty decl macro fragments in attributes by jdonszelmann · Pull Request #137758 · rust-lang/rust (original) (raw)
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation8 Commits1 Checks6 Files changed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
See the test case. Due to one missing code path (and also the changes in #137517), using tyorotherspecificfragmentsaspartofanattrwouldn′twork.ty or other specific fragments as part of an attr wouldn't work. tyorotherspecificfragmentsaspartofanattrwouldn′twork.tt used to work since it wouldn't be parsed anywhere along the way.
Closes #137662
r? @cjgillot
rustbot has assigned @cjgillot.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.
Use r?
to explicitly pick a reviewer
rustbot added A-attributes
Area: Attributes (`#[…]`, `#![…]`)
Status: Awaiting review from the assignee but also interested parties.
Relevant to the compiler team, which will review and decide on the PR/issue.
labels
Would you mind updating the title / commit message to describe what the change is so referencing the issue isn't needed? The test's doc comment should also describe what it is testing, for the same reason.
Yeap, I agree with tgross35 here. I know it's a draft PR so no worries if you were planning on editing the title later, but a title like "Account for XXX in YYY so that ZZZ" is a lot more helpful than "fix issue ###" 😺.
That's why it's a draft, it's not ready yet. I made it in 2 minutes before going to bed yesterday evening
jdonszelmann changed the title
add test to reproduce #137662 and fix it fix usage of ty decl macro fragments in attributes
Ok this is better. I just wanted to see if CI would pass overnight but you were totally right for noticing this PR needed a little more work :)
📌 Commit 41dd80a has been approved by nnethercote
It is now in the queue for this repository.
bors added S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
tgross35 added a commit to tgross35/rust that referenced this pull request
…cote
fix usage of ty decl macro fragments in attributes
See the test case. Due to one missing code path (and also the changes in rust-lang#137517), using tyorotherspecificfragmentsaspartofanattrwouldn′twork.ty or other specific fragments as part of an attr wouldn't work. tyorotherspecificfragmentsaspartofanattrwouldn′twork.tt used to work since it wouldn't be parsed anywhere along the way.
Closes rust-lang#137662
bors added a commit to rust-lang-ci/rust that referenced this pull request
bors added a commit to rust-lang-ci/rust that referenced this pull request
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request
…cote
fix usage of ty decl macro fragments in attributes
See the test case. Due to one missing code path (and also the changes in rust-lang#137517), using tyorotherspecificfragmentsaspartofanattrwouldn′twork.ty or other specific fragments as part of an attr wouldn't work. tyorotherspecificfragmentsaspartofanattrwouldn′twork.tt used to work since it wouldn't be parsed anywhere along the way.
Closes rust-lang#137662
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request
…cote
fix usage of ty decl macro fragments in attributes
See the test case. Due to one missing code path (and also the changes in rust-lang#137517), using tyorotherspecificfragmentsaspartofanattrwouldn′twork.ty or other specific fragments as part of an attr wouldn't work. tyorotherspecificfragmentsaspartofanattrwouldn′twork.tt used to work since it wouldn't be parsed anywhere along the way.
Closes rust-lang#137662
bors added a commit to rust-lang-ci/rust that referenced this pull request
workingjubilee added a commit to workingjubilee/rustc that referenced this pull request
…cote
fix usage of ty decl macro fragments in attributes
See the test case. Due to one missing code path (and also the changes in rust-lang#137517), using tyorotherspecificfragmentsaspartofanattrwouldn′twork.ty or other specific fragments as part of an attr wouldn't work. tyorotherspecificfragmentsaspartofanattrwouldn′twork.tt used to work since it wouldn't be parsed anywhere along the way.
Closes rust-lang#137662
workingjubilee added a commit to workingjubilee/rustc that referenced this pull request
…cote
fix usage of ty decl macro fragments in attributes
See the test case. Due to one missing code path (and also the changes in rust-lang#137517), using tyorotherspecificfragmentsaspartofanattrwouldn′twork.ty or other specific fragments as part of an attr wouldn't work. tyorotherspecificfragmentsaspartofanattrwouldn′twork.tt used to work since it wouldn't be parsed anywhere along the way.
Closes rust-lang#137662
bors added a commit to rust-lang-ci/rust that referenced this pull request
…kingjubilee
Rollup of 20 pull requests
Successful merges:
- rust-lang#136581 (Retire the legacy
Makefile
-basedrun-make
test infra) - rust-lang#136764 (Make
ptr_cast_add_auto_to_object
lint into hard error) - rust-lang#136798 (Added documentation for flushing per rust-lang#74348)
- rust-lang#136865 (Perform deeper compiletest path normalization for
$TEST_BUILD_DIR
to account for compare-mode/debugger cases, and normalize long type file filename hashes) - rust-lang#136975 (Look for
python3
first on MacOS, notpy
) - rust-lang#137240 (Slightly reformat
std::fs::remove_dir_all
error docs) - rust-lang#137303 (Remove
MaybeForgetReturn
suggestion) - rust-lang#137327 (Undeprecate env::home_dir)
- rust-lang#137502 (Don't include global asm in
mir_keys
, fix error body synthesis) - rust-lang#137534 ([rustdoc] hide item that is not marked as doc(inline) and whose src is doc(hidden))
- rust-lang#137565 (Try to point of macro expansion from resolver and method errors if it involves macro var)
- rust-lang#137643 (Add DWARF test case for non-C-like
repr128
enums) - rust-lang#137758 (fix usage of ty decl macro fragments in attributes)
- rust-lang#137764 (Ensure that negative auto impls are always applicable)
- rust-lang#137772 (Fix char count in
Display
forByteStr
) - rust-lang#137798 (ci: use ubuntu 24 on arm large runner)
- rust-lang#137805 (adjust Layout debug printing to match the internal field name)
- rust-lang#137808 (Do not require that unsafe fields lack drop glue)
- rust-lang#137820 (Clarify why InhabitedPredicate::instantiate_opt exists)
- rust-lang#137825 (Provide more context on resolve error caused from incorrect RTN)
r? @ghost
@rustbot
modify labels: rollup
workingjubilee added a commit to workingjubilee/rustc that referenced this pull request
…cote
fix usage of ty decl macro fragments in attributes
See the test case. Due to one missing code path (and also the changes in rust-lang#137517), using tyorotherspecificfragmentsaspartofanattrwouldn′twork.ty or other specific fragments as part of an attr wouldn't work. tyorotherspecificfragmentsaspartofanattrwouldn′twork.tt used to work since it wouldn't be parsed anywhere along the way.
Closes rust-lang#137662
bors added a commit to rust-lang-ci/rust that referenced this pull request
jieyouxu added a commit to jieyouxu/rust that referenced this pull request
…cote
fix usage of ty decl macro fragments in attributes
See the test case. Due to one missing code path (and also the changes in rust-lang#137517), using tyorotherspecificfragmentsaspartofanattrwouldn′twork.ty or other specific fragments as part of an attr wouldn't work. tyorotherspecificfragmentsaspartofanattrwouldn′twork.tt used to work since it wouldn't be parsed anywhere along the way.
Closes rust-lang#137662
bors added a commit to rust-lang-ci/rust that referenced this pull request
Rollup of 23 pull requests
Successful merges:
- rust-lang#137303 (Remove
MaybeForgetReturn
suggestion) - rust-lang#137327 (Undeprecate env::home_dir)
- rust-lang#137358 (Match Ergonomics 2024: add context and examples to the unstable book)
- rust-lang#137534 ([rustdoc] hide item that is not marked as doc(inline) and whose src is doc(hidden))
- rust-lang#137565 (Try to point of macro expansion from resolver and method errors if it involves macro var)
- rust-lang#137637 (Check dyn flavor before registering upcast goal on wide pointer cast in MIR typeck)
- rust-lang#137643 (Add DWARF test case for non-C-like
repr128
enums) - rust-lang#137744 (Re-add
Clone
-derive onThir
) - rust-lang#137758 (fix usage of ty decl macro fragments in attributes)
- rust-lang#137764 (Ensure that negative auto impls are always applicable)
- rust-lang#137772 (Fix char count in
Display
forByteStr
) - rust-lang#137798 (ci: use ubuntu 24 on arm large runner)
- rust-lang#137802 (miri native-call support: all previously exposed provenance is accessible to the callee)
- rust-lang#137805 (adjust Layout debug printing to match the internal field name)
- rust-lang#137808 (Do not require that unsafe fields lack drop glue)
- rust-lang#137820 (Clarify why InhabitedPredicate::instantiate_opt exists)
- rust-lang#137825 (Provide more context on resolve error caused from incorrect RTN)
- rust-lang#137910 (Improve error message for
AsyncFn
trait failure for RPIT) - rust-lang#137920 (interpret/provenance_map: consistently use range_is_empty)
- rust-lang#138038 (Update
compiler-builtins
to 0.1.151) - rust-lang#138041 (bootstrap and compiletest: Use
size_of_val
from the prelude instead of imported) - rust-lang#138046 (trim channel value in
get_closest_merge_commit
) - rust-lang#138053 (Increase the max. custom try jobs requested to
20
)
r? @ghost
@rustbot
modify labels: rollup
jieyouxu added a commit to jieyouxu/rust that referenced this pull request
…cote
fix usage of ty decl macro fragments in attributes
See the test case. Due to one missing code path (and also the changes in rust-lang#137517), using tyorotherspecificfragmentsaspartofanattrwouldn′twork.ty or other specific fragments as part of an attr wouldn't work. tyorotherspecificfragmentsaspartofanattrwouldn′twork.tt used to work since it wouldn't be parsed anywhere along the way.
Closes rust-lang#137662
bors added a commit to rust-lang-ci/rust that referenced this pull request
jieyouxu added a commit to jieyouxu/rust that referenced this pull request
…cote
fix usage of ty decl macro fragments in attributes
See the test case. Due to one missing code path (and also the changes in rust-lang#137517), using tyorotherspecificfragmentsaspartofanattrwouldn′twork.ty or other specific fragments as part of an attr wouldn't work. tyorotherspecificfragmentsaspartofanattrwouldn′twork.tt used to work since it wouldn't be parsed anywhere along the way.
Closes rust-lang#137662
compiler-errors added a commit to compiler-errors/rust that referenced this pull request
…cote
fix usage of ty decl macro fragments in attributes
See the test case. Due to one missing code path (and also the changes in rust-lang#137517), using tyorotherspecificfragmentsaspartofanattrwouldn′twork.ty or other specific fragments as part of an attr wouldn't work. tyorotherspecificfragmentsaspartofanattrwouldn′twork.tt used to work since it wouldn't be parsed anywhere along the way.
Closes rust-lang#137662
Noratrieb added a commit to Noratrieb/rust that referenced this pull request
…cote
fix usage of ty decl macro fragments in attributes
See the test case. Due to one missing code path (and also the changes in rust-lang#137517), using tyorotherspecificfragmentsaspartofanattrwouldn′twork.ty or other specific fragments as part of an attr wouldn't work. tyorotherspecificfragmentsaspartofanattrwouldn′twork.tt used to work since it wouldn't be parsed anywhere along the way.
Closes rust-lang#137662
Noratrieb added a commit to Noratrieb/rust that referenced this pull request
…compiler-errors
Rollup of 20 pull requests
Successful merges:
- rust-lang#137303 (Remove
MaybeForgetReturn
suggestion) - rust-lang#137327 (Undeprecate env::home_dir)
- rust-lang#137358 (Match Ergonomics 2024: add context and examples to the unstable book)
- rust-lang#137502 (Don't include global asm in
mir_keys
, fix error body synthesis) - rust-lang#137534 ([rustdoc] hide item that is not marked as doc(inline) and whose src is doc(hidden))
- rust-lang#137565 (Try to point of macro expansion from resolver and method errors if it involves macro var)
- rust-lang#137637 (Check dyn flavor before registering upcast goal on wide pointer cast in MIR typeck)
- rust-lang#137643 (Add DWARF test case for non-C-like
repr128
enums) - rust-lang#137744 (Re-add
Clone
-derive onThir
) - rust-lang#137758 (fix usage of ty decl macro fragments in attributes)
- rust-lang#137764 (Ensure that negative auto impls are always applicable)
- rust-lang#137772 (Fix char count in
Display
forByteStr
) - rust-lang#137798 (ci: use ubuntu 24 on arm large runner)
- rust-lang#137802 (miri native-call support: all previously exposed provenance is accessible to the callee)
- rust-lang#137805 (adjust Layout debug printing to match the internal field name)
- rust-lang#137808 (Do not require that unsafe fields lack drop glue)
- rust-lang#137820 (Clarify why InhabitedPredicate::instantiate_opt exists)
- rust-lang#137825 (Provide more context on resolve error caused from incorrect RTN)
- rust-lang#137868 (Add minimal platform support documentation for powerpc-unknown-linux-gnuspe)
- rust-lang#137910 (Improve error message for
AsyncFn
trait failure for RPIT)
r? @ghost
@rustbot
modify labels: rollup
bors added a commit to rust-lang-ci/rust that referenced this pull request
…mpiler-errors
Rollup of 20 pull requests
Successful merges:
- rust-lang#137303 (Remove
MaybeForgetReturn
suggestion) - rust-lang#137327 (Undeprecate env::home_dir)
- rust-lang#137358 (Match Ergonomics 2024: add context and examples to the unstable book)
- rust-lang#137502 (Don't include global asm in
mir_keys
, fix error body synthesis) - rust-lang#137534 ([rustdoc] hide item that is not marked as doc(inline) and whose src is doc(hidden))
- rust-lang#137565 (Try to point of macro expansion from resolver and method errors if it involves macro var)
- rust-lang#137637 (Check dyn flavor before registering upcast goal on wide pointer cast in MIR typeck)
- rust-lang#137643 (Add DWARF test case for non-C-like
repr128
enums) - rust-lang#137744 (Re-add
Clone
-derive onThir
) - rust-lang#137758 (fix usage of ty decl macro fragments in attributes)
- rust-lang#137764 (Ensure that negative auto impls are always applicable)
- rust-lang#137772 (Fix char count in
Display
forByteStr
) - rust-lang#137798 (ci: use ubuntu 24 on arm large runner)
- rust-lang#137802 (miri native-call support: all previously exposed provenance is accessible to the callee)
- rust-lang#137805 (adjust Layout debug printing to match the internal field name)
- rust-lang#137808 (Do not require that unsafe fields lack drop glue)
- rust-lang#137820 (Clarify why InhabitedPredicate::instantiate_opt exists)
- rust-lang#137825 (Provide more context on resolve error caused from incorrect RTN)
- rust-lang#137868 (Add minimal platform support documentation for powerpc-unknown-linux-gnuspe)
- rust-lang#137910 (Improve error message for
AsyncFn
trait failure for RPIT)
r? @ghost
@rustbot
modify labels: rollup
bors added a commit to rust-lang-ci/rust that referenced this pull request
…mpiler-errors
Rollup of 20 pull requests
Successful merges:
- rust-lang#137303 (Remove
MaybeForgetReturn
suggestion) - rust-lang#137327 (Undeprecate env::home_dir)
- rust-lang#137358 (Match Ergonomics 2024: add context and examples to the unstable book)
- rust-lang#137502 (Don't include global asm in
mir_keys
, fix error body synthesis) - rust-lang#137534 ([rustdoc] hide item that is not marked as doc(inline) and whose src is doc(hidden))
- rust-lang#137565 (Try to point of macro expansion from resolver and method errors if it involves macro var)
- rust-lang#137637 (Check dyn flavor before registering upcast goal on wide pointer cast in MIR typeck)
- rust-lang#137643 (Add DWARF test case for non-C-like
repr128
enums) - rust-lang#137744 (Re-add
Clone
-derive onThir
) - rust-lang#137758 (fix usage of ty decl macro fragments in attributes)
- rust-lang#137764 (Ensure that negative auto impls are always applicable)
- rust-lang#137772 (Fix char count in
Display
forByteStr
) - rust-lang#137798 (ci: use ubuntu 24 on arm large runner)
- rust-lang#137802 (miri native-call support: all previously exposed provenance is accessible to the callee)
- rust-lang#137805 (adjust Layout debug printing to match the internal field name)
- rust-lang#137808 (Do not require that unsafe fields lack drop glue)
- rust-lang#137820 (Clarify why InhabitedPredicate::instantiate_opt exists)
- rust-lang#137825 (Provide more context on resolve error caused from incorrect RTN)
- rust-lang#137868 (Add minimal platform support documentation for powerpc-unknown-linux-gnuspe)
- rust-lang#137910 (Improve error message for
AsyncFn
trait failure for RPIT)
r? @ghost
@rustbot
modify labels: rollup
bors added a commit to rust-lang-ci/rust that referenced this pull request
…mpiler-errors
Rollup of 25 pull requests
Successful merges:
- rust-lang#135733 (Implement
&pin const self
and&pin mut self
sugars) - rust-lang#135895 (Document workings of successors more clearly)
- rust-lang#136922 (Pattern types: Avoid having to handle an Option for range ends in the type system or the HIR)
- rust-lang#137303 (Remove
MaybeForgetReturn
suggestion) - rust-lang#137327 (Undeprecate env::home_dir)
- rust-lang#137358 (Match Ergonomics 2024: add context and examples to the unstable book)
- rust-lang#137534 ([rustdoc] hide item that is not marked as doc(inline) and whose src is doc(hidden))
- rust-lang#137565 (Try to point of macro expansion from resolver and method errors if it involves macro var)
- rust-lang#137637 (Check dyn flavor before registering upcast goal on wide pointer cast in MIR typeck)
- rust-lang#137643 (Add DWARF test case for non-C-like
repr128
enums) - rust-lang#137744 (Re-add
Clone
-derive onThir
) - rust-lang#137758 (fix usage of ty decl macro fragments in attributes)
- rust-lang#137764 (Ensure that negative auto impls are always applicable)
- rust-lang#137772 (Fix char count in
Display
forByteStr
) - rust-lang#137798 (ci: use ubuntu 24 on arm large runner)
- rust-lang#137802 (miri native-call support: all previously exposed provenance is accessible to the callee)
- rust-lang#137805 (adjust Layout debug printing to match the internal field name)
- rust-lang#137808 (Do not require that unsafe fields lack drop glue)
- rust-lang#137820 (Clarify why InhabitedPredicate::instantiate_opt exists)
- rust-lang#137825 (Provide more context on resolve error caused from incorrect RTN)
- rust-lang#137834 (rustc_fluent_macro: use CARGO_CRATE_NAME instead of CARGO_PKG_NAME)
- rust-lang#137868 (Add minimal platform support documentation for powerpc-unknown-linux-gnuspe)
- rust-lang#137910 (Improve error message for
AsyncFn
trait failure for RPIT) - rust-lang#137920 (interpret/provenance_map: consistently use range_is_empty)
- rust-lang#138038 (Update
compiler-builtins
to 0.1.151)
r? @ghost
@rustbot
modify labels: rollup
bors added a commit to rust-lang-ci/rust that referenced this pull request
…mpiler-errors
Rollup of 25 pull requests
Successful merges:
- rust-lang#135733 (Implement
&pin const self
and&pin mut self
sugars) - rust-lang#135895 (Document workings of successors more clearly)
- rust-lang#136922 (Pattern types: Avoid having to handle an Option for range ends in the type system or the HIR)
- rust-lang#137303 (Remove
MaybeForgetReturn
suggestion) - rust-lang#137327 (Undeprecate env::home_dir)
- rust-lang#137358 (Match Ergonomics 2024: add context and examples to the unstable book)
- rust-lang#137534 ([rustdoc] hide item that is not marked as doc(inline) and whose src is doc(hidden))
- rust-lang#137565 (Try to point of macro expansion from resolver and method errors if it involves macro var)
- rust-lang#137637 (Check dyn flavor before registering upcast goal on wide pointer cast in MIR typeck)
- rust-lang#137643 (Add DWARF test case for non-C-like
repr128
enums) - rust-lang#137744 (Re-add
Clone
-derive onThir
) - rust-lang#137758 (fix usage of ty decl macro fragments in attributes)
- rust-lang#137764 (Ensure that negative auto impls are always applicable)
- rust-lang#137772 (Fix char count in
Display
forByteStr
) - rust-lang#137798 (ci: use ubuntu 24 on arm large runner)
- rust-lang#137802 (miri native-call support: all previously exposed provenance is accessible to the callee)
- rust-lang#137805 (adjust Layout debug printing to match the internal field name)
- rust-lang#137808 (Do not require that unsafe fields lack drop glue)
- rust-lang#137820 (Clarify why InhabitedPredicate::instantiate_opt exists)
- rust-lang#137825 (Provide more context on resolve error caused from incorrect RTN)
- rust-lang#137834 (rustc_fluent_macro: use CARGO_CRATE_NAME instead of CARGO_PKG_NAME)
- rust-lang#137868 (Add minimal platform support documentation for powerpc-unknown-linux-gnuspe)
- rust-lang#137910 (Improve error message for
AsyncFn
trait failure for RPIT) - rust-lang#137920 (interpret/provenance_map: consistently use range_is_empty)
- rust-lang#138038 (Update
compiler-builtins
to 0.1.151)
r? @ghost
@rustbot
modify labels: rollup
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request
Rollup merge of rust-lang#137758 - jdonszelmann:fix-137662, r=nnethercote
fix usage of ty decl macro fragments in attributes
See the test case. Due to one missing code path (and also the changes in rust-lang#137517), using tyorotherspecificfragmentsaspartofanattrwouldn′twork.ty or other specific fragments as part of an attr wouldn't work. tyorotherspecificfragmentsaspartofanattrwouldn′twork.tt used to work since it wouldn't be parsed anywhere along the way.
Closes rust-lang#137662
github-actions bot pushed a commit to model-checking/verify-rust-std that referenced this pull request
…mpiler-errors
Rollup of 25 pull requests
Successful merges:
- rust-lang#135733 (Implement
&pin const self
and&pin mut self
sugars) - rust-lang#135895 (Document workings of successors more clearly)
- rust-lang#136922 (Pattern types: Avoid having to handle an Option for range ends in the type system or the HIR)
- rust-lang#137303 (Remove
MaybeForgetReturn
suggestion) - rust-lang#137327 (Undeprecate env::home_dir)
- rust-lang#137358 (Match Ergonomics 2024: add context and examples to the unstable book)
- rust-lang#137534 ([rustdoc] hide item that is not marked as doc(inline) and whose src is doc(hidden))
- rust-lang#137565 (Try to point of macro expansion from resolver and method errors if it involves macro var)
- rust-lang#137637 (Check dyn flavor before registering upcast goal on wide pointer cast in MIR typeck)
- rust-lang#137643 (Add DWARF test case for non-C-like
repr128
enums) - rust-lang#137744 (Re-add
Clone
-derive onThir
) - rust-lang#137758 (fix usage of ty decl macro fragments in attributes)
- rust-lang#137764 (Ensure that negative auto impls are always applicable)
- rust-lang#137772 (Fix char count in
Display
forByteStr
) - rust-lang#137798 (ci: use ubuntu 24 on arm large runner)
- rust-lang#137802 (miri native-call support: all previously exposed provenance is accessible to the callee)
- rust-lang#137805 (adjust Layout debug printing to match the internal field name)
- rust-lang#137808 (Do not require that unsafe fields lack drop glue)
- rust-lang#137820 (Clarify why InhabitedPredicate::instantiate_opt exists)
- rust-lang#137825 (Provide more context on resolve error caused from incorrect RTN)
- rust-lang#137834 (rustc_fluent_macro: use CARGO_CRATE_NAME instead of CARGO_PKG_NAME)
- rust-lang#137868 (Add minimal platform support documentation for powerpc-unknown-linux-gnuspe)
- rust-lang#137910 (Improve error message for
AsyncFn
trait failure for RPIT) - rust-lang#137920 (interpret/provenance_map: consistently use range_is_empty)
- rust-lang#138038 (Update
compiler-builtins
to 0.1.151)
r? @ghost
@rustbot
modify labels: rollup
Labels
Area: Attributes (`#[…]`, `#![…]`)
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Relevant to the compiler team, which will review and decide on the PR/issue.