Simplify Postorder customization. by nnethercote · Pull Request #137299 · rust-lang/rust (original) (raw)
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation5 Commits1 Checks6 Files changed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
Postorder has a C: Customization<'tcx> parameter, that gives it flexibility about how it computes successors. But in practice, there are only two impls of Customization, and one is for the unit type.
This commit simplifies things by removing the generic parameter and replacing it with an Option.
r? @saethlin
Postorder has a C: Customization<'tcx> parameter, that gives it
flexibility about how it computes successors. But in practice, there are
only two impls of Customization, and one is for the unit type.
This commit simplifies things by removing the generic parameter and
replacing it with an Option.
r? @oli-obk
rustbot has assigned @oli-obk.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.
Use r? to explicitly pick a reviewer
Status: Awaiting review from the assignee but also interested parties.
Relevant to the compiler team, which will review and decide on the PR/issue.
labels
Some changes occurred in src/tools/clippy
cc @rust-lang/clippy
| basic_blocks: &'a IndexSlice<BasicBlock, BasicBlockData<'tcx>>, |
|---|
| visited: DenseBitSet, |
| visit_stack: Vec<(BasicBlock, Successors<'a>)>, |
| root_is_start_block: bool, |
| extra: C, |
| /// A non-empty `extra` allows for a precise calculation of the successors. |
| extra: Option<(TyCtxt<'tcx>, Instance<'tcx>)>, |
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
preexisting: the variable name is a bit vague. would've been nice if it was called mono_-something.
r? compiler-errors @bors r+ rollup
📌 Commit cae9ebb has been approved by compiler-errors
It is now in the queue for this repository.
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
workingjubilee added a commit to workingjubilee/rustc that referenced this pull request
…tomization, r=compiler-errors
Simplify Postorder customization.
Postorder has a C: Customization<'tcx> parameter, that gives it flexibility about how it computes successors. But in practice, there are only two impls of Customization, and one is for the unit type.
This commit simplifies things by removing the generic parameter and replacing it with an Option.
r? @saethlin
bors added a commit to rust-lang-ci/rust that referenced this pull request
workingjubilee added a commit to workingjubilee/rustc that referenced this pull request
…tomization, r=compiler-errors
Simplify Postorder customization.
Postorder has a C: Customization<'tcx> parameter, that gives it flexibility about how it computes successors. But in practice, there are only two impls of Customization, and one is for the unit type.
This commit simplifies things by removing the generic parameter and replacing it with an Option.
r? @saethlin
bors added a commit to rust-lang-ci/rust that referenced this pull request
Rollup of 12 pull requests
Successful merges:
- rust-lang#128080 (Specify scope in
out_of_scope_macro_callslint) - rust-lang#135354 ([Debuginfo] Add MSVC Synthetic and Summary providers to LLDB)
- rust-lang#135630 (add more
s390xtarget features) - rust-lang#136089 (Reduce
Box::defaultstack copies in debug mode) - rust-lang#136148 (Optionally add type names to
TypeIds.) - rust-lang#137192 (Remove obsolete Windows ThinLTO+TLS workaround)
- rust-lang#137204 (Clarify MIR dialects and phases)
- rust-lang#137299 (Simplify
Postordercustomization.) - rust-lang#137302 (Use a probe to avoid registering stray region obligations when re-checking drops in MIR typeck)
- rust-lang#137305 (Tweaks in and around
rustc_middle) - rust-lang#137313 (Some codegen_llvm cleanups)
- rust-lang#137333 (Use
edition = "2024"in the compiler (redux))
r? @ghost
@rustbot modify labels: rollup
try-job: test-various try-job: x86_64-msvc-1 try-job: x86_64-msvc-2 try-job: i686-msvc-1 try-job: i686-msvc-2 try-job: i686-mingw-1 try-job: i686-mingw-2 try-job: i686-mingw-3 try-job: x86_64-gnu-nopt
workingjubilee added a commit to workingjubilee/rustc that referenced this pull request
…tomization, r=compiler-errors
Simplify Postorder customization.
Postorder has a C: Customization<'tcx> parameter, that gives it flexibility about how it computes successors. But in practice, there are only two impls of Customization, and one is for the unit type.
This commit simplifies things by removing the generic parameter and replacing it with an Option.
r? @saethlin
bors added a commit to rust-lang-ci/rust that referenced this pull request
Rollup of 10 pull requests
Successful merges:
- rust-lang#128080 (Specify scope in
out_of_scope_macro_callslint) - rust-lang#135630 (add more
s390xtarget features) - rust-lang#136089 (Reduce
Box::defaultstack copies in debug mode) - rust-lang#137192 (Remove obsolete Windows ThinLTO+TLS workaround)
- rust-lang#137204 (Clarify MIR dialects and phases)
- rust-lang#137299 (Simplify
Postordercustomization.) - rust-lang#137302 (Use a probe to avoid registering stray region obligations when re-checking drops in MIR typeck)
- rust-lang#137305 (Tweaks in and around
rustc_middle) - rust-lang#137313 (Some codegen_llvm cleanups)
- rust-lang#137333 (Use
edition = "2024"in the compiler (redux))
r? @ghost
@rustbot modify labels: rollup
try-job: aarch64-gnu try-job: armhf-gnu try-job: i686-mingw-1 try-job: i686-mingw-2 try-job: i686-mingw-3 try-job: test-various try-job: x86_64-gnu-nopt try-job: x86_64-msvc-1 try-job: x86_64-msvc-2
bors added a commit to rust-lang-ci/rust that referenced this pull request
bors added a commit to rust-lang-ci/rust that referenced this pull request
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request
Rollup merge of rust-lang#137299 - nnethercote:simplify-PostOrder-customization, r=compiler-errors
Simplify Postorder customization.
Postorder has a C: Customization<'tcx> parameter, that gives it flexibility about how it computes successors. But in practice, there are only two impls of Customization, and one is for the unit type.
This commit simplifies things by removing the generic parameter and replacing it with an Option.
r? @saethlin
flip1995 pushed a commit to flip1995/rust that referenced this pull request
…tomization, r=compiler-errors
Simplify Postorder customization.
Postorder has a C: Customization<'tcx> parameter, that gives it flexibility about how it computes successors. But in practice, there are only two impls of Customization, and one is for the unit type.
This commit simplifies things by removing the generic parameter and replacing it with an Option.
r? @saethlin
github-actions bot pushed a commit to tautschnig/verify-rust-std that referenced this pull request
github-actions bot pushed a commit to tautschnig/verify-rust-std that referenced this pull request
Labels
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Relevant to the compiler team, which will review and decide on the PR/issue.