Use a probe to avoid registering stray region obligations when re-checking drops in MIR typeck by compiler-errors · Pull Request #137302 · rust-lang/rust (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation2 Commits1 Checks6 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

Fixes #137288.

See the comment I left on the probe. I'm not totally sure why this depends on both an unconstrained type parameter in the impl and a type error for the self type, but I think the fix is at least theoretically well motivated.

r? @matthewjasper

…cking drops in MIR typeck

rustbot added S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

T-compiler

Relevant to the compiler team, which will review and decide on the PR/issue.

labels

Feb 20, 2025

📌 Commit d4609f8 has been approved by matthewjasper

It is now in the queue for this repository.

bors added S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

and removed S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

labels

Feb 20, 2025

workingjubilee added a commit to workingjubilee/rustc that referenced this pull request

Feb 20, 2025

…, r=matthewjasper

Use a probe to avoid registering stray region obligations when re-checking drops in MIR typeck

Fixes rust-lang#137288.

See the comment I left on the probe. I'm not totally sure why this depends on both an unconstrained type parameter in the impl and a type error for the self type, but I think the fix is at least theoretically well motivated.

r? @matthewjasper

bors added a commit to rust-lang-ci/rust that referenced this pull request

Feb 20, 2025

Rollup of 12 pull requests

Successful merges:

• rust-lang#128080 (Specify scope in out_of_scope_macro_calls lint)
• rust-lang#135354 ([Debuginfo] Add MSVC Synthetic and Summary providers to LLDB)
• rust-lang#135630 (add more s390x target features)
• rust-lang#136089 (Reduce Box::default stack copies in debug mode)
• rust-lang#136148 (Optionally add type names to TypeIds.)
• rust-lang#137192 (Remove obsolete Windows ThinLTO+TLS workaround)
• rust-lang#137204 (Clarify MIR dialects and phases)
• rust-lang#137299 (Simplify Postorder customization.)
• rust-lang#137302 (Use a probe to avoid registering stray region obligations when re-checking drops in MIR typeck)
• rust-lang#137305 (Tweaks in and around rustc_middle)
• rust-lang#137313 (Some codegen_llvm cleanups)
• rust-lang#137333 (Use edition = "2024" in the compiler (redux))

r? @ghost @rustbot modify labels: rollup

try-job: test-various try-job: x86_64-msvc-1 try-job: x86_64-msvc-2 try-job: i686-msvc-1 try-job: i686-msvc-2 try-job: i686-mingw-1 try-job: i686-mingw-2 try-job: i686-mingw-3 try-job: x86_64-gnu-nopt

workingjubilee added a commit to workingjubilee/rustc that referenced this pull request

Feb 20, 2025

…, r=matthewjasper

Use a probe to avoid registering stray region obligations when re-checking drops in MIR typeck

Fixes rust-lang#137288.

See the comment I left on the probe. I'm not totally sure why this depends on both an unconstrained type parameter in the impl and a type error for the self type, but I think the fix is at least theoretically well motivated.

r? @matthewjasper

bors added a commit to rust-lang-ci/rust that referenced this pull request

Feb 21, 2025

Rollup of 10 pull requests

Successful merges:

• rust-lang#128080 (Specify scope in out_of_scope_macro_calls lint)
• rust-lang#135630 (add more s390x target features)
• rust-lang#136089 (Reduce Box::default stack copies in debug mode)
• rust-lang#137192 (Remove obsolete Windows ThinLTO+TLS workaround)
• rust-lang#137204 (Clarify MIR dialects and phases)
• rust-lang#137299 (Simplify Postorder customization.)
• rust-lang#137302 (Use a probe to avoid registering stray region obligations when re-checking drops in MIR typeck)
• rust-lang#137305 (Tweaks in and around rustc_middle)
• rust-lang#137313 (Some codegen_llvm cleanups)
• rust-lang#137333 (Use edition = "2024" in the compiler (redux))

r? @ghost @rustbot modify labels: rollup

try-job: aarch64-gnu try-job: armhf-gnu try-job: i686-mingw-1 try-job: i686-mingw-2 try-job: i686-mingw-3 try-job: test-various try-job: x86_64-gnu-nopt try-job: x86_64-msvc-1 try-job: x86_64-msvc-2

bors added a commit to rust-lang-ci/rust that referenced this pull request

Feb 21, 2025

bors added a commit to rust-lang-ci/rust that referenced this pull request

Feb 21, 2025

rust-timer added a commit to rust-lang-ci/rust that referenced this pull request

Feb 21, 2025

Rollup merge of rust-lang#137302 - compiler-errors:stray-drop-regions, r=matthewjasper

Use a probe to avoid registering stray region obligations when re-checking drops in MIR typeck

Fixes rust-lang#137288.

See the comment I left on the probe. I'm not totally sure why this depends on both an unconstrained type parameter in the impl and a type error for the self type, but I think the fix is at least theoretically well motivated.

r? @matthewjasper

github-actions bot pushed a commit to tautschnig/verify-rust-std that referenced this pull request

Mar 11, 2025

github-actions bot pushed a commit to tautschnig/verify-rust-std that referenced this pull request

Mar 11, 2025

Labels

S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

T-compiler

Relevant to the compiler team, which will review and decide on the PR/issue.