librustdoc: 2024 edition! 🎊 by yotamofek · Pull Request #137722 · rust-lang/rust (original) (raw)
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation16 Commits2 Checks6 Files changed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
r? @notriddle
rustbot has assigned @notriddle.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.
Use r? to explicitly pick a reviewer
Status: Awaiting review from the assignee but also interested parties.
Relevant to the rustdoc team, which will review and decide on the PR/issue.
Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output.
labels
Comment on lines -126 to +119
| fn render_assoc_items<'b>(&'b self) -> impl fmt::Display + Captures<'a> + 'b + Captures<'cx> { |
|---|
| fmt::from_fn(move |f |
| let (item, cx) = self.item_and_cx(); |
| let def_id = item.item_id.expect_def_id(); |
| let v = render_assoc_items(cx, item, def_id, AssocItemRender::All); |
| write!(f, "{v}") |
| }) |
| fn render_assoc_items(&self) -> impl fmt::Display { |
| let (item, cx) = self.item_and_cx(); |
| let def_id = item.item_id.expect_def_id(); |
| render_assoc_items(cx, item, def_id, AssocItemRender::All) |
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a change that can actually affect execution, not just lifetime metadata.
This still looks file (render_assoc_items itself returns impl Display), but it's still worth tracking.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, you're right, but seeing as I added all of these fmt::from_fn()s myself, I'm confident about deleting them again. :)
📌 Commit 7d263b0 has been approved by notriddle
It is now in the queue for this repository.
🌲 The tree is currently closed for pull requests below priority 100. This pull request will be tested once the tree is reopened.
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request
… r=notriddle
librustdoc: 2024 edition! 🎊
Like rust-lang#137333 , but for rustdoc 😁
tgross35 added a commit to tgross35/rust that referenced this pull request
… r=notriddle
librustdoc: 2024 edition! 🎊
Like rust-lang#137333 , but for rustdoc 😁
Status: This is awaiting some action (such as code changes or more information) from the author.
and removed S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
labels
@notriddle had to fix conflicts with #137425 , would appreciate another review/approval (should be quick - nothing actually changed from the last iteration)
Status: Awaiting review from the assignee but also interested parties.
and removed S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
labels
📌 Commit 74c783c has been approved by notriddle
It is now in the queue for this repository.
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request
… r=notriddle
librustdoc: 2024 edition! 🎊
Like rust-lang#137333 , but for rustdoc 😁
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request
… r=notriddle
librustdoc: 2024 edition! 🎊
Like rust-lang#137333 , but for rustdoc 😁
bors added a commit to rust-lang-ci/rust that referenced this pull request
jhpratt added a commit to jhpratt/rust that referenced this pull request
… r=notriddle
librustdoc: 2024 edition! 🎊
Like rust-lang#137333 , but for rustdoc 😁
bors added a commit to rust-lang-ci/rust that referenced this pull request
Rollup of 13 pull requests
Successful merges:
- rust-lang#136581 (Retire the legacy
Makefile-basedrun-maketest infra) - rust-lang#136865 (Perform deeper compiletest path normalization for
$TEST_BUILD_DIRto account for compare-mode/debugger cases, and normalize long type file filename hashes) - rust-lang#137147 (Add exclude to config.toml)
- rust-lang#137327 (Undeprecate env::home_dir)
- rust-lang#137463 ([illumos] attempt to use posix_spawn to spawn processes)
- rust-lang#137477 (uefi: Add Service Binding Protocol abstraction)
- rust-lang#137502 (Don't include global asm in
mir_keys, fix error body synthesis) - rust-lang#137534 ([rustdoc] hide item that is not marked as doc(inline) and whose src is doc(hidden))
- rust-lang#137565 (Try to point of macro expansion from resolver and method errors if it involves macro var)
- rust-lang#137643 (Add DWARF test case for non-C-like
repr128enums) - rust-lang#137722 (
librustdoc: 2024 edition! 🎊) - rust-lang#137836 (Set
target_vendor = "openwrt"onmips64-openwrt-linux-musl) - rust-lang#137949 (Update MSVC INSTALL.md instructions to recommend VS 2022 + recent Windows 10/11 SDK)
Failed merges:
- rust-lang#137798 (ci: use ubuntu 24 on arm large runner)
r? @ghost
@rustbot modify labels: rollup
Status: This is awaiting some action (such as code changes or more information) from the author.
and removed S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
labels
Get rid of the Captures hack
Status: Awaiting review from the assignee but also interested parties.
and removed S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
labels
📌 Commit 6e86aa1 has been approved by notriddle
It is now in the queue for this repository.
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
bors added a commit to rust-lang-ci/rust that referenced this pull request
…kingjubilee
Rollup of 6 pull requests
Successful merges:
- rust-lang#137077 (Postprocess bootstrap metrics into GitHub job summary)
- rust-lang#137373 (Compile run-make-support and run-make tests with the bootstrap compiler)
- rust-lang#137634 (Update
compiler-builtinsto 0.1.149) - rust-lang#137667 (Add
dist::Gccbuild step) - rust-lang#137722 (
librustdoc: 2024 edition! 🎊) - rust-lang#137947 (Do not install rustup on Rust for Linux job)
r? @ghost
@rustbot modify labels: rollup
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request
Labels
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Relevant to the rustdoc team, which will review and decide on the PR/issue.
Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output.