Do not install rustup on Rust for Linux job by Kobzol · Pull Request #137947 · rust-lang/rust (original) (raw)
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation19 Commits2 Checks6 Files changed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
Trying to fix the RfL job after the recent rustup update.
r? @ghost
try-job: x86_64-rust-for-linux
Area: The testsuite used to check the correctness of rustc
Status: Awaiting review from the assignee but also interested parties.
Relevant to the infrastructure team, which will review and decide on the PR/issue.
labels
This comment has been minimized.
This comment has been minimized.
[WIP] Do not install rustup on RfL job Do not install rustup on Rust for Linux job
Failed to set assignee to ojeda: invalid assignee
Note: Only org members with at least the repository "read" role, users with write permissions, or people who have commented on the PR may be assigned.
@bors try
Just to make sure.
bors added a commit to rust-lang-ci/rust that referenced this pull request
Do not install rustup on Rust for Linux job
Trying to fix the RfL job after the recent rustup update.
r? @ghost
try-job: x86_64-rust-for-linux
☀️ Try build successful - checks-actions
Build commit: f7be3fb (f7be3fb0174829159d883ef1065acd20873756ae)
r? @ojeda
Please see if the CI log looks good :)
The log in the latest try build looks good to me, thanks!
I guess we could do a quick try build with a change somewhere that forces it to fail when building the kernel, but given the log I am fairly confident it still works.
15 tasks
There is no other rustc or cargo available other than the built in-tree one now, so I think that should be fine.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm. Feel free to r=me when ready 👍
📌 Commit 4f4cbff has been approved by marcoieni
It is now in the queue for this repository.
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
jieyouxu added a commit to jieyouxu/rust that referenced this pull request
Do not install rustup on Rust for Linux job
Trying to fix the RfL job after the recent rustup update.
r? @ghost
try-job: x86_64-rust-for-linux
bors added a commit to rust-lang-ci/rust that referenced this pull request
Rollup of 10 pull requests
Successful merges:
- rust-lang#136581 (Retire the legacy
Makefile-basedrun-maketest infra) - rust-lang#136865 (Perform deeper compiletest path normalization for
$TEST_BUILD_DIRto account for compare-mode/debugger cases, and normalize long type file filename hashes) - rust-lang#136975 (Look for
python3first on MacOS, notpy) - rust-lang#137240 (Slightly reformat
std::fs::remove_dir_allerror docs) - rust-lang#137303 (Remove
MaybeForgetReturnsuggestion) - rust-lang#137634 (Update
compiler-builtinsto 0.1.149) - rust-lang#137679 (Various coretests improvements)
- rust-lang#137685 (self-contained linker: conservatively default to
-znostart-stop-gc) - rust-lang#137850 (Stabilize
box_uninit_write) - rust-lang#137947 (Do not install rustup on Rust for Linux job)
r? @ghost
@rustbot modify labels: rollup
bors added a commit to rust-lang-ci/rust that referenced this pull request
…kingjubilee
Rollup of 6 pull requests
Successful merges:
- rust-lang#137077 (Postprocess bootstrap metrics into GitHub job summary)
- rust-lang#137373 (Compile run-make-support and run-make tests with the bootstrap compiler)
- rust-lang#137634 (Update
compiler-builtinsto 0.1.149) - rust-lang#137667 (Add
dist::Gccbuild step) - rust-lang#137722 (
librustdoc: 2024 edition! 🎊) - rust-lang#137947 (Do not install rustup on Rust for Linux job)
r? @ghost
@rustbot modify labels: rollup
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request
Rollup merge of rust-lang#137947 - Kobzol:fix-rfl, r=marcoieni
Do not install rustup on Rust for Linux job
Trying to fix the RfL job after the recent rustup update.
r? @ghost
try-job: x86_64-rust-for-linux
Stealing this to unblock beta...
@rustbot label +beta-accepted
bors added a commit to rust-lang-ci/rust that referenced this pull request
[beta] backports
- Don't infer attributes of virtual calls based on the function body rust-lang#137669
- Revert "store ScalarPair via memset when one side is undef and the other side can be memset" rust-lang#137894
- Do not install rustup on Rust for Linux job rust-lang#137947
r? cuviper
bors added a commit to rust-lang-ci/rust that referenced this pull request
[stable] Release 1.85.1
- Fix the doctest-merging feature of the 2024 Edition.
- Relax some
target_featurechecks when generating docs. - Fix errors in
std::fs::renameon Windows 1607. - Downgrade bootstrap
ccto fix custom targets. - Skip submodule updates when building Rust from a source tarball.
Added backports to fix CI:
- Remove latest Windows SDK from 32-bit CI rust-lang#137753
- Do not install rustup on Rust for Linux job rust-lang#137947
cc @rust-lang/release
r? cuviper
Labels
Area: The testsuite used to check the correctness of rustc
Accepted for backporting to the compiler in the beta channel.
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Accepted for backporting to the compiler in the stable channel.
Relevant to the infrastructure team, which will review and decide on the PR/issue.