Always allow rustdoc-json tests to contain long lines by Noratrieb · Pull Request #137955 · rust-lang/rust (original) (raw)
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation6 Commits1 Checks6 Files changed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
The rustdoc-json test syntax often requires very long lines, so the checks for long lines aren't really useful.
@aDotInTheVoid told me she'd like this and
r? jieyouxu
you're gonna tell me that the implementation is terrible. at least the performance seems reasonable: 2.5s after and 2.5s before.
The rustdoc-json test syntax often requires very long lines, so the checks for long lines aren't really useful.
Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output.
label
r=me on the rustdoc-json side, but someone who maintains tidy should approve that code (and decide if it's worth it).
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TBH I also wanted to do this for mir-opt tests and maybe codegen/assembly tests, where I find in test code the linelength check is more noise than value.
Also the tidy impl here isn't exactly tidy in the first place, and this makes rustdoc contributions less annoying, so I'm fine with that.
TL;DR:
@bors r=aDotInTheVoid,jieyouxu rollup
📌 Commit dfed028 has been approved by aDotInTheVoid,jieyouxu
It is now in the queue for this repository.
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
tidy as a whole is incredibly untidy :D
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request
…2, r=jieyouxu
triagebot.toml: Don't label test/rustdoc-json as A-rustdoc-search
This happened because test/rustdoc-js is a prefix of test/rustdoc-json, and triagebot works on prefixes.
Maybe this should be fixed in triagebot, but this works now.
This happened on rust-lang#137956 and rust-lang#137955.
bors added a commit to rust-lang-ci/rust that referenced this pull request
…iaskrgr
Rollup of 12 pull requests
Successful merges:
- rust-lang#135767 (Future incompatibility warning
unsupported_fn_ptr_calling_conventions: Also warn in dependencies) - rust-lang#137852 (Remove layouting dead code for non-array SIMD types.)
- rust-lang#137863 (Fix pretty printing of unsafe binders)
- rust-lang#137882 (do not build additional stage on compiler paths)
- rust-lang#137894 (Revert "store ScalarPair via memset when one side is undef and the other side can be memset")
- rust-lang#137902 (Make
ast::TokenKindmore likelexer::TokenKind) - rust-lang#137921 (Subtree update of
rust-analyzer) - rust-lang#137922 (A few cleanups after the removal of
cfg(not(parallel))) - rust-lang#137939 (fix order on shl impl)
- rust-lang#137946 (Fix docker run-local docs)
- rust-lang#137955 (Always allow rustdoc-json tests to contain long lines)
- rust-lang#137958 (triagebot.toml: Don't label
test/rustdoc-jsonas A-rustdoc-search)
r? @ghost
@rustbot modify labels: rollup
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request
Rollup merge of rust-lang#137958 - aDotInTheVoid:aDotInTheVoid-patch-2, r=jieyouxu
triagebot.toml: Don't label test/rustdoc-json as A-rustdoc-search
This happened because test/rustdoc-js is a prefix of test/rustdoc-json, and triagebot works on prefixes.
Maybe this should be fixed in triagebot, but this works now.
This happened on rust-lang#137956 and rust-lang#137955.
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request
Rollup merge of rust-lang#137955 - Noratrieb:rustdoc-json-long-lines, r=aDotInTheVoid,jieyouxu
Always allow rustdoc-json tests to contain long lines
The rustdoc-json test syntax often requires very long lines, so the checks for long lines aren't really useful.
@aDotInTheVoid told me she'd like this and
r? jieyouxu
you're gonna tell me that the implementation is terrible. at least the performance seems reasonable: 2.5s after and 2.5s before.
github-actions bot pushed a commit to model-checking/verify-rust-std that referenced this pull request
…iaskrgr
Rollup of 12 pull requests
Successful merges:
- rust-lang#135767 (Future incompatibility warning
unsupported_fn_ptr_calling_conventions: Also warn in dependencies) - rust-lang#137852 (Remove layouting dead code for non-array SIMD types.)
- rust-lang#137863 (Fix pretty printing of unsafe binders)
- rust-lang#137882 (do not build additional stage on compiler paths)
- rust-lang#137894 (Revert "store ScalarPair via memset when one side is undef and the other side can be memset")
- rust-lang#137902 (Make
ast::TokenKindmore likelexer::TokenKind) - rust-lang#137921 (Subtree update of
rust-analyzer) - rust-lang#137922 (A few cleanups after the removal of
cfg(not(parallel))) - rust-lang#137939 (fix order on shl impl)
- rust-lang#137946 (Fix docker run-local docs)
- rust-lang#137955 (Always allow rustdoc-json tests to contain long lines)
- rust-lang#137958 (triagebot.toml: Don't label
test/rustdoc-jsonas A-rustdoc-search)
r? @ghost
@rustbot modify labels: rollup
flip1995 pushed a commit to flip1995/rust that referenced this pull request
…iaskrgr
Rollup of 12 pull requests
Successful merges:
- rust-lang#135767 (Future incompatibility warning
unsupported_fn_ptr_calling_conventions: Also warn in dependencies) - rust-lang#137852 (Remove layouting dead code for non-array SIMD types.)
- rust-lang#137863 (Fix pretty printing of unsafe binders)
- rust-lang#137882 (do not build additional stage on compiler paths)
- rust-lang#137894 (Revert "store ScalarPair via memset when one side is undef and the other side can be memset")
- rust-lang#137902 (Make
ast::TokenKindmore likelexer::TokenKind) - rust-lang#137921 (Subtree update of
rust-analyzer) - rust-lang#137922 (A few cleanups after the removal of
cfg(not(parallel))) - rust-lang#137939 (fix order on shl impl)
- rust-lang#137946 (Fix docker run-local docs)
- rust-lang#137955 (Always allow rustdoc-json tests to contain long lines)
- rust-lang#137958 (triagebot.toml: Don't label
test/rustdoc-jsonas A-rustdoc-search)
r? @ghost
@rustbot modify labels: rollup
GuillaumeGomez pushed a commit to GuillaumeGomez/rust that referenced this pull request
…iaskrgr
Rollup of 12 pull requests
Successful merges:
- rust-lang#135767 (Future incompatibility warning
unsupported_fn_ptr_calling_conventions: Also warn in dependencies) - rust-lang#137852 (Remove layouting dead code for non-array SIMD types.)
- rust-lang#137863 (Fix pretty printing of unsafe binders)
- rust-lang#137882 (do not build additional stage on compiler paths)
- rust-lang#137894 (Revert "store ScalarPair via memset when one side is undef and the other side can be memset")
- rust-lang#137902 (Make
ast::TokenKindmore likelexer::TokenKind) - rust-lang#137921 (Subtree update of
rust-analyzer) - rust-lang#137922 (A few cleanups after the removal of
cfg(not(parallel))) - rust-lang#137939 (fix order on shl impl)
- rust-lang#137946 (Fix docker run-local docs)
- rust-lang#137955 (Always allow rustdoc-json tests to contain long lines)
- rust-lang#137958 (triagebot.toml: Don't label
test/rustdoc-jsonas A-rustdoc-search)
r? @ghost
@rustbot modify labels: rollup
Labels
Area: Rustdoc JSON backend
Area: The tidy tool
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Relevant to the rustdoc team, which will review and decide on the PR/issue.