Revert "store ScalarPair via memset when one side is undef and the other side can be memset" by compiler-errors · Pull Request #137894 · rust-lang/rust (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation9 Commits2 Checks6 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

@compiler-errors

@compiler-errors

…=saethlin"

This reverts commit a7a6c64, reversing changes made to ebbe638.

@compiler-errors

@rustbot rustbot added S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

T-compiler

Relevant to the compiler team, which will review and decide on the PR/issue.

labels

Mar 2, 2025

@compiler-errors compiler-errors changed the titleNo scalar pair opt Revert "store ScalarPair via memset when one side is undef and the other side can be memset"

Mar 2, 2025

@rustbot

compiler-errors

return;
}
}
OperandValue::Pair(a, b) => {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For future reference, on line 104:

The try_init_all_same tries to access a value that should be size u128, but since scalar pairs can be twice the size of u128 it ends up indexing out of bounds.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This code will need to both check that the initialized half of the scalarpair is the same value, then emit another memset for the uninitialized part, and be a bit more careful to use the correct size of the value being passed into the function.

compiler-errors

// CHECK-NOT: select
// CHECK: br label %repeat_loop_header{{.*}}
// CHECK-NOT: switch
// CHECK: icmp

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I copied all this from above :clueless:

@oli-obk

@bors r+ rollup

Has a really tiny effect on binary sizes, but that's not worth separating out of a rollup

@bors

📌 Commit 5f575bc has been approved by oli-obk

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

and removed S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

labels

Mar 3, 2025

bors added a commit to rust-lang-ci/rust that referenced this pull request

Mar 4, 2025

@bors

…iaskrgr

Rollup of 12 pull requests

Successful merges:

r? @ghost @rustbot modify labels: rollup

rust-timer added a commit to rust-lang-ci/rust that referenced this pull request

Mar 4, 2025

@rust-timer

@lqd

lqd commented

Mar 6, 2025

• Loading

We need this on beta to fix #137892

@rustbot label +beta-nominated cc @apiraino for late meeting addition (no rush, and no worries if it slips: 1.86 is a month away)

@lqd lqd added the beta-nominated

Nominated for backporting to the compiler in the beta channel.

label

Mar 6, 2025

@rustbot

This comment was marked as outdated.

@apiraino

Beta backport accepted as per compiler team on Zulip. A backport PR will be authored by the release team at the end of the current development cycle. Backport labels handled by them.

@rustbot label +beta-accepted

bors added a commit to rust-lang-ci/rust that referenced this pull request

Mar 8, 2025

@bors

[beta] backports

r? cuviper

bors added a commit to rust-lang-ci/rust that referenced this pull request

Mar 8, 2025

@bors

[beta] backports

r? cuviper

github-actions bot pushed a commit to model-checking/verify-rust-std that referenced this pull request

Mar 14, 2025

@bors

…iaskrgr

Rollup of 12 pull requests

Successful merges:

r? @ghost @rustbot modify labels: rollup

flip1995 pushed a commit to flip1995/rust that referenced this pull request

Mar 20, 2025

@bors

…iaskrgr

Rollup of 12 pull requests

Successful merges:

r? @ghost @rustbot modify labels: rollup

GuillaumeGomez pushed a commit to GuillaumeGomez/rust that referenced this pull request

Apr 18, 2025

@matthiaskrgr

…, r=oli-obk

Revert "store ScalarPair via memset when one side is undef and the other side can be memset"

cc rust-lang#137892 reverts rust-lang#135335

r? oli-obk

GuillaumeGomez pushed a commit to GuillaumeGomez/rust that referenced this pull request

Apr 18, 2025

@bors

…iaskrgr

Rollup of 12 pull requests

Successful merges:

r? @ghost @rustbot modify labels: rollup

Labels

beta-accepted

Accepted for backporting to the compiler in the beta channel.

S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

T-compiler

Relevant to the compiler team, which will review and decide on the PR/issue.