bootstrap and compiletest: Use size_of_val from the prelude instead of imported by thaliaarchi · Pull Request #138041 · rust-lang/rust (original) (raw)
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation10 Commits1 Checks6 Files changed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
Use std::mem::size_of_val from the prelude instead of importing or qualifying it.
This function was added to all preludes in Rust 1.80.
r? @jieyouxu
Area: The compiletest test runner
Area: The testsuite used to check the correctness of rustc
Status: Awaiting review from the assignee but also interested parties.
Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
labels
Some changes occurred in src/tools/compiletest
cc @jieyouxu
This comment has been minimized.
Looks like a spurious, unrelated failure?
Unrelated, gcc dist step network problem.
Thanks!
@bors r+ rollup
📌 Commit 1cacddc has been approved by jieyouxu
It is now in the queue for this repository.
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
jieyouxu added a commit to jieyouxu/rust that referenced this pull request
…ostrap-compiletest, r=jieyouxu
bootstrap and compiletest: Use size_of_val from the prelude instead of imported
Use std::mem::size_of_val from the prelude instead of importing or qualifying it.
This function was added to all preludes in Rust 1.80.
r? @jieyouxu
bors added a commit to rust-lang-ci/rust that referenced this pull request
Rollup of 23 pull requests
Successful merges:
- rust-lang#137303 (Remove
MaybeForgetReturnsuggestion) - rust-lang#137327 (Undeprecate env::home_dir)
- rust-lang#137358 (Match Ergonomics 2024: add context and examples to the unstable book)
- rust-lang#137534 ([rustdoc] hide item that is not marked as doc(inline) and whose src is doc(hidden))
- rust-lang#137565 (Try to point of macro expansion from resolver and method errors if it involves macro var)
- rust-lang#137637 (Check dyn flavor before registering upcast goal on wide pointer cast in MIR typeck)
- rust-lang#137643 (Add DWARF test case for non-C-like
repr128enums) - rust-lang#137744 (Re-add
Clone-derive onThir) - rust-lang#137758 (fix usage of ty decl macro fragments in attributes)
- rust-lang#137764 (Ensure that negative auto impls are always applicable)
- rust-lang#137772 (Fix char count in
DisplayforByteStr) - rust-lang#137798 (ci: use ubuntu 24 on arm large runner)
- rust-lang#137802 (miri native-call support: all previously exposed provenance is accessible to the callee)
- rust-lang#137805 (adjust Layout debug printing to match the internal field name)
- rust-lang#137808 (Do not require that unsafe fields lack drop glue)
- rust-lang#137820 (Clarify why InhabitedPredicate::instantiate_opt exists)
- rust-lang#137825 (Provide more context on resolve error caused from incorrect RTN)
- rust-lang#137910 (Improve error message for
AsyncFntrait failure for RPIT) - rust-lang#137920 (interpret/provenance_map: consistently use range_is_empty)
- rust-lang#138038 (Update
compiler-builtinsto 0.1.151) - rust-lang#138041 (bootstrap and compiletest: Use
size_of_valfrom the prelude instead of imported) - rust-lang#138046 (trim channel value in
get_closest_merge_commit) - rust-lang#138053 (Increase the max. custom try jobs requested to
20)
r? @ghost
@rustbot modify labels: rollup
There's a cfg(windows)-gated use std::mem in job.rs.
@bors r-
Status: This is awaiting some action (such as code changes or more information) from the author.
and removed S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
labels
…f imported
Use std::mem::size_of_val from the prelude instead of importing or
qualifying it.
This function was added to all preludes in Rust 1.80.
Don't worry, happens very frequently to me too when I don't feel like testing both linux and windows locally.
📌 Commit c85d3f6 has been approved by jieyouxu
It is now in the queue for this repository.
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
labels
Noratrieb added a commit to Noratrieb/rust that referenced this pull request
…ostrap-compiletest, r=jieyouxu
bootstrap and compiletest: Use size_of_val from the prelude instead of imported
Use std::mem::size_of_val from the prelude instead of importing or qualifying it.
This function was added to all preludes in Rust 1.80.
r? @jieyouxu
bors added a commit to rust-lang-ci/rust that referenced this pull request
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request
Rollup merge of rust-lang#138041 - thaliaarchi:use-prelude-size-of.boostrap-compiletest, r=jieyouxu
bootstrap and compiletest: Use size_of_val from the prelude instead of imported
Use std::mem::size_of_val from the prelude instead of importing or qualifying it.
This function was added to all preludes in Rust 1.80.
r? @jieyouxu
github-actions bot pushed a commit to model-checking/verify-rust-std that referenced this pull request
Labels
Area: The compiletest test runner
Area: The testsuite used to check the correctness of rustc
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)