Update the standard library to Rust 2024 by ehuss · Pull Request #138162 · rust-lang/rust (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation35 Commits13 Checks6 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

This updates the standard library to Rust 2024. This includes the following notable changes:

• Macros are updated to use new expression fragment specifiers. This PR includes a test to illustrate the changes, primarily allowing const {...} expressions now.
• Some tests show a change in MIR drop order. We do not believe this will be an observable change (see zulip discussion).

Fixes #133081

Luracasmus, hkBst, Kobzol, seandewar, CosminPerRam, CGMossa, Nukesor, and bbb651 reacted with hooray emoji scottmcm, alisterd51, CGMossa, and Luracasmus reacted with heart emoji

r? @BoxyUwU

rustbot has assigned @BoxyUwU.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

rustbot added A-run-make

Area: port run-make Makefiles to rmake.rs

S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

T-compiler

Relevant to the compiler team, which will review and decide on the PR/issue.

T-libs

Relevant to the library team, which will review and decide on the PR/issue.

labels

Mar 7, 2025

bors added a commit to rust-lang-ci/rust that referenced this pull request

Mar 7, 2025

Update the standard library to Rust 2024

This updates the standard library to Rust 2024. This includes the following notable changes:

• Macros are updated to use new expression fragment specifiers. This PR includes a test to illustrate the changes, primarily allowing const {...} expressions now.
• Some tests show a change in MIR drop order. We do not believe this will be an observable change (see zulip discussion).

Fixes rust-lang#133081

(Draft while I do some try jobs, as this is a high-risk of breakage.)

try-job: aarch64-apple try-job: aarch64-gnu try-job: arm-android try-job: armhf-gnu try-job: dist-aarch64-apple try-job: dist-aarch64-linux try-job: dist-aarch64-msvc try-job: dist-android try-job: dist-apple-various try-job: dist-arm-linux try-job: dist-armhf-linux try-job: dist-armv7-linux try-job: dist-i586-gnu-i586-i686-musl try-job: dist-i686-linux try-job: dist-i686-mingw try-job: dist-i686-msvc try-job: dist-loongarch64-linux try-job: dist-loongarch64-musl try-job: dist-ohos try-job: dist-powerpc-linux

☀️ Try build successful - checks-actions
Build commit: a525bde (a525bde7d4aebdcc7c7ebf678404cbaf6245a0c2)

bors added a commit to rust-lang-ci/rust that referenced this pull request

Mar 7, 2025

Update the standard library to Rust 2024

This updates the standard library to Rust 2024. This includes the following notable changes:

• Macros are updated to use new expression fragment specifiers. This PR includes a test to illustrate the changes, primarily allowing const {...} expressions now.
• Some tests show a change in MIR drop order. We do not believe this will be an observable change (see zulip discussion).

Fixes rust-lang#133081

(Draft while I do some try jobs, as this is a high-risk of breakage.)

try-job: dist-powerpc64-linux try-job: dist-powerpc64le-linux try-job: dist-riscv64-linux try-job: dist-s390x-linux try-job: dist-various-1 try-job: dist-various-2 try-job: dist-x86_64-apple try-job: dist-x86_64-freebsd try-job: dist-x86_64-illumos try-job: dist-x86_64-linux try-job: dist-x86_64-mingw try-job: dist-x86_64-msvc try-job: dist-x86_64-musl try-job: dist-x86_64-netbsd try-job: i686-gnu-1 try-job: i686-gnu-2 try-job: i686-mingw-1 try-job: i686-mingw-2 try-job: i686-mingw-3 try-job: i686-msvc-1

This comment has been minimized.

bors added S-waiting-on-author

Status: This is awaiting some action (such as code changes or more information) from the author.

and removed S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

labels

Mar 8, 2025

bors added a commit to rust-lang-ci/rust that referenced this pull request

Mar 8, 2025

Update the standard library to Rust 2024

This updates the standard library to Rust 2024. This includes the following notable changes:

• Macros are updated to use new expression fragment specifiers. This PR includes a test to illustrate the changes, primarily allowing const {...} expressions now.
• Some tests show a change in MIR drop order. We do not believe this will be an observable change (see zulip discussion).

Fixes rust-lang#133081

(Draft while I do some try jobs, as this is a high-risk of breakage.)

try-job: dist-powerpc64le-linux try-job: i686-gnu-1 try-job: i686-msvc-1 try-job: i686-msvc-2 try-job: mingw-check try-job: test-various try-job: x86_64-apple-1 try-job: x86_64-apple-2 try-job: x86_64-fuchsia try-job: x86_64-gnu-distcheck try-job: x86_64-gnu-tools try-job: x86_64-mingw-1 try-job: x86_64-mingw-2 try-job: x86_64-msvc-1 try-job: x86_64-msvc-2 try-job: x86_64-msvc-ext1 try-job: x86_64-msvc-ext2 try-job: x86_64-msvc-ext3 try-job: x86_64-rust-for-linux

This comment has been minimized.

@bors try

(weird random stack overflow in x86_64-mingw-1)

bors added a commit to rust-lang-ci/rust that referenced this pull request

Mar 8, 2025

Update the standard library to Rust 2024

This updates the standard library to Rust 2024. This includes the following notable changes:

• Macros are updated to use new expression fragment specifiers. This PR includes a test to illustrate the changes, primarily allowing const {...} expressions now.
• Some tests show a change in MIR drop order. We do not believe this will be an observable change (see zulip discussion).

Fixes rust-lang#133081

(Draft while I do some try jobs, as this is a high-risk of breakage.)

try-job: dist-powerpc64le-linux try-job: i686-gnu-1 try-job: i686-msvc-1 try-job: i686-msvc-2 try-job: x86_64-apple-1 try-job: x86_64-gnu-tools try-job: x86_64-mingw-1 try-job: x86_64-mingw-2 try-job: x86_64-msvc-1 try-job: x86_64-msvc-2 try-job: x86_64-msvc-ext1 try-job: x86_64-msvc-ext2 try-job: x86_64-msvc-ext3

This comment has been minimized.

cc @rust-lang/libs-api for the macro :expr upgrade -- while I understand the need for an edition boundary, I think this perfectly safe for macros we control, and should be a strict upgrade. Feel free to take API control of the review if needed, otherwise it looks good to me!

@rustbot label +relnotes
@bors r+

📌 Commit b130747 has been approved by cuviper

It is now in the queue for this repository.

rustbot added the relnotes

Marks issues that should be documented in the release notes of the next release.

label

Mar 11, 2025

bors added S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

and removed S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

labels

Mar 11, 2025

jieyouxu added a commit to jieyouxu/rust that referenced this pull request

Mar 12, 2025

jieyouxu added a commit to jieyouxu/rust that referenced this pull request

Mar 12, 2025

bors added a commit to rust-lang-ci/rust that referenced this pull request

Mar 12, 2025

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request

Mar 13, 2025

bors added a commit to rust-lang-ci/rust that referenced this pull request

Mar 13, 2025

…iaskrgr

Rollup of 9 pull requests

Successful merges:

• rust-lang#126856 (remove deprecated tool rls)
• rust-lang#133981 (rustdoc-json: Refractor and document Id's)
• rust-lang#136842 (Add libstd support for Trusty targets)
• rust-lang#137355 (Implement read_buf and vectored read/write for SGX stdio)
• rust-lang#137457 (fix for issue 132802: x86 code in wasm32-unknown-unknown binaries)
• rust-lang#138162 (Update the standard library to Rust 2024)
• rust-lang#138273 (metadata: Ignore sysroot when doing the manual native lib search in rustc)
• rust-lang#138346 (naked functions: on windows emit .endef without the symbol name)
• rust-lang#138370 (Simulate OOM for the try_oom_error test)

r? @ghost @rustbot modify labels: rollup

bors added a commit to rust-lang-ci/rust that referenced this pull request

Mar 13, 2025

…iaskrgr

Rollup of 8 pull requests

Successful merges:

• rust-lang#126856 (remove deprecated tool rls)
• rust-lang#133981 (rustdoc-json: Refractor and document Id's)
• rust-lang#136842 (Add libstd support for Trusty targets)
• rust-lang#137355 (Implement read_buf and vectored read/write for SGX stdio)
• rust-lang#138162 (Update the standard library to Rust 2024)
• rust-lang#138273 (metadata: Ignore sysroot when doing the manual native lib search in rustc)
• rust-lang#138346 (naked functions: on windows emit .endef without the symbol name)
• rust-lang#138370 (Simulate OOM for the try_oom_error test)

r? @ghost @rustbot modify labels: rollup

rust-timer added a commit to rust-lang-ci/rust that referenced this pull request

Mar 13, 2025

github-actions bot pushed a commit to model-checking/verify-rust-std that referenced this pull request

Mar 14, 2025

Labels

A-run-make

Area: port run-make Makefiles to rmake.rs

O-windows

Operating system: Windows

relnotes

Marks issues that should be documented in the release notes of the next release.

S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

T-compiler

Relevant to the compiler team, which will review and decide on the PR/issue.

T-libs

Relevant to the library team, which will review and decide on the PR/issue.