naked functions: on windows emit .endef without the symbol name by folkertdev · Pull Request #138346 · rust-lang/rust (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation3 Commits1 Checks6 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

tracking issue: #90957
fixes #138320

The .endef directive does not take the name as an argument. Apparently the LLVM x86_64 parser does accept this, but on i686 it's rejected. In general i686 does some special name mangling stuff, so it's good to include it in the naked function tests.

r? @ChrisDenton (because windows)

also add test with fastcall, which on i686 uses a different mangling scheme

rustbot added S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

T-compiler

Relevant to the compiler team, which will review and decide on the PR/issue.

labels

Mar 11, 2025

Some changes occurred in compiler/rustc_codegen_ssa

cc @WaffleLapkin

📌 Commit c0957ef has been approved by ChrisDenton

It is now in the queue for this repository.

bors added S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

and removed S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

labels

Mar 11, 2025

jieyouxu added a commit to jieyouxu/rust that referenced this pull request

Mar 12, 2025

…, r=ChrisDenton

naked functions: on windows emit .endef without the symbol name

tracking issue: rust-lang#90957 fixes rust-lang#138320

The .endef directive does not take the name as an argument. Apparently the LLVM x86_64 parser does accept this, but on i686 it's rejected. In general i686 does some special name mangling stuff, so it's good to include it in the naked function tests.

r? @ChrisDenton (because windows)

jieyouxu added a commit to jieyouxu/rust that referenced this pull request

Mar 12, 2025

…, r=ChrisDenton

naked functions: on windows emit .endef without the symbol name

tracking issue: rust-lang#90957 fixes rust-lang#138320

The .endef directive does not take the name as an argument. Apparently the LLVM x86_64 parser does accept this, but on i686 it's rejected. In general i686 does some special name mangling stuff, so it's good to include it in the naked function tests.

r? @ChrisDenton (because windows)

bors added a commit to rust-lang-ci/rust that referenced this pull request

Mar 12, 2025

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request

Mar 13, 2025

…, r=ChrisDenton

naked functions: on windows emit .endef without the symbol name

tracking issue: rust-lang#90957 fixes rust-lang#138320

The .endef directive does not take the name as an argument. Apparently the LLVM x86_64 parser does accept this, but on i686 it's rejected. In general i686 does some special name mangling stuff, so it's good to include it in the naked function tests.

r? @ChrisDenton (because windows)

bors added a commit to rust-lang-ci/rust that referenced this pull request

Mar 13, 2025

…iaskrgr

Rollup of 9 pull requests

Successful merges:

• rust-lang#126856 (remove deprecated tool rls)
• rust-lang#133981 (rustdoc-json: Refractor and document Id's)
• rust-lang#136842 (Add libstd support for Trusty targets)
• rust-lang#137355 (Implement read_buf and vectored read/write for SGX stdio)
• rust-lang#137457 (fix for issue 132802: x86 code in wasm32-unknown-unknown binaries)
• rust-lang#138162 (Update the standard library to Rust 2024)
• rust-lang#138273 (metadata: Ignore sysroot when doing the manual native lib search in rustc)
• rust-lang#138346 (naked functions: on windows emit .endef without the symbol name)
• rust-lang#138370 (Simulate OOM for the try_oom_error test)

r? @ghost @rustbot modify labels: rollup

bors added a commit to rust-lang-ci/rust that referenced this pull request

Mar 13, 2025

…iaskrgr

Rollup of 8 pull requests

Successful merges:

• rust-lang#126856 (remove deprecated tool rls)
• rust-lang#133981 (rustdoc-json: Refractor and document Id's)
• rust-lang#136842 (Add libstd support for Trusty targets)
• rust-lang#137355 (Implement read_buf and vectored read/write for SGX stdio)
• rust-lang#138162 (Update the standard library to Rust 2024)
• rust-lang#138273 (metadata: Ignore sysroot when doing the manual native lib search in rustc)
• rust-lang#138346 (naked functions: on windows emit .endef without the symbol name)
• rust-lang#138370 (Simulate OOM for the try_oom_error test)

r? @ghost @rustbot modify labels: rollup

rust-timer added a commit to rust-lang-ci/rust that referenced this pull request

Mar 13, 2025

Rollup merge of rust-lang#138346 - folkertdev:naked-asm-windows-endef, r=ChrisDenton

naked functions: on windows emit .endef without the symbol name

tracking issue: rust-lang#90957 fixes rust-lang#138320

The .endef directive does not take the name as an argument. Apparently the LLVM x86_64 parser does accept this, but on i686 it's rejected. In general i686 does some special name mangling stuff, so it's good to include it in the naked function tests.

r? @ChrisDenton (because windows)

Labels

S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

T-compiler

Relevant to the compiler team, which will review and decide on the PR/issue.