ports the compiler test cases to new rust_intrinsic format by BLANKatGITHUB · Pull Request #138364 · rust-lang/rust (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation26 Commits1 Checks6 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

rustbot has assigned @BoxyUwU.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

rustbot added S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

Relevant to the compiler team, which will review and decide on the PR/issue.

has-merge-commits

PR has merge commits, merge with caution.

S-waiting-on-author

Status: This is awaiting some action (such as code changes or more information) from the author.

labels

This comment has been minimized.

@RalfJung I ran test rustc_error_codes and the test passed on my local machine.

First of all, please pick a PR title ~~and description~~ that actually says something about what the PR does. :)

BLANKatGITHUB changed the title~~Compiler~~ ports the compiler test cases to new rust_intrinsic format

This comment has been minimized.

Should we bless the test?

You'll need to provide a definition for the static, as the error says.

fn simd_add(a: T, b: T) -> T;
}
#[rustc_intrinsic]
unsafe fn simd_add(_a: T, _b: T) -> T;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the leading _ again (everywhere in this PR)

This comment has been minimized.

// error: intrinsic must be a function
}
#[rustc_intrinsic]
pub static atomic_singlethreadfence_seqcst: fn() = \|

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

| pub static atomic_singlethreadfence_seqcst: fn() = || {}; | | ------------------------------------------------------------ | | #[allow(non_upper_case_globals)] | | pub static atomic_singlethreadfence_seqcst: fn() = || {}; |

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the problem is pub static atomic_singlethreadfence_seqcst: fn() = || {}; as the atomic_singlethreadfence_seqcst being declared as a static fn declared as an empty closer making the test cases pass which should have been failed .

It should be pub static atomic_singlethreadfence_seqcst: fn() ; but it gives the error "provide a definition for the static" instead of the expected one

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems there is a bug somewhere, and we are not complaining when #[rustc_intrinsic] is used on a non-function (and then likely being ignored).

@oli-obk is that deliberate? Any suggestion for what to do with this old test?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's a rustc attribute, it's fine to just not work on things and/or ICE. ICEing is better, but there is no requirement for it.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay so the error code E0622 should just be removed then when we remove the ABI.

@BLANKatGITHUB just leave E0622.md unchanged in this PR.

This comment has been minimized.

@rustbot author
There are still CI failures.

rustbot added the S-waiting-on-author

Status: This is awaiting some action (such as code changes or more information) from the author.

label

Update compiler/rustc_error_codes/src/error_codes/E0622.md

Co-authored-by: Ralf Jung post@ralfj.de

reverted chages on E0622.md

updated E0622.md

Thanks, LGTM!

@bors r+ rollup

📌 Commit a3669b8 has been approved by RalfJung

It is now in the queue for this repository.

🌲 The tree is currently closed for pull requests below priority 100. This pull request will be tested once the tree is reopened.

bors added S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

and removed S-waiting-on-author

Status: This is awaiting some action (such as code changes or more information) from the author.

labels

jieyouxu added a commit to jieyouxu/rust that referenced this pull request

ports the compiler test cases to new rust_intrinsic format

pr is part of rust-lang#132735

bors added a commit to rust-lang-ci/rust that referenced this pull request

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request

ports the compiler test cases to new rust_intrinsic format

pr is part of rust-lang#132735

bors added a commit to rust-lang-ci/rust that referenced this pull request

Rollup of 10 pull requests

Successful merges:

rust-lang#138364 (ports the compiler test cases to new rust_intrinsic format)
rust-lang#138570 (add naked_functions_target_feature unstable feature)
rust-lang#138623 ([bootstrap] Use llvm_runtimes for compiler-rt)
rust-lang#138627 (Autodiff cleanups)
rust-lang#138669 (tests: accept some noise from LLVM 21 in symbols-all-mangled)
rust-lang#138706 (Improve bootstrap git modified path handling)
rust-lang#138709 (Update GCC submodule)
rust-lang#138717 (Add an attribute that makes the spans from a macro edition 2021, and fix pin on edition 2024 with it)
rust-lang#138721 (Use explicit cpu in some asm and codegen tests.)
rust-lang#138728 (Update compiler-builtins to 0.1.152)

r? @ghost @rustbot modify labels: rollup

try-job: aarch64-apple try-job: x86_64-msvc-1 try-job: x86_64-gnu try-job: dist-i586-gnu-i586-i686-musl

bors added a commit to rust-lang-ci/rust that referenced this pull request

…iaskrgr

Rollup of 10 pull requests

Successful merges:

rust-lang#138364 (ports the compiler test cases to new rust_intrinsic format)
rust-lang#138570 (add naked_functions_target_feature unstable feature)
rust-lang#138623 ([bootstrap] Use llvm_runtimes for compiler-rt)
rust-lang#138627 (Autodiff cleanups)
rust-lang#138669 (tests: accept some noise from LLVM 21 in symbols-all-mangled)
rust-lang#138706 (Improve bootstrap git modified path handling)
rust-lang#138709 (Update GCC submodule)
rust-lang#138717 (Add an attribute that makes the spans from a macro edition 2021, and fix pin on edition 2024 with it)
rust-lang#138721 (Use explicit cpu in some asm and codegen tests.)
rust-lang#138728 (Update compiler-builtins to 0.1.152)

r? @ghost @rustbot modify labels: rollup

try-job: aarch64-apple try-job: x86_64-msvc-1 try-job: x86_64-gnu try-job: dist-i586-gnu-i586-i686-musl

Kobzol added a commit to Kobzol/rust that referenced this pull request

ports the compiler test cases to new rust_intrinsic format

pr is part of rust-lang#132735

bors added a commit to rust-lang-ci/rust that referenced this pull request

…iaskrgr

Rollup of 9 pull requests

Successful merges:

rust-lang#138364 (ports the compiler test cases to new rust_intrinsic format)
rust-lang#138570 (add naked_functions_target_feature unstable feature)
rust-lang#138623 ([bootstrap] Use llvm_runtimes for compiler-rt)
rust-lang#138627 (Autodiff cleanups)
rust-lang#138669 (tests: accept some noise from LLVM 21 in symbols-all-mangled)
rust-lang#138706 (Improve bootstrap git modified path handling)
rust-lang#138709 (Update GCC submodule)
rust-lang#138717 (Add an attribute that makes the spans from a macro edition 2021, and fix pin on edition 2024 with it)
rust-lang#138721 (Use explicit cpu in some asm and codegen tests.)

r? @ghost @rustbot modify labels: rollup

rust-timer added a commit to rust-lang-ci/rust that referenced this pull request

Labels

S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

Relevant to the compiler team, which will review and decide on the PR/issue.