Use explicit cpu in some asm and codegen tests. by jchecahi · Pull Request #138721 · rust-lang/rust (original) (raw)
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation3 Commits1 Checks6 Files changed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
Some tests expect to be compiled for a specific CPU or require certain target features to be present (or absent). These tests work fine with default CPUs but fail in downstream builds for RHEL and Fedora, where we use non-default CPUs such as z13 on s390x, pwr9 on ppc64le, or x86-64-v2/x86-64-v3 on x86_64.
This is similar to #124597.
Some tests expect to be compiled for a specific CPU or require certain target features to be present (or absent). These tests work fine with default CPUs but fail in downstream builds for RHEL and Fedora, where we use non-default CPUs such as z13 on s390x, pwr9 on ppc64le, or x86-64-v2/x86-64-v3 on x86_64.
r? @estebank
rustbot has assigned @estebank.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.
Use r? to explicitly pick a reviewer
Status: Awaiting review from the assignee but also interested parties.
Relevant to the compiler team, which will review and decide on the PR/issue.
labels
📌 Commit 20432c9 has been approved by tgross35
It is now in the queue for this repository.
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request
…ross35
Use explicit cpu in some asm and codegen tests.
Some tests expect to be compiled for a specific CPU or require certain target features to be present (or absent). These tests work fine with default CPUs but fail in downstream builds for RHEL and Fedora, where we use non-default CPUs such as z13 on s390x, pwr9 on ppc64le, or x86-64-v2/x86-64-v3 on x86_64.
This is similar to rust-lang#124597.
bors added a commit to rust-lang-ci/rust that referenced this pull request
Rollup of 10 pull requests
Successful merges:
- rust-lang#138364 (ports the compiler test cases to new rust_intrinsic format)
- rust-lang#138570 (add
naked_functions_target_featureunstable feature) - rust-lang#138623 ([bootstrap] Use llvm_runtimes for compiler-rt)
- rust-lang#138627 (Autodiff cleanups)
- rust-lang#138669 (tests: accept some noise from LLVM 21 in symbols-all-mangled)
- rust-lang#138706 (Improve bootstrap git modified path handling)
- rust-lang#138709 (Update GCC submodule)
- rust-lang#138717 (Add an attribute that makes the spans from a macro edition 2021, and fix pin on edition 2024 with it)
- rust-lang#138721 (Use explicit cpu in some asm and codegen tests.)
- rust-lang#138728 (Update
compiler-builtinsto 0.1.152)
r? @ghost
@rustbot modify labels: rollup
try-job: aarch64-apple try-job: x86_64-msvc-1 try-job: x86_64-gnu try-job: dist-i586-gnu-i586-i686-musl
bors added a commit to rust-lang-ci/rust that referenced this pull request
…iaskrgr
Rollup of 10 pull requests
Successful merges:
- rust-lang#138364 (ports the compiler test cases to new rust_intrinsic format)
- rust-lang#138570 (add
naked_functions_target_featureunstable feature) - rust-lang#138623 ([bootstrap] Use llvm_runtimes for compiler-rt)
- rust-lang#138627 (Autodiff cleanups)
- rust-lang#138669 (tests: accept some noise from LLVM 21 in symbols-all-mangled)
- rust-lang#138706 (Improve bootstrap git modified path handling)
- rust-lang#138709 (Update GCC submodule)
- rust-lang#138717 (Add an attribute that makes the spans from a macro edition 2021, and fix pin on edition 2024 with it)
- rust-lang#138721 (Use explicit cpu in some asm and codegen tests.)
- rust-lang#138728 (Update
compiler-builtinsto 0.1.152)
r? @ghost
@rustbot modify labels: rollup
try-job: aarch64-apple try-job: x86_64-msvc-1 try-job: x86_64-gnu try-job: dist-i586-gnu-i586-i686-musl
bors added a commit to rust-lang-ci/rust that referenced this pull request
…iaskrgr
Rollup of 9 pull requests
Successful merges:
- rust-lang#138364 (ports the compiler test cases to new rust_intrinsic format)
- rust-lang#138570 (add
naked_functions_target_featureunstable feature) - rust-lang#138623 ([bootstrap] Use llvm_runtimes for compiler-rt)
- rust-lang#138627 (Autodiff cleanups)
- rust-lang#138669 (tests: accept some noise from LLVM 21 in symbols-all-mangled)
- rust-lang#138706 (Improve bootstrap git modified path handling)
- rust-lang#138709 (Update GCC submodule)
- rust-lang#138717 (Add an attribute that makes the spans from a macro edition 2021, and fix pin on edition 2024 with it)
- rust-lang#138721 (Use explicit cpu in some asm and codegen tests.)
r? @ghost
@rustbot modify labels: rollup
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request
Rollup merge of rust-lang#138721 - jchecahi:tests-explicit-cpus, r=tgross35
Use explicit cpu in some asm and codegen tests.
Some tests expect to be compiled for a specific CPU or require certain target features to be present (or absent). These tests work fine with default CPUs but fail in downstream builds for RHEL and Fedora, where we use non-default CPUs such as z13 on s390x, pwr9 on ppc64le, or x86-64-v2/x86-64-v3 on x86_64.
This is similar to rust-lang#124597.
Labels
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Relevant to the compiler team, which will review and decide on the PR/issue.