rustc_resolve: fix instability in lib.rmeta contents by durin42 · Pull Request #138678 · rust-lang/rust (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation13 Commits3 Checks6 Files changed

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

23032f31c91f2 accidentally introduced some nondeterminism in the ordering of lib.rmeta files, which we caught in our bazel-based builds only recently due to being further behind than normal. In my testing, this fixes the issue.

r? @fmease

rustbot has assigned @fmease.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

rustbot added S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

T-compiler

Relevant to the compiler team, which will review and decide on the PR/issue.

labels

Mar 18, 2025

This comment has been minimized.

rust-lang/rust@23032f31c91f2 accidentally introduced some nondeterminism in the ordering of lib.rmeta files, which we caught in our bazel-based builds only recently due to being further behind than normal. In my testing, this fixes the issue.

These commits modify the Cargo.lock file. Unintentional changes to Cargo.lock can be introduced when switching branches and rebasing PRs.

If this was unintentional then you should revert the changes before this PR is merged.
Otherwise, you can ignore this comment.

Sorry for the delay, thanks!

@bors r+ rollup

📌 Commit 795a666 has been approved by fmease

It is now in the queue for this repository.

bors added S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

and removed S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

labels

Mar 27, 2025

Wait, could you also update the callsite of reference_definitions in src/librustdoc/html/markdown.rs?

@bors r-

bors added S-waiting-on-author

Status: This is awaiting some action (such as code changes or more information) from the author.

and removed S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

labels

Mar 27, 2025

rustbot added the T-rustdoc-frontend

Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output.

label

Mar 27, 2025

Wait, could you also update the callsite of reference_definitions in src/librustdoc/html/markdown.rs?

@bors r-

Done

This came up in review, and it should help some future author not introduce non-deterministic output here.

📌 Commit 1437dec has been approved by fmease

It is now in the queue for this repository.

bors added S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

and removed S-waiting-on-author

Status: This is awaiting some action (such as code changes or more information) from the author.

labels

Mar 28, 2025

bors added a commit to rust-lang-ci/rust that referenced this pull request

Mar 28, 2025

…iaskrgr

Rollup of 7 pull requests

Successful merges:

• rust-lang#137889 (update outdated doc with new example)
• rust-lang#138104 (Greatly simplify doctest parsing and information extraction)
• rust-lang#138678 (rustc_resolve: fix instability in lib.rmeta contents)
• rust-lang#138986 (feat(config): Add ChangeId enum for suppressing warnings)
• rust-lang#139038 (Update target maintainers for thumb targets to reflect new REWG Arm team name)
• rust-lang#139045 (bootstrap: update test_find test)
• rust-lang#139047 (Remove ScopeDepth)

Failed merges:

• rust-lang#139044 (bootstrap: Avoid cloning change-id list)

r? @ghost @rustbot modify labels: rollup

bors added a commit to rust-lang-ci/rust that referenced this pull request

Mar 28, 2025

…iaskrgr

Rollup of 7 pull requests

Successful merges:

• rust-lang#137889 (update outdated doc with new example)
• rust-lang#138104 (Greatly simplify doctest parsing and information extraction)
• rust-lang#138678 (rustc_resolve: fix instability in lib.rmeta contents)
• rust-lang#138986 (feat(config): Add ChangeId enum for suppressing warnings)
• rust-lang#139038 (Update target maintainers for thumb targets to reflect new REWG Arm team name)
• rust-lang#139045 (bootstrap: update test_find test)
• rust-lang#139047 (Remove ScopeDepth)

Failed merges:

• rust-lang#139044 (bootstrap: Avoid cloning change-id list)

r? @ghost @rustbot modify labels: rollup

rust-timer added a commit to rust-lang-ci/rust that referenced this pull request

Mar 28, 2025

Rollup merge of rust-lang#138678 - durin42:rmeta-stability, r=fmease

rustc_resolve: fix instability in lib.rmeta contents

rust-lang/rust@23032f31c91f2 accidentally introduced some nondeterminism in the ordering of lib.rmeta files, which we caught in our bazel-based builds only recently due to being further behind than normal. In my testing, this fixes the issue.

Labels

S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

T-compiler

Relevant to the compiler team, which will review and decide on the PR/issue.

T-rustdoc-frontend

Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output.