bootstrap: Avoid cloning change-id list by thaliaarchi · Pull Request #139044 · rust-lang/rust (original) (raw)

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters

[ Show hidden characters]({{ revealButtonHref }})

Inspired by recent discussion on the bootstrap change-id field, I took a look at the code and found this little optimization. It does not change behavior.

r? @onur-ozkan

rustbot has assigned @onur-ozkan.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

rustbot added S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

T-bootstrap

Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

labels

Mar 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like a good improvement!

Waiting for the CI to turn green.

This comment has been minimized.

There is a linting error.

@rustbot author

rustbot added S-waiting-on-author

Status: This is awaiting some action (such as code changes or more information) from the author.

and removed S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

labels

Mar 28, 2025

📌 Commit ad29f94 has been approved by onur-ozkan

It is now in the queue for this repository.

bors added S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

and removed S-waiting-on-author

Status: This is awaiting some action (such as code changes or more information) from the author.

labels

Mar 28, 2025

bors added a commit to rust-lang-ci/rust that referenced this pull request

Mar 28, 2025

…iaskrgr

Rollup of 7 pull requests

Successful merges:

• rust-lang#137889 (update outdated doc with new example)
• rust-lang#138104 (Greatly simplify doctest parsing and information extraction)
• rust-lang#138678 (rustc_resolve: fix instability in lib.rmeta contents)
• rust-lang#138986 (feat(config): Add ChangeId enum for suppressing warnings)
• rust-lang#139038 (Update target maintainers for thumb targets to reflect new REWG Arm team name)
• rust-lang#139045 (bootstrap: update test_find test)
• rust-lang#139047 (Remove ScopeDepth)

Failed merges:

• rust-lang#139044 (bootstrap: Avoid cloning change-id list)

r? @ghost @rustbot modify labels: rollup

bors added a commit to rust-lang-ci/rust that referenced this pull request

Mar 28, 2025

…iaskrgr

Rollup of 7 pull requests

Successful merges:

• rust-lang#137889 (update outdated doc with new example)
• rust-lang#138104 (Greatly simplify doctest parsing and information extraction)
• rust-lang#138678 (rustc_resolve: fix instability in lib.rmeta contents)
• rust-lang#138986 (feat(config): Add ChangeId enum for suppressing warnings)
• rust-lang#139038 (Update target maintainers for thumb targets to reflect new REWG Arm team name)
• rust-lang#139045 (bootstrap: update test_find test)
• rust-lang#139047 (Remove ScopeDepth)

Failed merges:

• rust-lang#139044 (bootstrap: Avoid cloning change-id list)

r? @ghost @rustbot modify labels: rollup

bors added a commit to rust-lang-ci/rust that referenced this pull request

Mar 28, 2025

bors added S-waiting-on-author

Status: This is awaiting some action (such as code changes or more information) from the author.

and removed S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

labels

Mar 28, 2025

So it did conflict with #138986. Rebased.

📌 Commit fbe5e55 has been approved by onur-ozkan

It is now in the queue for this repository.

bors added S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

and removed S-waiting-on-author

Status: This is awaiting some action (such as code changes or more information) from the author.

labels

Mar 28, 2025

jhpratt added a commit to jhpratt/rust that referenced this pull request

Mar 29, 2025

bors added a commit to rust-lang-ci/rust that referenced this pull request

Mar 29, 2025

jhpratt added a commit to jhpratt/rust that referenced this pull request

Mar 29, 2025

bors added a commit to rust-lang-ci/rust that referenced this pull request

Mar 29, 2025

jhpratt added a commit to jhpratt/rust that referenced this pull request

Mar 30, 2025

bors added a commit to rust-lang-ci/rust that referenced this pull request

Mar 30, 2025

Rollup of 5 pull requests

Successful merges:

• rust-lang#137836 (Set target_vendor = "openwrt" on mips64-openwrt-linux-musl)
• rust-lang#138206 ([AIX] Ignore linting on repr(C) structs with repr(packed) or repr(align(n)))
• rust-lang#139044 (bootstrap: Avoid cloning change-id list)
• rust-lang#139092 (Move fd into std::sys)
• rust-lang#139111 (Properly document FakeReads)

r? @ghost @rustbot modify labels: rollup

jhpratt added a commit to jhpratt/rust that referenced this pull request

Mar 30, 2025

bors added a commit to rust-lang-ci/rust that referenced this pull request

Mar 30, 2025

Rollup of 6 pull requests

Successful merges:

• rust-lang#139044 (bootstrap: Avoid cloning change-id list)
• rust-lang#139111 (Properly document FakeReads)
• rust-lang#139113 (unstable book: in a sanitizer example, check the code)
• rust-lang#139122 (Remove attribute #[rustc_error])
• rust-lang#139132 (Improve hir_pretty for struct expressions.)
• rust-lang#139141 (Switch some rustc_on_unimplemented uses to diagnostic::on_unimplemented)

r? @ghost @rustbot modify labels: rollup

bors added a commit to rust-lang-ci/rust that referenced this pull request

Mar 31, 2025

Rollup of 5 pull requests

Successful merges:

• rust-lang#139044 (bootstrap: Avoid cloning change-id list)
• rust-lang#139111 (Properly document FakeReads)
• rust-lang#139122 (Remove attribute #[rustc_error])
• rust-lang#139132 (Improve hir_pretty for struct expressions.)
• rust-lang#139141 (Switch some rustc_on_unimplemented uses to diagnostic::on_unimplemented)

r? @ghost @rustbot modify labels: rollup

rust-timer added a commit to rust-lang-ci/rust that referenced this pull request

Mar 31, 2025

github-actions bot pushed a commit to model-checking/verify-rust-std that referenced this pull request

Apr 2, 2025

Rollup of 5 pull requests

Successful merges:

• rust-lang#139044 (bootstrap: Avoid cloning change-id list)
• rust-lang#139111 (Properly document FakeReads)
• rust-lang#139122 (Remove attribute #[rustc_error])
• rust-lang#139132 (Improve hir_pretty for struct expressions.)
• rust-lang#139141 (Switch some rustc_on_unimplemented uses to diagnostic::on_unimplemented)

r? @ghost @rustbot modify labels: rollup

Labels

S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

T-bootstrap

Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)