Move sys::pal::os::Env into sys::env by thaliaarchi · Pull Request #140143 · rust-lang/rust (original) (raw)
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation2 Commits5 Checks6 Files changed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
Although Env (as Vars), Args, path functions, and OS constants are publicly exposed via std::env, their implementations are each self-contained. Keep them separate in std::sys and make a new module, sys::env, for Env.
Also fix unsafe_op_in_unsafe_fn for Unix and update the !DynSend and !DynSync impls which had grown out of sync with the platforms (see #48005 for discussion on that).
r? joboet
Tracked in #117276.
Although Env (as Vars), Args, path functions, and OS constants are
publicly exposed via std::env, their implementations are each
self-contained. Keep them separate in std::sys and make a new module,
sys::env, for Env.
These have grown out of sync with the platforms.
Operating System: Hermit
Target: SGX
Operating System: SOLID
Operating system: Unix-like
Operating system: Wasi, Webassembly System Interface
Operating system: Windows
Status: Awaiting review from the assignee but also interested parties.
Relevant to the compiler team, which will review and decide on the PR/issue.
Relevant to the library team, which will review and decide on the PR/issue.
labels
Also, update the same pattern of reuse in sys::args to match.
📌 Commit 01485c9 has been approved by joboet
It is now in the queue for this repository.
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Zalathar added a commit to Zalathar/rust that referenced this pull request
Move sys::pal::os::Env into sys::env
Although Env (as Vars), Args, path functions, and OS constants are publicly exposed via std::env, their implementations are each self-contained. Keep them separate in std::sys and make a new module, sys::env, for Env.
Also fix unsafe_op_in_unsafe_fn for Unix and update the !DynSend and !DynSync impls which had grown out of sync with the platforms (see rust-lang#48005 for discussion on that).
r? joboet
Tracked in rust-lang#117276.
bors added a commit to rust-lang-ci/rust that referenced this pull request
bors added a commit to rust-lang-ci/rust that referenced this pull request
…iaskrgr
Rollup of 8 pull requests
Successful merges:
- rust-lang#137653 (Deprecate the unstable
concat_idents!) - rust-lang#138957 (Update the index of Option to make the summary more comprehensive)
- rust-lang#140006 (ensure compiler existance of tools on the dist step)
- rust-lang#140143 (Move
sys::pal::os::Envintosys::env) - rust-lang#140202 (Make #![feature(let_chains)] bootstrap conditional in compiler/)
- rust-lang#140236 (norm nested aliases before evaluating the parent goal)
- rust-lang#140257 (Some drive-by housecleaning in
rustc_borrowck) - rust-lang#140278 (Don't use item name to look up associated item from trait item)
r? @ghost
@rustbot modify labels: rollup
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request
Rollup merge of rust-lang#140143 - thaliaarchi:move-env-pal, r=joboet
Move sys::pal::os::Env into sys::env
Although Env (as Vars), Args, path functions, and OS constants are publicly exposed via std::env, their implementations are each self-contained. Keep them separate in std::sys and make a new module, sys::env, for Env.
Also fix unsafe_op_in_unsafe_fn for Unix and update the !DynSend and !DynSync impls which had grown out of sync with the platforms (see rust-lang#48005 for discussion on that).
r? joboet
Tracked in rust-lang#117276.
Labels
Operating System: Hermit
Target: SGX
Operating System: SOLID
Operating system: Unix-like
Operating system: Wasi, Webassembly System Interface
Operating system: Windows
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Relevant to the compiler team, which will review and decide on the PR/issue.
Relevant to the library team, which will review and decide on the PR/issue.