Some drive-by housecleaning in rustc_borrowck by amandasystems · Pull Request #140257 · rust-lang/rust (original) (raw)
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation7 Commits1 Checks6 Files changed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
This commit picks up a few odd ends discovered during the work on #130227. It adds some documentation and renames a few methods with too generic names to describe what they actually do. It also adds some debug output that was helpful during bug hunting and generally cleans up a few things (for my values of "clean").
r? lcnr
Status: Awaiting review from the assignee but also interested parties.
Relevant to the compiler team, which will review and decide on the PR/issue.
labels
Hm, on a second thought this is straightforward enough not to need @lcnr specifically.
r? rust-lang/compiler
Nice cleanup!
r=me when CI is green
@bors rollup
📌 Commit d8528c6 has been approved by wesleywiser
It is now in the queue for this repository.
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request
…leywiser
Some drive-by housecleaning in rustc_borrowck
This commit picks up a few odd ends discovered during the work on rust-lang#130227. It adds some documentation and renames a few methods with too generic names to describe what they actually do. It also adds some debug output that was helpful during bug hunting and generally cleans up a few things (for my values of "clean").
r? lcnr
This commit picks up a few odd ends discovered during the work on rust-lang#130227. It adds some documentation and renames a few methods with too generic names to describe what they actually do. It also adds some debug output that was helpful during bug hunting.
bors added a commit to rust-lang-ci/rust that referenced this pull request
…iaskrgr
Rollup of 8 pull requests
Successful merges:
- rust-lang#137653 (Deprecate the unstable
concat_idents!) - rust-lang#138957 (Update the index of Option to make the summary more comprehensive)
- rust-lang#140006 (ensure compiler existance of tools on the dist step)
- rust-lang#140143 (Move
sys::pal::os::Envintosys::env) - rust-lang#140202 (Make #![feature(let_chains)] bootstrap conditional in compiler/)
- rust-lang#140236 (norm nested aliases before evaluating the parent goal)
- rust-lang#140257 (Some drive-by housecleaning in
rustc_borrowck) - rust-lang#140278 (Don't use item name to look up associated item from trait item)
r? @ghost
@rustbot modify labels: rollup
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request
Rollup merge of rust-lang#140257 - amandasystems:housecleaning, r=wesleywiser
Some drive-by housecleaning in rustc_borrowck
This commit picks up a few odd ends discovered during the work on rust-lang#130227. It adds some documentation and renames a few methods with too generic names to describe what they actually do. It also adds some debug output that was helpful during bug hunting and generally cleans up a few things (for my values of "clean").
r? lcnr
Status: This is awaiting some action (such as code changes or more information) from the author.
and removed S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
labels
Ok this is more work than that stray single space is worth…
Labels
Status: This is awaiting some action (such as code changes or more information) from the author.
Relevant to the compiler team, which will review and decide on the PR/issue.