Rustdoc: typecheck scrape-examples.js by lolbinarycat · Pull Request #140314 · rust-lang/rust (original) (raw)
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation17 Commits6 Checks6 Files changed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
[ Show hidden characters]({{ revealButtonHref }})
more typechecking progress, this time we're mostly held back by the fact that document.querySelectorAll can't return nice types if its given a compound query (see the issue linked in a code comment).
Additionally, it seems like the generated data-locs attribute has fields that are never used by anything?
r? @notriddle
Status: Awaiting review from the assignee but also interested parties.
Relevant to the library team, which will review and decide on the PR/issue.
Relevant to the rustdoc team, which will review and decide on the PR/issue.
Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output.
labels
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Co-authored-by: Guillaume Gomez guillaume1.gomez@gmail.com
Rustdoc js scrape examples typecheck Rustdoc: typecheck scrape-examples.js
📌 Commit c021e7a has been approved by notriddle
It is now in the queue for this repository.
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
label
jhpratt added a commit to jhpratt/rust that referenced this pull request
…mples-typecheck, r=notriddle
Rustdoc: typecheck scrape-examples.js
more typechecking progress, this time we're mostly held back by the fact that document.querySelectorAll can't return nice types if its given a compound query (see the issue linked in a code comment).
Additionally, it seems like the generated data-locs attribute has fields that are never used by anything?
r? @notriddle
jhpratt added a commit to jhpratt/rust that referenced this pull request
…mples-typecheck, r=notriddle
Rustdoc: typecheck scrape-examples.js
more typechecking progress, this time we're mostly held back by the fact that document.querySelectorAll can't return nice types if its given a compound query (see the issue linked in a code comment).
Additionally, it seems like the generated data-locs attribute has fields that are never used by anything?
r? @notriddle
This was referenced
Aug 19, 2025
bors added a commit that referenced this pull request
Rollup of 13 pull requests
Successful merges:
- #139357 (Fix parameter order for
_by()variants ofmin/max/minmaxinstd::cmp) - #140314 (Rustdoc: typecheck scrape-examples.js)
- #140794 (mention lint group in default level lint note)
- #145006 (Clarify EOF handling for
BufRead::skip_until) - #145252 (Demote x86_64-apple-darwin to Tier 2 with host tools)
- #145359 (Fix bug where
rustdoc-jstester would not pick the rightsearch.jsfile if there is more than one) - #145381 (Implement feature
int_lowest_highest_onefor integer and NonZero types) - #145417 (std_detect: RISC-V platform guide documentation)
- #145531 (Add runtime detection for APX-F and AVX10)
- #145619 (
std_detect: Userustc-std-workspace-*to pull incompiler-builtins) - #145622 (Remove the std workspace patch for
compiler-builtins) - #145623 (Pretty print the name of an future from calling async closure)
- #145626 (add a fallback implementation for the
prefetch_*intrinsics )
r? @ghost
@rustbot modify labels: rollup
rust-timer added a commit that referenced this pull request
Rollup merge of #140314 - lolbinarycat:rustdoc-js-scrape-examples-typecheck, r=notriddle
Rustdoc: typecheck scrape-examples.js
more typechecking progress, this time we're mostly held back by the fact that document.querySelectorAll can't return nice types if its given a compound query (see the issue linked in a code comment).
Additionally, it seems like the generated data-locs attribute has fields that are never used by anything?
r? @notriddle
github-actions bot pushed a commit to rust-lang/miri that referenced this pull request
Labels
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Relevant to the library team, which will review and decide on the PR/issue.
Relevant to the rustdoc team, which will review and decide on the PR/issue.
Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output.